Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Jim Mattson
On Wed, Nov 8, 2023 at 9:27 AM Alexander Graf wrote: > My point with the comment on this patch was "Don't break AMD (or ancient > VMX without instruction length decoding [Does that exist? I know SVM has > old CPUs that don't do it]) please". VM-exit instruction length is not defined for all VM-e

Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Alexander Graf
On 08.11.23 18:20, Sean Christopherson wrote: On Wed, Nov 08, 2023, Nicolas Saenz Julienne wrote: Save the length of the instruction that triggered an EPT violation in struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory intercept messages. This is silly and unnecessarily obf

Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Sean Christopherson
On Wed, Nov 08, 2023, Nicolas Saenz Julienne wrote: > Save the length of the instruction that triggered an EPT violation in > struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory > intercept messages. This is silly and unnecessarily obfuscates *why* (as my response regarding SVM

Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Alexander Graf
On 08.11.23 17:15, Sean Christopherson wrote: On Wed, Nov 08, 2023, Alexander Graf wrote: On 08.11.23 12:18, Nicolas Saenz Julienne wrote: Save the length of the instruction that triggered an EPT violation in struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory intercept mes

Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Sean Christopherson
On Wed, Nov 08, 2023, Alexander Graf wrote: > > On 08.11.23 12:18, Nicolas Saenz Julienne wrote: > > Save the length of the instruction that triggered an EPT violation in > > struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory > > intercept messages. > > > > Signed-off-by: Nico

Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Alexander Graf
On 08.11.23 12:18, Nicolas Saenz Julienne wrote: Save the length of the instruction that triggered an EPT violation in struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory intercept messages. Signed-off-by: Nicolas Saenz Julienne In v1, please do this for SVM as well :)

[RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Nicolas Saenz Julienne
Save the length of the instruction that triggered an EPT violation in struct kvm_vcpu_arch. This will be used to populate Hyper-V VSM memory intercept messages. Signed-off-by: Nicolas Saenz Julienne --- arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/kvm/vmx/vmx.c | 1 + 2 files change