Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-19 Thread Leonardo Bras
On Tue, Sep 19, 2023 at 03:53:22PM +0800, Guo Ren wrote: > On Tue, Sep 19, 2023 at 1:13 PM Leonardo Bras wrote: > > > > On Sun, Sep 17, 2023 at 10:34:36PM +0800, Guo Ren wrote: > > > On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > > > > > > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-19 Thread Guo Ren
On Tue, Sep 19, 2023 at 1:13 PM Leonardo Bras wrote: > > On Sun, Sep 17, 2023 at 10:34:36PM +0800, Guo Ren wrote: > > On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > > > > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo Ren wrote: > > > > On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras >

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-18 Thread Leonardo Bras
On Sun, Sep 17, 2023 at 10:34:36PM +0800, Guo Ren wrote: > On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo Ren wrote: > > > On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras wrote: > > > > > > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-17 Thread Guo Ren
On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo Ren wrote: > > On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras wrote: > > > > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > > From: Guo Ren > > > > > > > > Cache-bl

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Leonardo Bras
On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo Ren wrote: > On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras wrote: > > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > From: Guo Ren > > > > > > Cache-block prefetch instructions are HINTs to the hardware to > > > indicate

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Conor Dooley
On Fri, Sep 15, 2023 at 01:42:56PM +0100, Conor Dooley wrote: > > > > If this isn't being used in a similar manner, then the w has no reason > > > to be in the odd lowercase form. > > > > Other than to be consistent... However, the CBO_* instructions are not > > consistent with the rest of macros

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Leonardo Bras
On Fri, Sep 15, 2023 at 01:07:40PM +0200, Andrew Jones wrote: > On Fri, Sep 15, 2023 at 05:22:26AM -0300, Leonardo Bras wrote: > > On Thu, Sep 14, 2023 at 03:47:59PM +0200, Andrew Jones wrote: > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > > From: Guo Ren > ... > >

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Conor Dooley
On Fri, Sep 15, 2023 at 02:14:40PM +0200, Andrew Jones wrote: > On Fri, Sep 15, 2023 at 12:37:50PM +0100, Conor Dooley wrote: > > On Thu, Sep 14, 2023 at 04:47:18PM +0200, Andrew Jones wrote: > > > On Thu, Sep 14, 2023 at 04:25:53PM +0200, Andrew Jones wrote: > > > > On Sun, Sep 10, 2023 at 04:28:5

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Conor Dooley
> > If this isn't being used in a similar manner, then the w has no reason > > to be in the odd lowercase form. > > Other than to be consistent... However, the CBO_* instructions are not > consistent with the rest of macros. If we don't need lowercase for any > reason, then my preference would be

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Guo Ren
On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras wrote: > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > From: Guo Ren > > > > Cache-block prefetch instructions are HINTs to the hardware to > > indicate that software intends to perform a particular type of > > memory access

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Andrew Jones
On Fri, Sep 15, 2023 at 12:26:20PM +0100, Conor Dooley wrote: > On Fri, Sep 15, 2023 at 01:07:40PM +0200, Andrew Jones wrote: > > On Fri, Sep 15, 2023 at 05:22:26AM -0300, Leonardo Bras wrote: > > > On Thu, Sep 14, 2023 at 03:47:59PM +0200, Andrew Jones wrote: > > > > On Sun, Sep 10, 2023 at 04:28:

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Andrew Jones
On Fri, Sep 15, 2023 at 12:37:50PM +0100, Conor Dooley wrote: > Yo, > > On Thu, Sep 14, 2023 at 04:47:18PM +0200, Andrew Jones wrote: > > On Thu, Sep 14, 2023 at 04:25:53PM +0200, Andrew Jones wrote: > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > > From: Guo Ren >

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Conor Dooley
Yo, On Thu, Sep 14, 2023 at 04:47:18PM +0200, Andrew Jones wrote: > On Thu, Sep 14, 2023 at 04:25:53PM +0200, Andrew Jones wrote: > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > From: Guo Ren > > > > > > Cache-block prefetch instructions are HINTs to the hardware to

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Conor Dooley
On Fri, Sep 15, 2023 at 01:07:40PM +0200, Andrew Jones wrote: > On Fri, Sep 15, 2023 at 05:22:26AM -0300, Leonardo Bras wrote: > > On Thu, Sep 14, 2023 at 03:47:59PM +0200, Andrew Jones wrote: > > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > > From: Guo Ren > ... > >

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Andrew Jones
On Fri, Sep 15, 2023 at 05:22:26AM -0300, Leonardo Bras wrote: > On Thu, Sep 14, 2023 at 03:47:59PM +0200, Andrew Jones wrote: > > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > > From: Guo Ren ... > > > diff --git a/arch/riscv/include/asm/insn-def.h > > > b/arch/riscv/inc

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-15 Thread Leonardo Bras
On Thu, Sep 14, 2023 at 03:47:59PM +0200, Andrew Jones wrote: > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > From: Guo Ren > > > > Cache-block prefetch instructions are HINTs to the hardware to > > indicate that software intends to perform a particular type of > > memory

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-14 Thread Andrew Jones
On Thu, Sep 14, 2023 at 04:25:53PM +0200, Andrew Jones wrote: > On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > > From: Guo Ren > > > > Cache-block prefetch instructions are HINTs to the hardware to > > indicate that software intends to perform a particular type of > > memory

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-14 Thread Andrew Jones
On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > From: Guo Ren > > Cache-block prefetch instructions are HINTs to the hardware to > indicate that software intends to perform a particular type of > memory access in the near future. Enable ARCH_HAS_PREFETCHW and > improve the ar

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-14 Thread Andrew Jones
On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > From: Guo Ren > > Cache-block prefetch instructions are HINTs to the hardware to > indicate that software intends to perform a particular type of > memory access in the near future. Enable ARCH_HAS_PREFETCHW and > improve the ar

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-13 Thread Leonardo Bras
On Sun, Sep 10, 2023 at 04:28:57AM -0400, guo...@kernel.org wrote: > From: Guo Ren > > Cache-block prefetch instructions are HINTs to the hardware to > indicate that software intends to perform a particular type of > memory access in the near future. Enable ARCH_HAS_PREFETCHW and > improve the ar