Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

2017-10-19 Thread SF Markus Elfring
>>> Something like: >>> >>> "because there is a dump_stack() done on allocation failures >>> without __GFP_JNOWARN" >> >> How do you think about to convert such a description into a special format >> for further reference documentation? > > I think it's a bad idea if it's a "special" format. Wil

Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

2017-10-19 Thread Joe Perches
On Thu, 2017-10-19 at 13:35 +0200, SF Markus Elfring wrote: > > > > > Omit an extra message for a memory allocation failure in this > > > > > function. > > > > > > > > > > This issue was detected by using the Coccinelle software. [] > > > Do you see any need that I should extend subsequent commit

Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

2017-10-19 Thread SF Markus Elfring
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring >>> >>> Applied to modules-next, thanks. >> >> Thanks for your acceptance of this update suggestion after a bit o

Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

2017-10-19 Thread SF Markus Elfring
>> This is a small allocation so it can't fail in current kernels.  I can't >> imagine a situation where this could fail and it wasn't dead easy to >> debug.  Most modules are loaded at boot so it's not likely to fail, but >> if it did, it would be easy to reproduce.  If it's not loaded at boot >>