Re: [linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

2006-10-12 Thread Patrick Boettcher
On Tue, 10 Oct 2006, Mario Rossi wrote: > I've tried your repository a few minutes ago. > The card works (AGC) and te remote control as well (no NULL pointer > exception). > > What about this patch to remove unnecessary (and misleading) debug > output (it prints the values of the keys in the tabl

Re: [linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

2006-10-09 Thread Mario Rossi
I've tried your repository a few minutes ago. The card works (AGC) and te remote control as well (no NULL pointer exception). What about this patch to remove unnecessary (and misleading) debug output (it prints the values of the keys in the table up to the value of the key pressed)? diff -r 0e4b

Re: [linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

2006-10-08 Thread Patrick Boettcher
Hi Mario, sorry for the delay. On Sun, 8 Oct 2006, Mario Rossi wrote: > This patch fixes the NULL pointer exception while using the Remote > Control for a NOVA T USB2. > > Basically this line was missing (for the properties of the device > "dvb_usb_device_properties") > > .size_of_priv

[linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

2006-10-08 Thread Mario Rossi
This patch fixes the NULL pointer exception while using the Remote Control for a NOVA T USB2. Basically this line was missing (for the properties of the device "dvb_usb_device_properties") .size_of_priv = sizeof(struct dibusb_state), I'm not sure the fix is 100% correct since the same