I've been looking at the sa7146 page table code and it looks like the
saa7146_pgtable_free function is used incorrectly in the error cases:
from budget-core.c:
ttpci_budget_init()
{
...
budget->grabbing = saa7146_vmalloc_build_pgtable(dev->pci,
budget->buffer_size, &budget->pt))
...
err:
Jon Burgess wrote:
> I've been looking at the sa7146 page table code and it looks like the
> saa7146_pgtable_free function is used incorrectly in the error cases:
>
> >from budget-core.c:
> ttpci_budget_init()
> {
> ...
> budget->grabbing = saa7146_vmalloc_build_pgtable(dev->pci,
> budget->bu
You found the problem. Do you want to prepare and submit the patch?
Please don't forget the patch description and Signed-off-by line.
I just wanted to help. I hope this is ok.
Regards.
--- v4l-dvb/linux/drivers/media/dvb/ttpci/budget-core.c.orig 2007-04-22 04:53:50.0 -0700
+++ v4l-dvb
> You found the problem. Do you want to prepare and submit the patch?
> Please don't forget the patch description and Signed-off-by line.
I just wanted to help. I hope this is ok.
Are there any objections to checking these fixes into main?
Best Regards.
___
Are there any objections to checking these fixes into main?
I'm not trying to get credit for this contribution, which is why I did not
include a "signed off by". But, I would sure like to see it added if its
the right thing to do. Ok, Im going to shut up about it now. Maybe I
shouldn't ha
Stone wrote:
> > Are there any objections to checking these fixes into main?
>
> I'm not trying to get credit for this contribution, which is why I did not
> include a "signed off by". But, I would sure like to see it added if its
> the right thing to do. Ok, Im going to shut up about it now. M
On Tue, 2007-05-01 at 17:29 +0200, Oliver Endriss wrote:
> Stone wrote:
> > > Are there any objections to checking these fixes into main?
> >
> > I'm not trying to get credit for this contribution, which is why I did not
> > include a "signed off by". But, I would sure like to see it added if its
Jon Burgess wrote:
> Sorry for the delay. I wanted to track down the DMA sync bug before I
> came back to look at this again.
>
> I have added saa7146_vmalloc_destroy_pgtable() which frees the resources
Shouldn't it better be called saa7146_vfree_destroy_pgtable()?
On Wed, 2007-05-02 at 02:32 +0200, Oliver Endriss wrote:
> Jon Burgess wrote:
> > Sorry for the delay. I wanted to track down the DMA sync bug before I
> > came back to look at this again.
> >
> > I have added saa7146_vmalloc_destroy_pgtable() which frees the resources
>
> Shouldn't it better be
Jon Burgess wrote:
> On Wed, 2007-05-02 at 02:32 +0200, Oliver Endriss wrote:
> > Jon Burgess wrote:
> > > Sorry for the delay. I wanted to track down the DMA sync bug before I
> > > came back to look at this again.
> > >
> > > I have added saa7146_vmalloc_destroy_pgtable() which frees the resourc
10 matches
Mail list logo
