Re: [linux-dvb] never do symbol_put(tunerfoo_attach);

2007-11-16 Thread hermann pitton
Am Freitag, den 16.11.2007, 19:10 -0500 schrieb [EMAIL PROTECTED]: > Michel Ludwig wrote: > > On Fri 16 Nov 2007, you wrote: > > > >> We like to make linuxtv drivers modular and forward compatible. There > >> _are_ devices out there that use other tuners, and if you hardcode > >> xc3028 into th

Re: [linux-dvb] never do symbol_put(tunerfoo_attach);

2007-11-16 Thread mkrufky
Michel Ludwig wrote: > On Fri 16 Nov 2007, you wrote: > >> We like to make linuxtv drivers modular and forward compatible. There >> _are_ devices out there that use other tuners, and if you hardcode >> xc3028 into this driver, it prevents future developers from adding >> support for other devic

Re: [linux-dvb] never do symbol_put(tunerfoo_attach);

2007-11-16 Thread mkrufky
Mauro Carvalho Chehab wrote: > Em Sex, 2007-11-16 às 18:37 -0500, [EMAIL PROTECTED] escreveu: > >> Michel Ludwig wrote: >> >>> Hi Mike, >>> >>> On Fri 16 Nov 2007, [EMAIL PROTECTED] wrote: >>> >>> Mauro and Michel, This changeset is wrong: http://linuxtv.o

Re: [linux-dvb] never do symbol_put(tunerfoo_attach);

2007-11-16 Thread mkrufky
Michel Ludwig wrote: > Hi Mike, > > On Fri 16 Nov 2007, [EMAIL PROTECTED] wrote: > >> Mauro and Michel, >> >> This changeset is wrong: >> >> http://linuxtv.org/hg/~mchehab/tm6000/rev/79f9210425e2 >> >> You should not " symbol_put(xc3028_attach); " , because you don't always >> know that we're de

[linux-dvb] never do symbol_put(tunerfoo_attach);

2007-11-16 Thread mkrufky
Mauro and Michel, This changeset is wrong: http://linuxtv.org/hg/~mchehab/tm6000/rev/79f9210425e2 You should not " symbol_put(xc3028_attach); " , because you don't always know that we're dealing with that tuner. Instead, just do "dvb_frontend_detach(fe)" -- that will detach both tuner and fro