Re: [PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-18 Thread Roy Franz
On Wed, Sep 18, 2013 at 8:44 PM, Adam Borowski wrote: > On Mon, Sep 16, 2013 at 09:11:25PM -0700, Roy Franz wrote: >> +/* Convert the unicode UEFI command line to ASCII to pass to kernel. >> + * Size of memory allocated return in *cmd_line_len. >> + * Returns NULL on error. >> + */ >> +static char

Re: [PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-18 Thread H. Peter Anvin
On 09/18/2013 10:44 PM, Adam Borowski wrote: > > In fact, these days it's 8-bit encodings that are more likely to be Unicode > than 16-bit ones: UTF-8 is ubiquitous, while you usually get UCS2 at most. > In either case, though, we have here is a 7-bit charset encoded as either > 8-bit or 16-bit un

Re: [PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-18 Thread Adam Borowski
On Mon, Sep 16, 2013 at 09:11:25PM -0700, Roy Franz wrote: > +/* Convert the unicode UEFI command line to ASCII to pass to kernel. > + * Size of memory allocated return in *cmd_line_len. > + * Returns NULL on error. > + */ > +static char *efi_convert_cmdline_to_ascii(efi_system_table_t *sys_table_a

Re: [edk2] Corrupted EFI region

2013-09-18 Thread jerry . hoemann
On Mon, Sep 16, 2013 at 11:59:20AM +0100, Matt Fleming wrote: > On Fri, 13 Sep, at 02:38:12PM, jerry.hoem...@hp.com wrote: > > Matt, > > > > We have hit an issue on our new platform in development related to the > > call of efi_reserve_boot_services() from setup_arch(). > > > > The reservation ca

[PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-18 Thread Bart Kuivenhoven
The problem in efi_main was that the idt was cleared before the interrupts were disabled. The UEFI spec states that interrupts aren't used so this shouldn't be too much of a problem. Peripherals however don't necessarily know about this and thus might cause interrupts to happen anyway. Even if Exi

Re: [PATCH 08/17] Generalize relocate_kernel() for use by other architectures.

2013-09-18 Thread Roy Franz
On Wed, Sep 18, 2013 at 5:12 AM, Matt Fleming wrote: > On Mon, 16 Sep, at 09:11:24PM, Roy Franz wrote: >> Rename relocate_kernel() to efi_relocate_kernel(), and take >> parameters rather than x86 specific structure. Add max_addr >> argument as for ARM we have some address constraints that we >> n

Re: [PATCH V4 13/15] Hibernate: introduced SNAPSHOT_SIG_HASH config for select hash algorithm

2013-09-18 Thread Pavel Machek
On Sun 2013-09-15 08:56:59, Lee, Chun-Yi wrote: > This patch introduced SNAPSHOT_SIG_HASH config for user to select which > hash algorithm will be used during signature generation of snapshot. This series is big enough already... and who is going to test it? There's no need to make hash configurab

Re: [PATCH V4 00/17] ARM EFI stub common code

2013-09-18 Thread Matt Fleming
On Mon, 16 Sep, at 09:11:16PM, Roy Franz wrote: > This patch is the common/x86 portion of the ARM EFI stub > patchset broken out. These changes support the addition > of EFI stub support for the ARM and ARM64 architectures. > The common code that is now shared in efi-stub-helper.c > is based on co

Re: [PATCH 08/17] Generalize relocate_kernel() for use by other architectures.

2013-09-18 Thread Matt Fleming
On Mon, 16 Sep, at 09:11:24PM, Roy Franz wrote: > Rename relocate_kernel() to efi_relocate_kernel(), and take > parameters rather than x86 specific structure. Add max_addr > argument as for ARM we have some address constraints that we > need to enforce when relocating the kernel. Add alloc_size >

Re: [PATCH V4 02/15] asymmetric keys: implement EMSA_PKCS1-v1_5-ENCODE in rsa

2013-09-18 Thread joeyli
Hi Dmitry, First, thanks for your time to review my patches! 於 二,2013-09-17 於 16:51 -0500,Dmitry Kasatkin 提到: > Hello, > > > On Sat, Sep 14, 2013 at 7:56 PM, Lee, Chun-Yi wrote: > > Implement EMSA_PKCS1-v1_5-ENCODE [RFC3447 sec 9.2] in rsa.c. It's the > > first step of signature generation op