[PATCH] efi: Clean up the efi_call_phys_[prolog|epilog]() save/restore interaction

2015-03-02 Thread Ingo Molnar
Also clean up the save_pgd global variable while at it. untested as well. Thanks, Ingo ==> >From 166625ceaef68fcbeee63adc63c02d75abcaf0db Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Tue, 3 Mar 2015 07:42:48 +0100 Subject: [PATCH] efi: Clean up the efi_call_phys_[prolo

[PATCH] efi: Disable interrupts around EFI calls, not in the epilog/prolog calls

2015-03-02 Thread Ingo Molnar
* Tapasweni Pathak wrote: > Disabling interrupts around kmalloc() is less than ideal. Move it > after the kmalloc(). > > Found using Coccinelle. > > Signed-off-by: Tapasweni Pathak > Suggested-by: Matt Fleming > --- > arch/x86/platform/efi/efi_64.c |2 +- > 1 file changed, 1 insertion(+

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
> -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Monday, March 02, 2015 8:30 PM > > On Mon, 02 Mar, at 10:59:00AM, Kweh Hock Leong wrote: > > > -Original Message- > > > From: Borislav Petkov [mailto:b...@alien8.de] > > > Sent: Wednesday, February 25

[PATCH] arch: x86: platform: efi: Disabling interrupt around kmalloc

2015-03-02 Thread Tapasweni Pathak
Disabling interrupts around kmalloc() is less than ideal. Move it after the kmalloc(). Found using Coccinelle. Signed-off-by: Tapasweni Pathak Suggested-by: Matt Fleming --- arch/x86/platform/efi/efi_64.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/platform/

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Yinghai Lu
On Mon, Mar 2, 2015 at 12:25 PM, Borislav Petkov wrote: > unsigned char *choose_kernel_location(struct boot_params *params, > diff --git a/arch/x86/boot/compressed/vmlinux.lds.S > b/arch/x86/boot/compressed/vmlinux.lds.S > index 34d047c98284..26d62f4b27b9 100644 > --- a/arch/x86/boot/compressed

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 10:58:23AM -0800, Yinghai Lu wrote: > On Mon, Mar 2, 2015 at 6:53 AM, Borislav Petkov wrote: > > Well, it seems to work here but it still doesn't look reliable enough to > > me. And this addon_zo thing of arbitrary 256K is strange. > > Thanks for check that out. > > That

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Yinghai Lu
On Mon, Mar 2, 2015 at 6:53 AM, Borislav Petkov wrote: > Well, it seems to work here but it still doesn't look reliable enough to > me. And this addon_zo thing of arbitrary 256K is strange. Thanks for check that out. That is not arbitrary number. Need to make that bigger than _end - _rodata > o

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Borislav Petkov
On Mon, Mar 02, 2015 at 03:04:30AM -0800, Yinghai Lu wrote: > We can not assume that range is safe to use. > > Please check attach one that should fix the problem really. Well, it seems to work here but it still doesn't look reliable enough to me. And this addon_zo thing of arbitrary 256K is stra

Re: [GIT PULL] EFI urgent fixes

2015-03-02 Thread Matt Fleming
On Mon, 02 Mar, at 02:24:10PM, Ingo Molnar wrote: > > Pulled, thanks Matt! > > For future reference, plase leave out unreadable commit messages like > this: > > While adding support loading kernel and initrd above 4G to grub2 in > legacy mode, I was referring to efi_high_alloc(). That will

Re: [GIT PULL] EFI urgent fixes

2015-03-02 Thread Ingo Molnar
* Matt Fleming wrote: > Folks, please pull the following urgent changes. > > The following changes since commit 43a9f69692b232d1c64c913a27507eb14a1c47fd: > > Revert "efi/libstub: Call get_memory_map() to obtain map and desc sizes" > (2015-02-18 11:38:13 +) > > are available in the git

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Matt Fleming
On Sat, 28 Feb, at 06:17:32PM, Yinghai Lu wrote: > We should access variable with referrence instead of using physical > address as value. > > Cc: Matt Fleming > Cc: Borislav Petkov > Signed-off-by: Yinghai Lu > --- > arch/x86/kernel/setup.c | 8 +++- > 1 file changed, 7 insertions(+), 1 d

[GIT PULL] EFI urgent fixes

2015-03-02 Thread Matt Fleming
Folks, please pull the following urgent changes. The following changes since commit 43a9f69692b232d1c64c913a27507eb14a1c47fd: Revert "efi/libstub: Call get_memory_map() to obtain map and desc sizes" (2015-02-18 11:38:13 +) are available in the git repository at: git://git.kernel.org/pu

Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Matt Fleming
On Mon, 02 Mar, at 10:59:00AM, Kweh Hock Leong wrote: > > -Original Message- > > From: Borislav Petkov [mailto:b...@alien8.de] > > Sent: Wednesday, February 25, 2015 8:49 PM > > > > On Wed, Feb 25, 2015 at 12:38:20PM +, Kweh, Hock Leong wrote: > > > The reason we use this interface for

Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Matt Fleming
On Thu, 26 Feb, at 04:54:58PM, Borislav Petkov wrote: > On Thu, Feb 26, 2015 at 07:30:54AM -0800, Andy Lutomirski wrote: > > How can the error code be propagated? Would that echo command fail in > > case of error? > > Yeah, either that or we can put the error code in the sysfs file which > usersp

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Yinghai Lu
On Mon, Mar 2, 2015 at 12:56 AM, Borislav Petkov wrote: > On Sun, Mar 01, 2015 at 12:41:10PM -0800, Yinghai Lu wrote: >> Does not look safe yet... > > Why? We can not assume that range is safe to use. Please check attach one that should fix the problem really. Thanks Yinghai Subject: [PATCH] x

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, February 25, 2015 8:49 PM > > On Wed, Feb 25, 2015 at 12:38:20PM +, Kweh, Hock Leong wrote: > > The reason we use this interface for efi capsule is that efi capsule > > support multi binaries to be

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Jiri Kosina
On Sat, 28 Feb 2015, Yinghai Lu wrote: > We should access variable with referrence instead of using physical > address as value. > > Cc: Matt Fleming > Cc: Borislav Petkov > Signed-off-by: Yinghai Lu Acked-by: Jiri Kosina Thanks for fixing my brainfart. This is not fixing the probl

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-02 Thread Borislav Petkov
On Sun, Mar 01, 2015 at 12:41:10PM -0800, Yinghai Lu wrote: > Does not look safe yet... Why? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.or