Re: [RFC PATCH v4 11/28] x86: Add support to determine the E820 type of an address

2017-03-03 Thread Borislav Petkov
On Tue, Feb 28, 2017 at 04:34:39PM -0600, Tom Lendacky wrote: > Or if we want to guard against ACPI adding a type 0 in the future, I > could make the function return an int and then return -EINVAL if an e820 > entry isn't found. This might be the better option. Yap, think so too. I don't trust sp

the Mail Archive is now (again) subscribed to this list...

2017-03-03 Thread Laszlo Ersek
... and so linux-efi finally has a public archive again (because GMANE has been defunct for a while now): https://www.mail-archive.com/linux-efi@vger.kernel.org/ Whoever administers this list, please consider updating the info box at: http://vger.kernel.org/vger-lists.html#linux-efi --*--

Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

2017-03-03 Thread Andy Shevchenko
On Thu, 2017-03-02 at 13:11 -0600, Brijesh Singh wrote: > Hi Mark, > > On 03/02/2017 11:39 AM, Mark Rutland wrote: > > On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: > > > > > > +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ > > >   ccp-ops.o \ > > >   ccp-dev-v3.o \ > > >

Re: [PATCH v2 0/2] capsule pstore backend

2017-03-03 Thread Ard Biesheuvel
On 1 March 2017 at 17:59, Qiuxu Zhuo wrote: > *** BLURB HERE *** > FYI the UEFI spec is vague about the exact format of the per-GUID capsule configuration table entries, and so we have asked the USWG for clarification. In the mean time, I'd like to refrain from merging anything based on it, so un

Re: [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature

2017-03-03 Thread Borislav Petkov
On Thu, Mar 02, 2017 at 10:12:09AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Update the CPU features to include identifying and reporting on the > Secure Encrypted Virtualization (SEV) feature. SME is identified by > CPUID 0x801f, but requires BIOS support to enable it (set bit 23

Re: [PATCH v2 0/2] capsule pstore backend

2017-03-03 Thread Ard Biesheuvel
On 3 March 2017 at 17:23, Luck, Tony wrote: > On Fri, Mar 03, 2017 at 03:19:51PM +, Ard Biesheuvel wrote: >> On 1 March 2017 at 17:59, Qiuxu Zhuo wrote: >> > *** BLURB HERE *** >> > >> >> FYI the UEFI spec is vague about the exact format of the per-GUID >> capsule configuration table entries,

Re: [PATCH v2 0/2] capsule pstore backend

2017-03-03 Thread Luck, Tony
On Fri, Mar 03, 2017 at 03:19:51PM +, Ard Biesheuvel wrote: > On 1 March 2017 at 17:59, Qiuxu Zhuo wrote: > > *** BLURB HERE *** > > > > FYI the UEFI spec is vague about the exact format of the per-GUID > capsule configuration table entries, and so we have asked the USWG for > clarification.

Multiple Acer laptops hang on ACPI poweroff

2017-03-03 Thread Daniel Drake
Some particular Acer/Packard Bell machines hang during shutdown. The system completely hangs while doing bit operations for turning on SLP_EN bit in ACPI PM1A control address and Sleep Control Register. Thus the normal acpi_power_off path can never complete the shutdown process. We have found a wo

Re: [RFC PATCH v2 00/32] x86: Secure Encrypted Virtualization (AMD)

2017-03-03 Thread Bjorn Helgaas
On Thu, Mar 02, 2017 at 10:12:01AM -0500, Brijesh Singh wrote: > This RFC series provides support for AMD's new Secure Encrypted Virtualization > (SEV) feature. This RFC is build upon Secure Memory Encryption (SME) RFCv4 > [1]. What kernel version is this series based on? -- To unsubscribe from t

Re: [RFC PATCH v2 06/32] x86/pci: Use memremap when walking setup data

2017-03-03 Thread Bjorn Helgaas
On Thu, Mar 02, 2017 at 10:13:10AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > The use of ioremap will force the setup data to be mapped decrypted even > though setup data is encrypted. Switch to using memremap which will be > able to perform the proper mapping. How should callers deci

Re: [RFC PATCH v2 00/32] x86: Secure Encrypted Virtualization (AMD)

2017-03-03 Thread Borislav Petkov
On Fri, Mar 03, 2017 at 02:33:23PM -0600, Bjorn Helgaas wrote: > On Thu, Mar 02, 2017 at 10:12:01AM -0500, Brijesh Singh wrote: > > This RFC series provides support for AMD's new Secure Encrypted > > Virtualization > > (SEV) feature. This RFC is build upon Secure Memory Encryption (SME) RFCv4 > >

Re: [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature

2017-03-03 Thread Brijesh Singh
Hi Boris, On 03/03/2017 10:59 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:12:09AM -0500, Brijesh Singh wrote: From: Tom Lendacky Update the CPU features to include identifying and reporting on the Secure Encrypted Virtualization (SEV) feature. SME is identified by CPUID 0x801f,

Re: [RFC PATCH v2 06/32] x86/pci: Use memremap when walking setup data

2017-03-03 Thread Tom Lendacky
On 3/3/2017 2:42 PM, Bjorn Helgaas wrote: On Thu, Mar 02, 2017 at 10:13:10AM -0500, Brijesh Singh wrote: From: Tom Lendacky The use of ioremap will force the setup data to be mapped decrypted even though setup data is encrypted. Switch to using memremap which will be able to perform the prope

Re: [RFC PATCH v2 00/32] x86: Secure Encrypted Virtualization (AMD)

2017-03-03 Thread Brijesh Singh
Hi Bjorn, On 03/03/2017 02:33 PM, Bjorn Helgaas wrote: On Thu, Mar 02, 2017 at 10:12:01AM -0500, Brijesh Singh wrote: This RFC series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. This RFC is build upon Secure Memory Encryption (SME) RFCv4 [1]. What kernel vers

RE: [PATCH v2 0/2] capsule pstore backend

2017-03-03 Thread Zhuo, Qiuxu
Hi Ard, There is some information in UEFI 2.4 spec section 7.5.3 p258: "The EFI System Table entry must use the GUID from the CapsuleGuid field of the EFI_CAPSULE_HEADER. The EFI System Table entry must point to an array of capsules that contain the same CapsuleGuid value. The array must

RE: [PATCH v2 1/2] efi/capsule: Add 'capsule' lookup support

2017-03-03 Thread Zhuo, Qiuxu
Hi Ard, The capsule configuration table entry memory layout here looks like: For capsule guid xxx: | (u32) capsule number a | (u64) 1st capsule physical addr | (u64) 2nd capsule physical addr | ... | (u64) a-st capsule physical addr | So if I do "capsule += sizeof(*uint32_