Re: [RFC PATCH] x86/efi: remove pointless call to PciIo->Attributes()

2018-06-26 Thread Hans de Goede
Hi, On 24-06-18 19:29, Ard Biesheuvel wrote: When it was first introduced, the EFI stub code that copies the contents of PCI option ROMs originally only intended to do so if the EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM attribute was *not* set. The reason was that the UEFI spec permits PCI option ROM i

Re: [RFC PATCH] x86/efi: remove pointless call to PciIo->Attributes()

2018-06-26 Thread Ard Biesheuvel
On 26 June 2018 at 14:23, Hans de Goede wrote: > Hi, > > > On 24-06-18 19:29, Ard Biesheuvel wrote: >> >> When it was first introduced, the EFI stub code that copies the >> contents of PCI option ROMs originally only intended to do so if >> the EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM attribute was *not*

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

2018-06-26 Thread Ingo Molnar
* Nick Desaulniers wrote: > On Thu, Jun 21, 2018 at 7:24 PM Ingo Molnar wrote: > > * Nick Desaulniers wrote: > > > > > native_save_fl() is marked static inline, but by using it as > > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > > > > > --- a/arch/x86/include/asm

RE: [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Prakhya, Sai Praneeth
> > Hi Sai, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.18-rc2 next-20180625] [if your patch is applied > to > the wrong git tree, please drop us a note to help improve the system] Since efi_memmap_free() is

Re: [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Ard Biesheuvel
On 26 June 2018 at 04:41, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > efi_memmap_install(), unmaps the existing memory map and installs the > new memory map but doesn't free the memory allocated to the existing > memory map. Fortunately, the details about the existing memory map are > st

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

2018-06-26 Thread Nick Desaulniers
On Tue, Jun 26, 2018 at 3:13 AM Ingo Molnar wrote: > Ok! > > Acked-by: Ingo Molnar > > What's the planned upstreaming route for these patches/fixes? While the fix is mainly for paravirt, 2/3 of the patches exclusively touch arch/x86, so I think they should go up in the x86 tree (as opposed to pa

RE: [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Prakhya, Sai Praneeth
> > + /* Free the memory allocated to the existing memory map */ > > + efi_memmap_free(efi.memmap.phys_map, efi.memmap.nr_map, > > + efi.memmap.late); > > + > > data.phys_map = addr; > > data.size = efi.memmap.desc_size * nr_map; > > data.desc_version = efi.memma

Re: [kbuild-all] [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Ye Xiaolong
Hi, On 06/26, Prakhya, Sai Praneeth wrote: >> >> Hi Sai, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on linus/master] >> [also build test ERROR on v4.18-rc2 next-20180625] [if your patch is applied >> to >> the wrong git tree, please drop us a note to

Re: [kbuild-all] [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Ard Biesheuvel
On 27 June 2018 at 08:02, Ye Xiaolong wrote: > Hi, > > On 06/26, Prakhya, Sai Praneeth wrote: >>> >>> Hi Sai, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on linus/master] >>> [also build test ERROR on v4.18-rc2 next-20180625] [if your patch is >>> app

RE: [kbuild-all] [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Prakhya, Sai Praneeth
> >Since efi_memmap_free() is a recently introduced API [1], please note > >that the patch is based on efi tree > >@https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git > > I noticed the official efi tree recored in MAINTAINERS is > git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi

Re: [kbuild-all] [PATCH] efi: Free existing memory map before installing new memory map

2018-06-26 Thread Ye Xiaolong
On 06/27, Ard Biesheuvel wrote: >On 27 June 2018 at 08:02, Ye Xiaolong wrote: >> Hi, >> >> On 06/26, Prakhya, Sai Praneeth wrote: Hi Sai, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc

RE: [PATCH 1/1] resource: Fixed iomem resource release failed on release_mem_region_adjustable() when memory node or cpu node hot-remove.

2018-06-26 Thread Guomin Chen
Hi Toshi Thank you for your reply and suggestions. I will continue to follow and investigation this issue. thanks Thanks and regards > -Original Message- > From: Kani, Toshi [mailto:toshi.k...@hpe.com] > Sent: 2018年6月26日 7:56 > To: Guomin Chen ; helg...@kernel.org > Cc: