Re: Please revert 7212e37cbdf9 from 4.4-stable

2019-03-11 Thread Sasha Levin
On Mon, Mar 11, 2019 at 01:48:14PM +, Hedi Berriche wrote: Hi Greg, Could you please revert 7212e37cbdf9 x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls from 4.4-stable? In 4.4-stable efi_runtime_lock as defined in drivers/firmware/efi/runtime-wrappers.c is a spinl

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-11 Thread Matthew Garrett
On Mon, Mar 11, 2019 at 9:55 AM Mimi Zohar wrote: > > On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > > Hm. And this only happens on certain firmware versions? If something's > > stepping on boot_params then we have bigger problems. > > I was seeing this problem before and after updati

Re: [PATCH 3/3] x86/ima: retry detecting secure boot mode

2019-03-11 Thread Mimi Zohar
On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > On Fri, Mar 8, 2019 at 5:40 AM Mimi Zohar wrote: > > > > On Thu, 2019-03-07 at 14:50 -0800, Matthew Garrett wrote: > > > Is the issue that it gives incorrect results on the first read, or is > > > the issue that it gives incorrect results

Please revert 7212e37cbdf9 from 4.4-stable

2019-03-11 Thread Hedi Berriche
Hi Greg, Could you please revert 7212e37cbdf9 x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls from 4.4-stable? In 4.4-stable efi_runtime_lock as defined in drivers/firmware/efi/runtime-wrappers.c is a spinlock (given it predates commit dce48e351c0d) and commit