Re: [PATCH v1 1/4] x86/cpu: Introduce INTEL_CPU_FAM*_NODATA() helper macros

2018-08-31 Thread Andi Kleen
Andy Shevchenko writes: > + > +#define INTEL_CPU_FAM_ANY_NODATA(_family, _model)\ > + INTEL_CPU_FAM_ANY(_family, _model, NULL) > + > +#define INTEL_CPU_FAM6_NODATA(_model)\ > + INTEL_CPU_FAM_ANY_NODATA(6, INTEL_FAM6_##_model) _NODATA is actually

Re: [PATCH] x86/mm: Simplify p[g4um]d_page() macros

2018-08-20 Thread Andi Kleen
On Mon, Aug 20, 2018 at 02:57:39PM -0700, Linus Torvalds wrote: > On Mon, Aug 20, 2018 at 1:37 PM Andi Kleen wrote: > > > > From: Andi Kleen > > > > Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then > > use the p[g4um]d_pfn() macros in the

[PATCH] x86/mm: Simplify p[g4um]d_page() macros

2018-08-20 Thread Andi Kleen
From: Andi Kleen Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead of duplicating the code. Signed-off-by: Tom Lendacky Reviewed-by: Thomas Gleixner Reviewed-by: Borislav Petkov Cc: Alexander Potapenko

Re: [PATCH 1/2] fs/efivarfs: restrict inode permissions

2018-02-21 Thread Andi Kleen
> But it should be fairly easy to just add a 'struct ratelimit_state' to > 'struct user_struct', and then you can easily just use > >'&file->f_cred->user->ratelimit' > > and you're done. Make sure the initial root user has it unlimited, and > limit it to something reasonable for all other use

Re: [PATCH 0/2] efivars: reading variables can generate SMIs

2018-02-17 Thread Andi Kleen
> Would rate limiting (but not only for non-root) help mitigate Spectre > v1 issues in UEFI runtime services code as well? I have been looking > into unmapping the entire kernel while such calls are in progress, > because firmware is likely to remain vulnerable long after the OSes > have been fixed

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Andi Kleen
> > I'm a little uneasy having this run by default if enabled, even if it's > > disabled by default in the config. > > What would be the canonical way to enable this feature then? Have a file White list systems and a option to force enable. -Andi -- To unsubscribe from this list: send the line

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Andi Kleen
> But, as Eric said, it should be OK if it is implemented in the kdump kenel. kdump doesn't work for a lot of use cases (too much memory consumption) -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Andi Kleen
> + It should be noted that enabling this opton will pass a capsule > + to the firmware on every boot. Some firmware will not allow a > + user to enter the BIOS setup when a capsule has been registered > + on the previous boot. That sounds like a problem. Can this be fixed