Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

reference requiring a GOT. Sounds like the best way forward, as well as having more info on which config/toolchain reliably reproduces the issue. -- Thanks, ~Nick Desaulniers

Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

On Wed, Jun 5, 2019 at 10:27 AM Nick Desaulniers wrote: > > On Wed, Jun 5, 2019 at 9:26 AM Greg KH wrote: > > > > On Wed, Jun 05, 2019 at 05:19:40PM +0200, Rolf Eike Beer wrote: > > > I decided to dig out a toy project which uses a DragonBoard 410c. This has > >

Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

greg k-h Doesn't immediately ring any bells for me. +mka@ who helped test 91ee5b21ee026c49e4e7483de69b55b8b47042be. Nothing in that series (https://lore.kernel.org/lkml/20170818194947.19347-5-ard.biesheu...@linaro.org/T/#u) is immediately obvious. Rolf, can you please email me your config so I can see if I can reproduce? Also, which version of GCC are you using, and binutils? (would be good to know if you hit this in mainline too, as if not maybe there's an existing fix to be backported to stable). -- Thanks, ~Nick Desaulniers

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

On Tue, Nov 6, 2018 at 6:16 AM Ard Biesheuvel wrote: > > On 6 November 2018 at 14:15, Sedat Dilek wrote: > > > > Thanks Ard. > > This means efi-for-4.21 / efi-for-5.0? > > > > Yes Thanks for picking up this patch, Ard. Is there any way to get it into 4.20? -- Thanks, ~Nick Desaulniers

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

On Mon, Oct 15, 2018 at 12:46 PM Nathan Chancellor wrote: > > On Mon, Oct 15, 2018 at 12:40:36PM -0700, Nick Desaulniers wrote: > > On Fri, Oct 12, 2018 at 6:06 PM Nathan Chancellor > > wrote: > > > > > > When building the kernel with Clang, some disable

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

thanks for this patch. Should this be: $(call cc-disable-warning, pointer-sign) as well? > + $(call cc-disable-warning, > address-of-packed-member) \ > + $(call cc-disable-warning, gnu) > > # arm64 uses the full KBUILD_CFLAGS so it's necessary to explicitly > # disable the stackleak plugin > -- > 2.19.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern inline

On Fri, Aug 24, 2018 at 4:08 PM Ben Hutchings wrote: > > On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > Fr

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

On Fri, Jul 13, 2018 at 3:15 AM David Laight wrote: > > From: Nick Desaulniers > > Sent: 21 June 2018 17:23 > > > > native_save_fl() is marked static inline, but by using it as > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > >

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

or merging series that may be touch more than one subsystem. I assume we don't split up series to take parts in one tree vs another?) -- Thanks, ~Nick Desaulniers -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majo

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

On Thu, Jun 21, 2018 at 7:24 PM Ingo Molnar wrote: > * Nick Desaulniers wrote: > > > native_save_fl() is marked static inline, but by using it as > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > > > --- a/arch/x86/include/asm/irqflags.h >

[PATCH v6 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

H. Peter Anvin Signed-off-by: Nick Desaulniers --- arch/x86/include/asm/asm.h | 59 ++ 1 file changed, 59 insertions(+) diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h index 219faaec51df..990770f9e76b 100644 --- a/arch/x86/include/asm/a

[PATCH v6 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

Gross Signed-off-by: Nick Desaulniers Suggested-by: Arnd Bergmann Suggested-by: H. Peter Anvin Suggested-by: Joe Perches --- include/linux/compiler-gcc.h | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include

[PATCH v6 0/3] extern inline native_save_fl for paravirt

uld instead carefully evaluate if those Makefiles should be overwriting KBUILD_CFLAGS at all. Dropped the previous first two patches and added a new first patch. *** BLURB HERE *** H. Peter Anvin (1): x86/asm: add _ASM_ARG* constants for argument registers to Nick Desaulniers (2): co

[PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Acked-by: Juergen Gross Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nic

Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

On Thu, Jun 14, 2018 at 5:17 PM H. Peter Anvin wrote: > > On 06/14/18 13:59, Nick Desaulniers wrote: > > On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin wrote: > >> > >> On 06/13/18 14:05, Nick Desaulniers wrote: > >>> From: "H. Peter Anvin"

Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin wrote: > > On 06/13/18 14:05, Nick Desaulniers wrote: > > From: "H. Peter Anvin" > > > > i386 and x86-64 uses different registers for arguments; make them > > available so we don't have to #ifdef in the a

[PATCH v5 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

: Nick Desaulniers Suggested-by: Arnd Bergmann Suggested-by: H. Peter Anvin Suggested-by: Joe Perches --- include/linux/compiler-gcc.h | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index

[PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

From: "H. Peter Anvin" i386 and x86-64 uses different registers for arguments; make them available so we don't have to #ifdef in the actual code. Native size and specified size (q, l, w, b) versions are provided. Suggested-by: Sedat Dilek Signed-off-by: H. Peter Anvin Sign

[PATCH v5 3/3] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nick Desaulniers Sugge

[PATCH v5 0/3] extern inline native_save_fl for paravirt

and added a new first patch. H. Peter Anvin (1): x86/asm: add _ASM_ARG* constants for argument registers to Nick Desaulniers (2): compiler-gcc.h: add gnu_inline to all inline declarations x86: paravirt: make native_save_fl extern inline arch/x86/include/asm/asm.h | 59 +

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

On Tue, Jun 12, 2018 at 2:31 PM H. Peter Anvin wrote: > > On 06/12/18 13:19, Nick Desaulniers wrote: > > > > Oh, by [0] __GCC_STDC_INLINE__ is indeed actually the correct symbol > > to check for. Clang does support that, so nothing to fix there. > > > >

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

-ID: <191e4ebe-4cb2-4c8b-ab61-689a91ffe...@zytor.com> > > On June 12, 2018 11:33:14 AM PDT, Nick Desaulniers > wrote: > >On Fri, Jun 8, 2018 at 3:04 AM Sedat Dilek > >wrote: > >> > >> On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: &

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

On Fri, Jun 8, 2018 at 3:04 AM Sedat Dilek wrote: > > On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: > > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers > > wrote: > >> Functions marked extern inline do not emit an externally visible > >> function whe

[PATCH v4 0/3] extern inline native_save_fl for paravirt

flag in problematic Makefiles. We should instead carefully evaluate if those Makefiles should be overwriting KBUILD_CFLAGS at all. Dropped the previous first two patches and added a new first patch. H. Peter Anvin (1): x86/asm: add _ASM_ARG* constants for argument registers to Nick Desauln

[PATCH v4 3/3] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nick Desaulniers Sugge

[PATCH v4 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

From: "H. Peter Anvin" i386 and x86-64 uses different registers for arguments; make them available so we don't have to #ifdef in the actual code. Native size and specified size (q, l, w, b) versions are provided. Suggested-by: Sedat Dilek Signed-off-by: H. Peter Anvin Sign

[PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

: Nick Desaulniers Suggested-by: H. Peter Anvin Suggested-by: Joe Perches --- include/linux/compiler-gcc.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index b4bf73f5e38f..0c79c588e572 100644 --- a

Re: [PATCH v3 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

On Thu, Jun 7, 2018 at 1:14 PM H. Peter Anvin wrote: > > On 06/07/18 11:32, Nick Desaulniers wrote: > > > > Suggested-by: Sedat Dilek > > If this was suggested by Sedat, I didn't see that suggestion... I took his suggestion which was to fix the typo in the commit m

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Thu, Jun 7, 2018 at 11:31 AM Joe Perches wrote: > > On Thu, 2018-06-07 at 10:26 -0700, Nick Desaulniers wrote: > > I get the feeling that the use of __inline__ or __inline (vs inline) > > in the kernel may be wrong and their use should be eradicated in the > > follow up

Re: [PATCH v3 3/3] x86: paravirt: make native_save_fl extern inline

On Thu, Jun 7, 2018 at 11:32 AM Nick Desaulniers wrote: > > native_save_fl() is marked static inline, but by using it as > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > > paravirt's use of native_save_fl() also requires that no GPRs other than

[PATCH v3 3/3] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nick Desaulniers Sugge

[PATCH v3 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

: Nick Desaulniers Suggested-by: H. Peter Anvin Suggested-by: Joe Perches --- include/linux/compiler-gcc.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index b4bf73f5e38f..3365f20dba5a 100644 --- a

[PATCH v3 2/3] x86/asm: add _ASM_ARG* constants for argument registers to

From: "H. Peter Anvin" i386 and x86-64 uses different registers for arguments; make them available so we don't have to #ifdef in the actual code. Native size and specified size (q, l, w, b) versions are provided. Suggested-by: Sedat Dilek Signed-off-by: H. Peter Anvin Sign

[PATCH v3 0/3] extern inline native_save_fl for paravirt

vious first two patches and added a new first patch. H. Peter Anvin (1): x86/asm: add _ASM_ARG* constants for argument registers to Nick Desaulniers (2): compiler-gcc.h: add gnu_inline to all inline declarations x86: paravirt: make native_save_fl extern inline arch/x86/include/asm/

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Tue, Jun 5, 2018 at 10:23 AM Joe Perches wrote: > > On Tue, 2018-06-05 at 10:05 -0700, Nick Desaulniers wrote: > And only set once along with: > > > #define __always_inline inline __attribute__((always_inline)) > > And perhaps this __always_inline should be upda

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Thu, Jun 7, 2018 at 10:26 AM Nick Desaulniers wrote: > > On Tue, Jun 5, 2018 at 10:23 AM Joe Perches wrote: > > > > On Tue, 2018-06-05 at 10:05 -0700, Nick Desaulniers wrote: > > > Functions marked extern inline do not emit an externally visible > > > f

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Tue, Jun 5, 2018 at 10:23 AM Joe Perches wrote: > > On Tue, 2018-06-05 at 10:05 -0700, Nick Desaulniers wrote: > > Functions marked extern inline do not emit an externally visible > > function when the gnu89 C standard is used. Some KBUILD Makefiles > > overwrite K

Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

On Tue, Jun 5, 2018 at 2:31 PM Arnd Bergmann wrote: > > On Tue, Jun 5, 2018 at 11:28 PM, Arnd Bergmann wrote: > > On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers > > wrote: > >> > >> The semantics of extern inline has changed since gnu89. This means that

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

ude/sta_info.h| 2 +- > drivers/staging/rtl8723bs/include/wifi.h| 14 +++--- > drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- > lib/zstd/mem.h | 2 +- > 13 files changed, 47 insertions(+), 47

Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

On Tue, Jun 5, 2018 at 10:23 AM Joe Perches wrote: > On Tue, 2018-06-05 at 10:05 -0700, Nick Desaulniers wrote: > > #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \ > > !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4) > >

Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

On 06/05/18 10:28, H. Peter Anvin wrote: > On 06/05/18 10:05, Nick Desaulniers wrote: >> + >> +/* >> + * void native_restore_fl(unsigned long flags) >> + * %rdi: flags >> + */ >> +ENTRY(native_restore_fl) >> +push %_ASM_DI >>

[PATCH v2 0/2] extern inline native_save_fl for paravirt

first two patches and added a new first patch. Nick Desaulniers (2): compiler-gcc.h: add gnu_inline to all inline declarations x86: paravirt: make native_save_fl extern inline arch/x86/include/asm/irqflags.h | 2 +- arch/x86/kernel/Makefile| 1 + arch/x86/kernel/irqflags.S | 26

[PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

: Nick Desaulniers Suggested-by: H. Peter Anvin Tested-by: Sedat Dilek --- include/linux/compiler-gcc.h | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index b4bf73f5e38f..7827bdf0e5e9 100644 --- a

[PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nick Desaulniers Suggested

[PATCH 3/3] x86: paravirt: make native_save_fl extern inline

nux/issues/16 Discussion: https://bugs.llvm.org/show_bug.cgi?id=37512 https://lkml.org/lkml/2018/5/24/1371 Thanks to the many folks that participated in the discussion. Debugged-by: Alistair Strachan Debugged-by: Matthias Kaehlcke Reported-by: Sedat Dilek Signed-off-by: Nick Desaulniers Suggested

[PATCH 1/3] efi: use -std=gnu89 for proper extern inline semantics

-off-by: Nick Desaulniers Suggested-by: Sedat Dilek Tested-by: Sedat Dilek --- drivers/firmware/efi/libstub/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile index a34e9290a699..97ca53ab2b69

[PATCH 2/3] x86/build: use -std=gnu89 for proper extern inline semantics

-off-by: Nick Desaulniers Tested-by: Sedat Dilek --- arch/x86/boot/compressed/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile index fa42f895fdde..1a04c7e9add1 100644 --- a/arch/x86/boot/compressed

[PATCH 0/3] extern inline native_save_fl for paravirt

://blahg.josefsipek.net/?p=529 Nick Desaulniers (3): efi: use -std=gnu89 for proper extern inline semantics x86/build: use -std=gnu89 for proper extern inline semantics x86: paravirt: make native_save_fl extern inline arch/x86/boot/compressed/Makefile | 2 +- arch/x86/include/asm