Re: Regression from efi: call get_event_log before ExitBootServices

On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 13 March 2018 at 07:47, Hans de Goede <hdego...@redhat.com> wrote: > > Hi, > > > > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: > >> > ... > >> >

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 10:03 PM Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 12 March 2018 at 19:55, Thiebaud Weksteen <tw...@google.com> wrote: > > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline <jer...@jcline.org> wrote: > > > >> On 03

Re: Regression from efi: call get_event_log before ExitBootServices

On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline <jer...@jcline.org> wrote: > On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> > > wrote: > > > >> On 12 March 2018 at 17:

Re: Regression from efi: call get_event_log before ExitBootServices

rg> wrote: > >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > >>>> On 10 March 2018 at 10:45, Thiebaud Weksteen <tw...@google.com> wrote: > >>>>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline <jer...@jcline.org> wrote: > >>

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline <jer...@jcline.org> wrote: > On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > > Thanks a lot for trying out the patch! > > > > Please don't modify your install at this stage, I think we are hitting a >

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index 773afcd6a37c..ee3fac109078 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

On Fri, Mar 9, 2018 at 10:29 AM Hans de Goede wrote: > Hi, > On 08-03-18 18:26, Jeremy Cline wrote: > > On 03/08/2018 11:50 AM, Hans de Goede wrote: > >> >> added these now> > >> > >> Hi, > >> > >> On 07-03-18 12:34, Javier Martinez Canillas wrote: > > > > > > > >>> Are

Re: Regression from efi: call get_event_log before ExitBootServices

--- drivers/firmware/efi/libstub/tpm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/firmware/efi/libstub/tpm.c b/drivers/firmware/efi/libstub/tpm.c index da661bf8cb96..773afcd6a37c 100644 --- a/drivers/firmware/efi/libstub/tpm.c +++

Re: Regression from efi: call get_event_log before ExitBootServices

On Wed, Mar 7, 2018 at 6:33 PM Jeremy Cline <jer...@jcline.org> wrote: > On 03/07/2018 03:41 AM, Thiebaud Weksteen wrote: > > Hi, > > > > Thanks for testing and sending this report! This patch relies heavily on > > the functions exposed by the firmware.

Re: Regression from efi: call get_event_log before ExitBootServices

Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information on this specific device? Do you have any link to

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

On Mon, Mar 5, 2018 at 4:40 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi Thiebaud > On Wed, Sep 20, 2017 at 10:13 AM, Thiebaud Weksteen <tw...@google.com> wrote: > > With TPM 2.0 specification, the event logs may only be accessible by > > calli

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

On Mon, Oct 16, 2017 at 1:49 PM, Jarkko Sakkinen wrote: > On Mon, Oct 16, 2017 at 02:28:33PM +0300, Jarkko Sakkinen wrote: >> On Wed, Oct 11, 2017 at 02:52:54PM +0300, Jarkko Sakkinen wrote: >> > On Wed, Oct 11, 2017 at 12:54:26PM +1100, James Morris wrote: >> > >

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

On Wed, Oct 4, 2017 at 12:51 PM, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Fri, Sep 29, 2017 at 08:16:17PM +0300, Jarkko Sakkinen wrote: >> On Tue, Sep 26, 2017 at 02:49:31PM +0200, Thiebaud Weksteen wrote: >> > On Tue, Sep 26, 2017 at

[PATCH v3 2/5] tpm: rename event log provider files

Rename the current TPM Event Log provider files (ACPI and OF) for clarity. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/Makefile| 4 ++-- drivers/char/tpm/{tpm_acpi.c => tpm_eventlog_acpi.c} | 0 drivers/char/tpm/

[PATCH v3 4/5] efi: call get_event_log before ExitBootServices

of the logs: TPM 1.2 (SHA1) or TPM 2.0 ("Crypto Agile"). For now, only the first format is retrieved. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- arch/x86/boot/compressed/eboot.c | 1 + drivers/firmware/efi/Makefile | 2 +- drivers/firmware/efi/efi.c

[PATCH v3 3/5] tpm: add event log format version

Although defined as part of the TCG EFI specification, we add these definitions here so that any event log provider may reference them. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- include/linux/tpm_eventlog.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include

[PATCH v3 5/5] tpm: parse TPM event logs based on EFI table

If we are not able to retrieve the TPM event logs from the ACPI table, check the EFI configuration table (Linux-specific GUID). The format version of the log is now returned by the provider function. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/Ma

[PATCH v3 1/5] tpm: move tpm_eventlog.h outside of drivers folder

The generic definitions of data structures in tpm_eventlog.h are required by other part of the kernel (namely, the EFI stub). Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/tpm-chip.c| 3 +- drivers/char/tpm/tpm-inter

[PATCH v3 0/5] Call GetEventLog before ExitBootServices

Fix kbuild failures Version 2: - Move tpm_eventlog.h to top include directory, add commit for this. - Use EFI_LOADER_DATA to store the configuration table - Whitespace and new lines fixes Thiebaud Weksteen (5): tpm: move tpm_eventlog.h outside of drivers folder tpm: rename event log provider fi

Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

On Tue, Sep 12, 2017 at 10:48 AM, Thiebaud Weksteen <tw...@google.com> wrote: > On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote: >> On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote: >> >> > chip->bin_log_seqops.chip

Re: [PATCH v2 2/3] efi: call get_event_log before ExitBootServices

; On Mon, Sep 11, 2017 at 12:00:21PM +0200, Thiebaud Weksteen wrote: >> >> With TPM 2.0 specification, the event logs may only be accessible by >> >> calling an EFI Boot Service. Modify the EFI stub to copy the log area to >> >> a new Linux-specific EFI configur

Re: [tpmdd-devel] [PATCH v2 2/3] efi: call get_event_log before ExitBootServices

On Thu, Sep 14, 2017 at 12:24 PM, Javier Martinez Canillas <javi...@redhat.com> wrote: > On 09/11/2017 12:00 PM, Thiebaud Weksteen via tpmdd-devel wrote: >> With TPM 2.0 specification, the event logs may only be accessible by >> calling an EFI Boot Service. Modify the EFI stub

Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Thiebaud-Weksteen/Call-GetEventLog-before-ExitBootServices/20170913-221312 > base: https://git.kernel.org/pub/scm/linux/ker

Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

On Mon, Sep 11, 2017 at 10:47:50AM -0600, Jason Gunthorpe wrote: > On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote: > > > chip->bin_log_seqops.chip = chip; > > - if (chip->flags & TPM_CHIP_FLAG_TPM2) > > + > > + if (log_ve

[PATCH v2 1/3] tpm: move tpm_eventlog.h outside of drivers folder

The generic definitions of data structures in tpm_eventlog.h are required by other part of the kernel (namely, the EFI stub). Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/tpm-chip.c| 3 +- drivers/char/tpm/tpm-inter

[PATCH v2 2/3] efi: call get_event_log before ExitBootServices

of the logs: TPM 1.2 (SHA1) or TPM 2.0 ("Crypto Agile"). For now, only the first format is retrieved. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- arch/x86/boot/compressed/eboot.c | 1 + drivers/firmware/efi/Makefile | 2 +- drivers/firmware/efi/efi.c

[PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

(previous behaviour). Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/Makefile| 2 +- drivers/char/tpm/tpm.h | 8 + drivers/char/tpm/tpm1_eventlog.c | 15 +++-- drivers/char/tpm/tpm_efi.c

[PATCH v2 0/3] Call GetEventLog before ExitBootServices

for TPM 1.2 devices). --- Patchset Changelog: Version 2: - Move tpm_eventlog.h to top include directory, add commit for this. - Use EFI_LOADER_DATA to store the configuration table - Whitespace and new lines fixes Thiebaud Wekst

[PATCH 2/2] tpm: surface TPM event log based on EFI table

Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- drivers/char/tpm/Makefile| 2 +- drivers/char/tpm/tpm.h | 8 + drivers/char/tpm/tpm1_eventlog.c | 16 +++--- drivers/char/tpm/tpm_efi.c | 66 drivers/ch

[PATCH 1/2] efi: call get_event_log before ExitBootServices

With TPM 2.0, access to the event log is only possible by using the EFI TPM2 Boot Service. Modify the EFI stub to copy the log area to a new Linux-specific EFI table so it remains accessible for future use. Signed-off-by: Thiebaud Weksteen <tw...@google.com> --- arch/x86/boot/compressed/e