Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-31 Thread Greg Kroah-Hartman
On Fri, Aug 31, 2018 at 07:24:08AM +0100, Guillaume Tucker wrote: > On 24/08/18 21:32, Guenter Roeck wrote: > > On Fri, Aug 24, 2018 at 01:16:18PM -0700, Roland Dreier wrote: > >>> Sounds great. I'll hold off with sending my RFT series and wait for your > >>> test results. I think we'll also need

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-31 Thread Guillaume Tucker
On 24/08/18 21:32, Guenter Roeck wrote: > On Fri, Aug 24, 2018 at 01:16:18PM -0700, Roland Dreier wrote: >>> Sounds great. I'll hold off with sending my RFT series and wait for your >>> test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix >>> boot crash when 1GB pages are not

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-29 Thread Roland Dreier
> > Perhaps just the patch that Andi posted to the stable list helps out > > here? > > > > For reference: > > https://www.spinics.net/lists/stable/msg253357.html > > That would be the most straightforward and simple fix, so I would prefer > to go with it if it works. Sorry for being slow, it

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-25 Thread Guenter Roeck
On 08/25/2018 08:07 AM, Greg Kroah-Hartman wrote: On Sat, Aug 25, 2018 at 06:52:32AM -0700, Guenter Roeck wrote: Hi Roland, On 08/24/2018 01:04 PM, Roland Dreier wrote: Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-25 Thread Greg Kroah-Hartman
On Sat, Aug 25, 2018 at 06:52:32AM -0700, Guenter Roeck wrote: > Hi Roland, > > On 08/24/2018 01:04 PM, Roland Dreier wrote: > > > Ok, so what patch should be reverted? I'm seeing other reports of > > > problems all around this same area, but I can't figure out exactly what > > > to do. > > > >

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-25 Thread Guenter Roeck
Hi Roland, On 08/24/2018 01:04 PM, Roland Dreier wrote: Ok, so what patch should be reverted? I'm seeing other reports of problems all around this same area, but I can't figure out exactly what to do. Are any of those reports public? If so can you point me at them, I'm curious if the

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Guenter Roeck
+Andi Kleen On Fri, Aug 24, 2018 at 01:04:09PM -0700, Roland Dreier wrote: > > Ok, so what patch should be reverted? I'm seeing other reports of > > problems all around this same area, but I can't figure out exactly what > > to do. > > Are any of those reports public? If so can you point me

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Guenter Roeck
On Fri, Aug 24, 2018 at 01:16:18PM -0700, Roland Dreier wrote: > > Sounds great. I'll hold off with sending my RFT series and wait for your > > test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix > > boot crash when 1GB pages are not supported by the CPU"). > > Sure, makes

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Roland Dreier
> Sounds great. I'll hold off with sending my RFT series and wait for your > test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix > boot crash when 1GB pages are not supported by the CPU"). Sure, makes sense - I don't have any EFI systems with CPUs old enough not to support 1G

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Guenter Roeck
On Fri, Aug 24, 2018 at 01:04:09PM -0700, Roland Dreier wrote: > > Ok, so what patch should be reverted? I'm seeing other reports of > > problems all around this same area, but I can't figure out exactly what > > to do. > > Are any of those reports public? If so can you point me at them, I'm >

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Guenter Roeck
On Fri, Aug 24, 2018 at 09:17:49PM +0200, Greg Kroah-Hartman wrote: > On Fri, Aug 24, 2018 at 10:08:28AM -0700, Roland Dreier wrote: > > > See > > > . > > > > Thanks! I'm not using SGI UV and I'm not using kexec, so I

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Roland Dreier
> Ok, so what patch should be reverted? I'm seeing other reports of > problems all around this same area, but I can't figure out exactly what > to do. Are any of those reports public? If so can you point me at them, I'm curious if the symptoms match up. I don't think we want to revert

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Greg Kroah-Hartman
On Fri, Aug 24, 2018 at 10:08:28AM -0700, Roland Dreier wrote: > > See > > . > > Thanks! I'm not using SGI UV and I'm not using kexec, so I guess I > sidestepped most of those issues. Greg, I think we need to unrevert

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Roland Dreier
> See > . Thanks! I'm not using SGI UV and I'm not using kexec, so I guess I sidestepped most of those issues. Greg, I think we need to unrevert the cpa->pfn change (otherwise the L1TF fix probably gets pretty messy)

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Ben Hutchings
On Wed, 2018-08-22 at 17:48 -0700, Roland Dreier wrote: > On Fri, Dec 15, 2017 at 2:20 AM Greg Kroah-Hartman > > wrote: > > This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is > > commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. > > > > Turns there was too many other

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-24 Thread Matt Fleming
On Thu, 23 Aug, at 09:37:28AM, Roland Dreier wrote: > > > This is bad enough that 4.4.148 and all newer 4.4.y crash early in > > > boot on some EFI systems that I have. > > > > Ugh, not good. > > > > > For now I am re-applying the "ensure cpa->pfn only contains page frame > > > numbers" patch,

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-23 Thread Roland Dreier
> > This is bad enough that 4.4.148 and all newer 4.4.y crash early in > > boot on some EFI systems that I have. > > Ugh, not good. > > > For now I am re-applying the "ensure cpa->pfn only contains page frame > > numbers" patch, ported on top of 4.4.151. > > I can try to add it back and see what

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-23 Thread Greg Kroah-Hartman
On Wed, Aug 22, 2018 at 05:48:32PM -0700, Roland Dreier wrote: > On Fri, Dec 15, 2017 at 2:20 AM Greg Kroah-Hartman > wrote: > > This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is > > commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. > > > > Turns there was too many

Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2018-08-22 Thread Roland Dreier
On Fri, Dec 15, 2017 at 2:20 AM Greg Kroah-Hartman wrote: > This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is > commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. > > Turns there was too many other issues with this patch to make it viable > for the stable tree. This

[PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2017-12-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. Turns there was