Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Andy Shevchenko
On Mon, May 14, 2018 at 11:44 PM, Rafael J. Wysocki wrote: > On Mon, May 14, 2018 at 6:13 PM, Andy Shevchenko > wrote: >> On Mon, 2018-05-14 at 17:40 +0200, Lukas Wunner wrote: >>> On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: >>> Well if that is your concern then you need to

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Rafael J. Wysocki
On Mon, May 14, 2018 at 6:13 PM, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 17:40 +0200, Lukas Wunner wrote: >> On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: >> > On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: >> > > On Tue, May 08, 2018 at 04:15:47PM +0300, Andy She

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Lukas Wunner
On Mon, May 14, 2018 at 07:13:24PM +0300, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 17:40 +0200, Lukas Wunner wrote: > > On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: > > > On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: > > > > On Tue, May 08, 2018 at 04:15:47PM +030

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Andy Shevchenko
On Mon, 2018-05-14 at 17:40 +0200, Lukas Wunner wrote: > On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: > > On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: > > > On Tue, May 08, 2018 at 04:15:47PM +0300, Andy Shevchenko wrote: > > > > --- a/drivers/firmware/efi/apple-proper

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Lukas Wunner
On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: > > On Tue, May 08, 2018 at 04:15:47PM +0300, Andy Shevchenko wrote: > > > --- a/drivers/firmware/efi/apple-properties.c > > > +++ b/drivers/firmware/efi/apple-properties.c > >

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Andy Shevchenko
On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: > On Tue, May 08, 2018 at 04:15:47PM +0300, Andy Shevchenko wrote: > > --- a/drivers/firmware/efi/apple-properties.c > > +++ b/drivers/firmware/efi/apple-properties.c > > @@ -13,6 +13,9 @@ > > * > > * You should have received a copy of the

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Lukas Wunner
On Tue, May 08, 2018 at 04:15:47PM +0300, Andy Shevchenko wrote: > --- a/drivers/firmware/efi/apple-properties.c > +++ b/drivers/firmware/efi/apple-properties.c > @@ -13,6 +13,9 @@ > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, s

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Ard Biesheuvel
On 8 May 2018 at 15:15, Andy Shevchenko wrote: > The commit > > 318a19718261 ("device property: refactor built-in properties support") > > went way too far and brought a union aliasing. Partially revert it here > to get rid of union aliasing. > > Note, Apple properties support is still utilizing

[PATCH v2] device property: Get rid of union aliasing

2018-05-08 Thread Andy Shevchenko
The commit 318a19718261 ("device property: refactor built-in properties support") went way too far and brought a union aliasing. Partially revert it here to get rid of union aliasing. Note, Apple properties support is still utilizing this trick. What union aliasing is? ~~~