Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-11 Thread Baoquan He
Hi all, On 05/05/17 at 09:42pm, Matt Fleming wrote: > (Including the folks from SGI since this was hit on a UV system) After debugging, I got the reason why kernel still crash casually when the ident mapping issue of old_map efi has been fixed. It's because SGI UV3 needs map MMIOH regions. On a

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-09 Thread Baoquan He
On 05/08/17 at 05:25pm, Borislav Petkov wrote: > On Mon, May 08, 2017 at 09:36:49AM +0800, Baoquan He wrote: > > Thanks for explaining, Bhupesh. > > > > BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to > > use efi old map: > > > > void __init efi_apply_memmap_quirks(void) > >

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-08 Thread Baoquan He
On 05/08/17 at 05:25pm, Borislav Petkov wrote: > On Mon, May 08, 2017 at 09:36:49AM +0800, Baoquan He wrote: > > Thanks for explaining, Bhupesh. > > > > BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to > > use efi old map: > > > > void __init efi_apply_memmap_quirks(void) > >

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-08 Thread Borislav Petkov
On Mon, May 08, 2017 at 09:36:49AM +0800, Baoquan He wrote: > Thanks for explaining, Bhupesh. > > BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to > use efi old map: > > void __init efi_apply_memmap_quirks(void) > { > ... > ... > /* UV2+ BIOS has a fix for

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-07 Thread Russ Anderson
On Sat, May 06, 2017 at 01:36:20AM +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote: > > (Including the folks from SGI since this was hit on a UV system) > > Wasn't there a BIOS fix supplied at some point which obviated the need > to boot with efi=old_ma

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-07 Thread Baoquan He
Thanks for explaining, Bhupesh. BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to use efi old map: void __init efi_apply_memmap_quirks(void) { ... ... /* UV2+ BIOS has a fix for this issue. UV1 still needs the quirk. */ if (dmi_check_system(sgi

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-07 Thread Bhupesh Sharma
On Sat, May 6, 2017 at 5:06 AM, Borislav Petkov wrote: > On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote: >> (Including the folks from SGI since this was hit on a UV system) > > Wasn't there a BIOS fix supplied at some point which obviated the need > to boot with efi=old_map on SGI bo

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-05 Thread Borislav Petkov
On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote: > (Including the folks from SGI since this was hit on a UV system) Wasn't there a BIOS fix supplied at some point which obviated the need to boot with efi=old_map on SGI boxes? -- Regards/Gruss, Boris. Good mailing practices for

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-05 Thread Matt Fleming
(Including the folks from SGI since this was hit on a UV system) On Thu, 27 Apr, at 08:07:03PM, Baoquan He wrote: > For EFI with old_map enabled, Kernel will panic when kaslr is enabled. > > The root cause is the ident mapping is not built correctly in this case. > > For nokaslr kernel, PAGE_OFF

Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-01 Thread Thomas Garnier
On Thu, Apr 27, 2017 at 5:07 AM, Baoquan He wrote: > For EFI with old_map enabled, Kernel will panic when kaslr is enabled. > > The root cause is the ident mapping is not built correctly in this case. > > For nokaslr kernel, PAGE_OFFSET is 0x8800 which is PGDIR_SIZE > aligned. We can b

[PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-04-27 Thread Baoquan He
For EFI with old_map enabled, Kernel will panic when kaslr is enabled. The root cause is the ident mapping is not built correctly in this case. For nokaslr kernel, PAGE_OFFSET is 0x8800 which is PGDIR_SIZE aligned. We can borrow the pud table from direct mapping safely. Given a physic