Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-27 Thread Jarkko Sakkinen
On Wed, Sep 25, 2019 at 09:41:33AM -0700, Jerry Snitselaar wrote: > On Wed Sep 25 19, Jerry Snitselaar wrote: > > On Wed Sep 25 19, Jarkko Sakkinen wrote: > > > On Wed, Sep 25, 2019 at 12:25:05PM +0200, Ard Biesheuvel wrote: > > > > On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen > > > > wrote: > >

Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-27 Thread Jarkko Sakkinen
On Wed, Sep 25, 2019 at 08:16:16AM -0700, Jerry Snitselaar wrote: > On Wed Sep 25 19, Jarkko Sakkinen wrote: > > On Wed, Sep 25, 2019 at 12:25:05PM +0200, Ard Biesheuvel wrote: > > > On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen > > > wrote: > > > > > > > > From: Peter Jones > > > > > > > > Some

Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-25 Thread Jerry Snitselaar
On Wed Sep 25 19, Jerry Snitselaar wrote: On Wed Sep 25 19, Jarkko Sakkinen wrote: On Wed, Sep 25, 2019 at 12:25:05PM +0200, Ard Biesheuvel wrote: On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen wrote: From: Peter Jones Some machines generate a lot of event log entries. When we're iterating

Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-25 Thread Jerry Snitselaar
On Wed Sep 25 19, Jarkko Sakkinen wrote: On Wed, Sep 25, 2019 at 12:25:05PM +0200, Ard Biesheuvel wrote: On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen wrote: > > From: Peter Jones > > Some machines generate a lot of event log entries. When we're > iterating over them, the code removes the old

Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-25 Thread Jarkko Sakkinen
On Wed, Sep 25, 2019 at 12:25:05PM +0200, Ard Biesheuvel wrote: > On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen > wrote: > > > > From: Peter Jones > > > > Some machines generate a lot of event log entries. When we're > > iterating over them, the code removes the old mapping and adds a > > new on

Re: [PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-25 Thread Ard Biesheuvel
On Wed, 25 Sep 2019 at 12:16, Jarkko Sakkinen wrote: > > From: Peter Jones > > Some machines generate a lot of event log entries. When we're > iterating over them, the code removes the old mapping and adds a > new one, so once we cross the page boundary we're unmapping the page > with the count

[PATCH v2 1/2] efi+tpm: Don't access event->count when it isn't mapped.

2019-09-25 Thread Jarkko Sakkinen
From: Peter Jones Some machines generate a lot of event log entries. When we're iterating over them, the code removes the old mapping and adds a new one, so once we cross the page boundary we're unmapping the page with the count on it. Hilarity ensues. This patch keeps the info from the header