Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-12 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:48 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: >> In arch/x86/boot/header.S, we already use VO and ZO. >> So please keep on using them, and don't introduce "kernel proper" etc. > > So you're suggesting commit messages should us

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:42:40AM -0700, Yinghai Lu wrote: > In arch/x86/boot/header.S, we already use VO and ZO. > So please keep on using them, and don't introduce "kernel proper" etc. So you're suggesting commit messages should use variable names and prefixes from the code instead of being hum

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:21 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: >> Make it not confusing. >> >> ZO: arch/x86/boot/compressed/vmlinux >> VO: vmlinux >> >> setup + ZO ==> bzImage. >> >> compressed kernel is just compressed VO. > > So the two end

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:17:01AM -0700, Yinghai Lu wrote: > Make it not confusing. > > ZO: arch/x86/boot/compressed/vmlinux > VO: vmlinux > > setup + ZO ==> bzImage. > > compressed kernel is just compressed VO. So the two end up being the "compressed kernel" and "kernel proper". And then the

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 8:10 AM, Borislav Petkov wrote: > On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: >> We need to keep VO and ZO here... > > Why? Make it not confusing. ZO: arch/x86/boot/compressed/vmlinux VO: vmlinux setup + ZO ==> bzImage. compressed kernel is just compress

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
On Tue, Mar 10, 2015 at 08:05:52AM -0700, Yinghai Lu wrote: > We need to keep VO and ZO here... Why? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.k

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Yinghai Lu
On Tue, Mar 10, 2015 at 2:34 AM, Borislav Petkov wrote: > Final patch: > > --- > From: Yinghai Lu > Date: Sat, 7 Mar 2015 14:07:17 -0800 > Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed > kernel's data We need to keep VO and ZO here... Should use ZO to replace "compres

Re: [PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-10 Thread Borislav Petkov
Final patch: --- From: Yinghai Lu Date: Sat, 7 Mar 2015 14:07:17 -0800 Subject: [PATCH] x86/setup: Don't overlap vmlinux's brk with compressed kernel's data We already do move the compressed kernel close to the end of the buffer. However, there's still overlapping beween kernel proper's .brk/.b

[PATCH v3 3/7] x86, boot: Don't overlap VO with ZO data

2015-03-07 Thread Yinghai Lu
Boris found data from boot stage can not be used kernel stage. Bootloader allocate buffer according to init_size in hdr, and load the ZO (arch/x86/boot/compressed/vmlinux) from start of that buffer. During running of ZO, ZO move itself to the middle of buffer at z_extract_offset to make sure that