Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/08/2018 06:12 PM, Luis R. Rodriguez wrote: On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: On 4 May 2018 at 01:29, Luis R. Rodriguez wrote: On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: [...] diff --git

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/13/2018 12:43 PM, Ard Biesheuvel wrote: On 13 May 2018 at 13:03, Hans de Goede wrote: Hi, On 05/04/2018 06:56 AM, Ard Biesheuvel wrote: Hi Hans, One comment below, which I missed in review before. On 29 April 2018 at 11:35, Hans de Goede

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On 13 May 2018 at 13:03, Hans de Goede wrote: > Hi, > > > On 05/04/2018 06:56 AM, Ard Biesheuvel wrote: >> >> Hi Hans, >> >> One comment below, which I missed in review before. >> >> On 29 April 2018 at 11:35, Hans de Goede wrote: >>> >>> Just like with

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/03/2018 11:35 PM, Andy Lutomirski wrote: On Thu, May 3, 2018 at 3:31 PM Luis R. Rodriguez wrote: On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: Hi, On 05/01/2018 09:29 PM, Andy Lutomirski wrote: On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/03/2018 11:31 PM, Luis R. Rodriguez wrote: On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: Hi, On 05/01/2018 09:29 PM, Andy Lutomirski wrote: On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: +The EFI embedded-fw code works by scanning all

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/04/2018 06:56 AM, Ard Biesheuvel wrote: Hi Hans, One comment below, which I missed in review before. On 29 April 2018 at 11:35, Hans de Goede wrote: Just like with PCI options ROMs, which we save in the setup_efi_pci* functions from

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: > On 4 May 2018 at 01:29, Luis R. Rodriguez wrote: > > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: > [...] > >> diff --git a/Documentation/driver-api/firmware/request_firmware.rst > >>

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi Hans, One comment below, which I missed in review before. On 29 April 2018 at 11:35, Hans de Goede wrote: > Just like with PCI options ROMs, which we save in the setup_efi_pci* > functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself > sometimes may

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On 4 May 2018 at 01:29, Luis R. Rodriguez wrote: > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: [...] >> diff --git a/Documentation/driver-api/firmware/request_firmware.rst >> b/Documentation/driver-api/firmware/request_firmware.rst >> index

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Please Cc andre...@gmail.com on future patches. On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: > Just like with PCI options ROMs, which we save in the setup_efi_pci* > functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself > sometimes may contain data which is

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Thu, 2018-05-03 at 22:23 +, Luis R. Rodriguez wrote: > On Tue, May 01, 2018 at 03:27:27PM -0400, Mimi Zohar wrote: > > On Tue, 2018-05-01 at 21:11 +0200, Hans de Goede wrote: > > > Only the pre hook? I believe the post-hook should still be called too, > > > right? So that we've hashes of

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Thu, May 3, 2018 at 3:31 PM Luis R. Rodriguez wrote: > On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: > > Hi, > > > > On 05/01/2018 09:29 PM, Andy Lutomirski wrote: > > > On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: > > > > +The

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Wed, May 02, 2018 at 04:49:53PM +0200, Hans de Goede wrote: > Hi, > > On 05/01/2018 09:29 PM, Andy Lutomirski wrote: > > On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: > > > +The EFI embedded-fw code works by scanning all EFI_BOOT_SERVICES_CODE > > memory > > >

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Tue, May 01, 2018 at 03:27:27PM -0400, Mimi Zohar wrote: > On Tue, 2018-05-01 at 21:11 +0200, Hans de Goede wrote: > > Only the pre hook? I believe the post-hook should still be called too, > > right? So that we've hashes of all loaded firmwares in the IMA core. > > Good catch!  Right, if

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 05/01/2018 09:29 PM, Andy Lutomirski wrote: On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: +The EFI embedded-fw code works by scanning all EFI_BOOT_SERVICES_CODE memory +segments for an eight byte sequence matching prefix, if the prefix is found it +then

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Sun, Apr 29, 2018 at 2:36 AM Hans de Goede wrote: > +The EFI embedded-fw code works by scanning all EFI_BOOT_SERVICES_CODE memory > +segments for an eight byte sequence matching prefix, if the prefix is found it > +then does a crc32 over length bytes and if that matches

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Tue, 2018-05-01 at 21:11 +0200, Hans de Goede wrote: > Hi, > > On 01-05-18 16:36, Mimi Zohar wrote: > > [Cc'ing linux-security] > > > > On Sun, 2018-04-29 at 11:35 +0200, Hans de Goede wrote: > > [...] > >> diff --git a/drivers/base/firmware_loader/fallback_efi.c > >>

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

Hi, On 01-05-18 16:36, Mimi Zohar wrote: [Cc'ing linux-security] On Sun, 2018-04-29 at 11:35 +0200, Hans de Goede wrote: [...] diff --git a/drivers/base/firmware_loader/fallback_efi.c b/drivers/base/firmware_loader/fallback_efi.c new file mode 100644 index ..82ba82f48a79 ---

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

[Cc'ing linux-security] On Sun, 2018-04-29 at 11:35 +0200, Hans de Goede wrote: [...] > diff --git a/drivers/base/firmware_loader/fallback_efi.c > b/drivers/base/firmware_loader/fallback_efi.c > new file mode 100644 > index ..82ba82f48a79 > --- /dev/null > +++

[PATCH v5 2/5] efi: Add embedded peripheral firmware support

Just like with PCI options ROMs, which we save in the setup_efi_pci* functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself sometimes may contain data which is useful/necessary for peripheral drivers to have access to. Specifically the EFI code may contain an embedded copy of