Random crashes with i386 and efi boots

2018-09-10 Thread Guenter Roeck
Hi folks, even after commit eeb89e2bb1ac ("x86/efi: Load fixmap GDT in efi_call_phys_epilog()"), my i386/efi qemu boot tests still crash randomly (roughly 5-10% of the time). As before, I don't see much useful output in the qemu log (this time it doesn't even complain about a triple fault). Debu

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Andy Lutomirski
> On Sep 10, 2018, at 2:56 PM, Guenter Roeck wrote: > > Hi folks, > > even after commit eeb89e2bb1ac ("x86/efi: Load fixmap GDT in > efi_call_phys_epilog()"), my i386/efi qemu boot tests still crash randomly > (roughly 5-10% of the time). As before, I don't see much useful output in > the qem

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Guenter Roeck
On 09/11/2018 04:52 AM, Andy Lutomirski wrote: On Sep 10, 2018, at 2:56 PM, Guenter Roeck wrote: Hi folks, even after commit eeb89e2bb1ac ("x86/efi: Load fixmap GDT in efi_call_phys_epilog()"), my i386/efi qemu boot tests still crash randomly (roughly 5-10% of the time). As before, I don't

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Andy Lutomirski
> On Sep 11, 2018, at 6:30 AM, Guenter Roeck wrote: > > On 09/11/2018 04:52 AM, Andy Lutomirski wrote: >>> On Sep 10, 2018, at 2:56 PM, Guenter Roeck wrote: >>> >>> Hi folks, >>> >>> even after commit eeb89e2bb1ac ("x86/efi: Load fixmap GDT in >>> efi_call_phys_epilog()"), my i386/efi qemu

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Joerg Roedel
On Tue, Sep 11, 2018 at 09:36:51AM -0700, Andy Lutomirski wrote: > >save_pgd = efi_call_phys_prolog(); > >local_irq_save(flags); > >status = efi_call_phys(...); > >local_irq_restore(flags); > > > >efi_call_phys_epilog(save_pgd); > > > > So, yes, interrupts are very muc

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Linus Torvalds
On Tue, Sep 11, 2018 at 7:42 AM Joerg Roedel wrote: > > So I am in favor of changing the order in efi_call_phys_epilog() too. Yeah, the only reason the order was changed was that it seemed more logical to use the new cr3 to load the GDT. But that was clearly wrong. So ack on just changing the or

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 07:41:58PM +0200, Joerg Roedel wrote: > On Tue, Sep 11, 2018 at 09:36:51AM -0700, Andy Lutomirski wrote: > > >save_pgd = efi_call_phys_prolog(); > > >local_irq_save(flags); > > >status = efi_call_phys(...); > > >local_irq_restore(flags); > > > > > >

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Andy Lutomirski
> On Sep 11, 2018, at 10:41 AM, Joerg Roedel wrote: > > On Tue, Sep 11, 2018 at 09:36:51AM -0700, Andy Lutomirski wrote: >>> save_pgd = efi_call_phys_prolog(); >>> local_irq_save(flags); >>> status = efi_call_phys(...); >>> local_irq_restore(flags); >>> >>> efi_call_phys_epi

Re: Random crashes with i386 and efi boots

2018-09-11 Thread Guenter Roeck
On Tue, Sep 11, 2018 at 11:05:25AM -0700, Andy Lutomirski wrote: > > > > On Sep 11, 2018, at 10:41 AM, Joerg Roedel wrote: > > > > On Tue, Sep 11, 2018 at 09:36:51AM -0700, Andy Lutomirski wrote: > >>> save_pgd = efi_call_phys_prolog(); > >>> local_irq_save(flags); > >>> status = efi_call