Re: Subject: [PATCH 00/16] Squashfs: compressed read-only filesystem

2008-10-22 Thread Geert Uytterhoeven
Hi Phillip, On Fri, 17 Oct 2008, Phillip Lougher wrote: > This is a second attempt at mainlining Squashfs. The first attempt was way This is great news! I ran a quick test of squashfs 4.0 (the CVS version) on UML/ia32 and ppc64, and it seems to work fine! Great job! Let's hope we'll s

Re: Subject: [PATCH 01/16] Squashfs: inode operations

2008-10-22 Thread Geert Uytterhoeven
On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/inode.c > + case SQUASHFS_BLKDEV_TYPE: > + case SQUASHFS_CHRDEV_TYPE: { > + struct squashfs_dev_inode *inodep = &id.dev; > + unsigned int rdev; > + > + if (!squashfs_read_met

Re: Subject: [PATCH 09/16] Squashfs: uid/gid lookup operations

2008-10-22 Thread Geert Uytterhoeven
On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/id.c > +__le64 *read_id_index_table(struct super_block *s, long long id_table_start, > + unsigned short no_ids) > +{ > + unsigned int length = SQUASHFS_ID_BLOCK_BYTES(no_ids); > + __le64 *id_table; > + > +

Re: Subject: [PATCH 04/16] Squashfs: regular file operations

2008-10-22 Thread Geert Uytterhoeven
On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/file.c > +static long long read_blocklist(struct inode *inode, int index, > + unsigned int *bsize) > +{ > + long long start, block, blks; > + int offset; > + __le32 size; > +

Re: Subject: [PATCH 01/16] Squashfs: inode operations

2008-10-22 Thread Geert Uytterhoeven
On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/inode.c > +static int squashfs_new_inode(struct super_block *s, struct inode *i, > + struct squashfs_base_inode *inodeb) > +{ > + if (squashfs_get_id(s, le16_to_cpu(inodeb->uid), &i->i_u

Re: Subject: [PATCH 00/16] Squashfs: compressed read-only filesystem

2008-10-22 Thread Tim Bird
Phillip Lougher wrote: > Yeah, Git is much better than CVS, however, I've got nowhere to host a > public Git repository. If someone were to offer hosting I'd be only too > happy to move over to Git. I can offer you hosting on mirror.celinuxforum.org. If you are interested, let me know and I'll s

Re: Subject: [PATCH 12/16] Squashfs: header files

2008-10-22 Thread Geert Uytterhoeven
On Fri, 17 Oct 2008, Phillip Lougher wrote: > --- /dev/null > +++ b/fs/squashfs/squashfs.h > +#ifdef SQUASHFS_TRACE > +#define TRACE(s, args...)printk(KERN_NOTICE "SQUASHFS: "s, ## args) > +#else > +#define TRACE(s, args...){} > +#endif Just use #define TRACE(s, args...) pr_debug("

Re: Subject: [PATCH 01/16] Squashfs: inode operations

2008-10-22 Thread Christoph Hellwig
On Tue, Oct 21, 2008 at 12:14:26PM -0400, David P. Quigley wrote: > I looked at where filesystems such as ext3 store these and it seems to > be in include/linux. I'm assuming this is because usespace utilities > like fsck need them. It seems wrong for userspace tools to have their > own private cop

Re: Subject: [PATCH 00/16] Squashfs: compressed read-only filesystem

2008-10-22 Thread David Woodhouse
On Wed, 2008-10-22 at 00:42 +0100, Phillip Lougher wrote: > Yeah, Git is much better than CVS, however, I've got nowhere to host a > public Git repository. If someone were to offer hosting I'd be only too > happy to move over to Git. Mail me a SSH public key (use a passphrase on it), and I'll g

Re: Subject: [PATCH 00/16] Squashfs: compressed read-only filesystem

2008-10-22 Thread Peter Korsgaard
> "Phillip" == Phillip Lougher <[EMAIL PROTECTED]> writes: Hi, Phillip> Yeah, Git is much better than CVS, however, I've got nowhere Phillip> to host a public Git repository. If someone were to offer Phillip> hosting I'd be only too happy to move over to Git. You could apply for a kernel