Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

Mike Frysinger wrote: On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote: + new_bus-irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL); oh, and this should be kcalloc() Why? kcalloc() fills allocated memory with zeros and in this case it has to be filled with -1... this is done

Re: USB, Host and Device on the same machine

If the OTG controller exposes EHCI as its host interface, it sure *ought* to be managed by the EHCI driver. Maybe you should be submitting a patch adding OTG glue to EHCI? If it's not exposing EHCI as its host interface, then it seems your OTG driver is quite buggy... Thanks for the

Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

Grant Likely wrote: On Mon, Oct 27, 2008 at 12:53:22PM +0200, Paulius Zaleckas wrote: Useful for machines where PHY control is connected to GPIO. This driver also supports interrupts from PHY. Changes since v1: - fixed releasing of gpio (thanks to Sascha Hauer) - fixed compiling due to

Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

Thanks for review. Comments below. Mike Frysinger wrote: On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote: [...] +static int __devinit mdio_gpio_probe(struct platform_device *pdev) +{ + struct mii_bus *new_bus; + struct mdio_gpio_info *bitbang; + struct

Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

David Brownell wrote: On Monday 27 October 2008, Grant Likely wrote: On Mon, Oct 27, 2008 at 12:53:22PM +0200, Paulius Zaleckas wrote: Useful for machines where PHY control is connected to GPIO. This driver also supports interrupts from PHY. I get a kick out of seeing each new generic

[PATCH] phylib: add mdio-gpio bus driver (v3)

Useful for machines where PHY control is connected to GPIO. This driver also supports interrupts from PHY. Changes since v2: - add module author, description and license - add module alias for udev - rename mdc and mdio function (were ugly names) - don't BUG kernel if phy address is invalid -

Re: [PATCH] phylib: add mdio-gpio bus driver (v3)

On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote: +config MDIO_GPIO + tristate Support for GPIO bitbanged MDIO buses config MDIO_OF_GPIO tristate Support for GPIO lib-based bitbanged MDIO buses seems to me these drivers have the same description ... +++

Re: [PATCH] phylib: add mdio-gpio bus driver (v3)

Mike Frysinger wrote: On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote: +config MDIO_GPIO + tristate Support for GPIO bitbanged MDIO buses config MDIO_OF_GPIO tristate Support for GPIO lib-based bitbanged MDIO buses seems to me these drivers have the same description ...

Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

On Tue, Oct 28, 2008 at 1:46 AM, Paulius Zaleckas [EMAIL PROTECTED] wrote: Grant Likely wrote: The IRQ array is fixed size. You can add it to the mdio_gpio_info structure and then just set the pointer here so that only one kzalloc is needed. It can be put in mdio_gpio_info, but please note

Re: [PATCH] phylib: add mdio-gpio bus driver (v3)

On Tue, Oct 28, 2008 at 5:31 AM, Paulius Zaleckas [EMAIL PROTECTED] wrote: Mike Frysinger wrote: On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote: +config MDIO_GPIO + tristate Support for GPIO bitbanged MDIO buses config MDIO_OF_GPIO tristate Support for GPIO lib-based

Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

On Tue, Oct 28, 2008 at 9:17 AM, Russell King - ARM Linux [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 07:08:06AM -0600, Grant Likely wrote: On Tue, Oct 28, 2008 at 1:46 AM, Paulius Zaleckas [EMAIL PROTECTED] wrote: Grant Likely wrote: The IRQ array is fixed size. You can add it to the

Re: Subject: [PATCH 02/16] Squashfs: directory lookup operations

On Tue, 28 Oct 2008, Michael Tokarev wrote: Geert Uytterhoeven wrote: On Fri, 17 Oct 2008, Phillip Lougher wrote: --- /dev/null +++ b/fs/squashfs/namei.c +static int get_dir_index_using_name(struct super_block *s, + long long *next_block, unsigned int

[PATCH V2 00/16] Squashfs: compressed read-only filesystem

Hi, This a respin of the Squashfs patches incorporating the review comments received. Thanks to everyone who have sent comments. Summary of changes in patch respin: 1. Functions changed to return 0 on success and -ESOMETHING on error 2. Header files moved from include/linux to fs/squashfs 3.

[PATCH V2 16/16] MAINTAINERS: squashfs entry

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 16202c8..bc5b063 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3951,6 +3951,13 @@ L: [EMAIL PROTECTED] W:

[PATCH V2 15/16] Squashfs: initrd support

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- init/do_mounts_rd.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c index a7c748f..0f0f0cf 100644 --- a/init/do_mounts_rd.c +++ b/init/do_mounts_rd.c @@ -9,6 +9,7

[PATCH V2 02/16] Squashfs: directory lookup operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/namei.c | 242 +++ 1 files changed, 242 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c new file mode 100644 index 000..db03ffe ---

[PATCH V2 11/16] Squashfs: block operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/block.c | 256 +++ 1 files changed, 256 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c new file mode 100644 index 000..da5f88b ---

[PATCH V2 10/16] Squashfs: cache operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/cache.c | 315 +++ 1 files changed, 315 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/cache.c b/fs/squashfs/cache.c new file mode 100644 index 000..d121f31 ---

[PATCH V2 12/16] Squashfs: header files

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/squashfs.h | 89 ++ fs/squashfs/squashfs_fs.h| 380 ++ fs/squashfs/squashfs_fs_i.h | 45 + fs/squashfs/squashfs_fs_sb.h | 76 + 4 files changed, 590

[PATCH V2 09/16] Squashfs: uid/gid lookup operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/id.c | 89 ++ 1 files changed, 89 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/id.c b/fs/squashfs/id.c new file mode 100644 index 000..720973f --- /dev/null +++

[PATCH V2 01/16] Squashfs: inode operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/inode.c | 346 +++ 1 files changed, 346 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c new file mode 100644 index 000..840c82b ---

[PATCH V2 03/16] Squashfs: directory readdir operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/dir.c | 236 + 1 files changed, 236 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c new file mode 100644 index 000..f5564e5 --- /dev/null

[PATCH V2 13/16] Squashfs: Makefiles

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/Makefile |1 + fs/squashfs/Makefile |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fs/Makefile b/fs/Makefile index 2168c90..90c1eee 100644 --- a/fs/Makefile +++ b/fs/Makefile @@ -76,6 +76,7 @@

[PATCH V2 05/16] Squashfs: symlink operations

Signed-off-by: Phillip Lougher [EMAIL PROTECTED] --- fs/squashfs/symlink.c | 119 + 1 files changed, 119 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/symlink.c b/fs/squashfs/symlink.c new file mode 100644 index 000..b031a4e ---