Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Ming Lei
On Sun, 23 May 2010 20:47:46 +0100 Russell King - ARM Linux wrote: > Let me explain again. We have this series of actions: > > - in userspace > - exception happens > - cpu disables interrupts itself > - save state > - enable interrupts, and tell lockdep that IRQs are unmasked > - we process the

Re: [Squashfs-devel] [PATCH 1/2] Squashfs: add LZO decompression support

2010-05-23 Thread Phillip Lougher
Chan Jeong wrote: Hi, This patch series adds LZO decompression support to Squashfs, using in-kernel LZO decompression library and Squashfs decompressor entries. The patch series also includes LZO support for Squashfs tools. Signed-off-by: Chan Jeong Hi Chan Thanks for the patches. How m

Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Russell King - ARM Linux
On Sun, May 23, 2010 at 11:07:50PM +0800, Ming Lei wrote: > 2010/5/23 Russell King - ARM Linux : > > On Sun, May 23, 2010 at 09:44:20PM +0800, Ming Lei wrote: > >> 2010/5/23 Russell King - ARM Linux : > >> >>  ENTRY(ret_to_user) > >> >>  ret_slow_syscall: > >> >> -     disable_irq                  

Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Ming Lei
2010/5/23 Russell King - ARM Linux : > On Sun, May 23, 2010 at 09:44:20PM +0800, Ming Lei wrote: >> 2010/5/23 Russell King - ARM Linux : >> >>  ENTRY(ret_to_user) >> >>  ret_slow_syscall: >> >> -     disable_irq                             @ disable interrupts >> >> +     disable_irq_notrace      

Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Russell King - ARM Linux
On Sun, May 23, 2010 at 09:44:20PM +0800, Ming Lei wrote: > 2010/5/23 Russell King - ARM Linux : > >>  ENTRY(ret_to_user) > >>  ret_slow_syscall: > >> -     disable_irq                             @ disable interrupts > >> +     disable_irq_notrace                             @ disable interrupts >

Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Ming Lei
2010/5/23 Russell King - ARM Linux : >>  ENTRY(ret_to_user) >>  ret_slow_syscall: >> -     disable_irq                             @ disable interrupts >> +     disable_irq_notrace                             @ disable interrupts > > I think this one does need to be traced - the pending work functi

Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread Russell King - ARM Linux
On Sun, May 23, 2010 at 07:48:48PM +0800, tom.leim...@gmail.com wrote: > diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S > index 2c1db77..ed471a7 100644 > --- a/arch/arm/kernel/entry-common.S > +++ b/arch/arm/kernel/entry-common.S > @@ -58,7 +58,7 @@ work_resched: > *

[RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010-05-23 Thread tom . leiming
From: Ming Lei This patch fixes the 'unannotated irqs-on' lockdep warning[1]: This patch introduces macro of trace_ret_hardirqs_on, which will call trace_hardirqs_on if I flag in the stored CPSR is zero. In the path of returning to user-space, the patch replaces disable_irq with disable_irq_not