Re: usb-skeleton.c - generates warning

2010-10-16 Thread Mike Frysinger
On Sat, Oct 16, 2010 at 07:00, Andrew Worsley wrote: > Sorry if this is the wrong mailing list for this - I am writing a USB > driver  (for an embedded system) modeled on the > drivers/usb/usb-skeleton.c you can find the correct list here: http://vger.kernel.org/vger-lists.html#linux-usb -mike --

usb-skeleton.c - generates warning

2010-10-16 Thread Andrew Worsley
Sorry if this is the wrong mailing list for this - I am writing a USB driver (for an embedded system) modeled on the drivers/usb/usb-skeleton.c version 2.6.30 but it gets the following warning. It looks like it is a generic issue, perhaps the skeleton is not maintained any more? If so is there a

Re: [PWM 06/10] Incorporate PWM API code into KBuild

2010-10-16 Thread Grant Likely
On Fri, Oct 01, 2010 at 10:17:47AM -0500, Bill Gatliff wrote: > Signed-off-by: Bill Gatliff Ditto on description. > --- > drivers/Kconfig |2 ++ > drivers/Makefile |2 ++ > drivers/leds/Kconfig | 22 -- > drivers/leds/Makefile |2 ++ > drivers/pwm/K

Re: [PWM 04/10] Implements PWM-based LED control

2010-10-16 Thread Grant Likely
On Fri, Oct 01, 2010 at 10:17:45AM -0500, Bill Gatliff wrote: > Signed-off-by: Bill Gatliff Ditto on comment and patch title > --- > drivers/leds/Kconfig| 19 +++- > drivers/leds/leds-pwm.c | 224 +++--- > include/linux/pwm/pwm-led.h | 33 +++

Re: [PWM 05/10] LED "dim" trigger based on PWM control of the LED

2010-10-16 Thread Grant Likely
On Fri, Oct 01, 2010 at 10:17:46AM -0500, Bill Gatliff wrote: > Signed-off-by: Bill Gatliff Ditto on description Otherwise pretty straight forward. Looks okay to me. g. > --- > drivers/leds/ledtrig-dim.c | 96 > > 1 files changed, 96 insertions

Re: [PWM 03/10] Expunge old Atmel PWMC driver, replacing it with one that conforms to the PWM API

2010-10-16 Thread Grant Likely
On Fri, Oct 01, 2010 at 10:17:44AM -0500, Bill Gatliff wrote: > Signed-off-by: Bill Gatliff This patch needs a better description about what is going on here. If you're replacing an old driver, you must talk about what is changing and why. You cannot assume that a future reader will have the co

Re: [PWM 01/10] API to consolidate PWM devices behind a common user and kernel interface

2010-10-16 Thread Grant Likely
On Fri, Oct 01, 2010 at 10:17:42AM -0500, Bill Gatliff wrote: > Signed-off-by: Bill Gatliff Hi Bill, comments below. > --- > Documentation/pwm.txt | 260 +++ > drivers/pwm/pwm.c | 635 > +++ > include/linux/pwm.h | 31