Re: [PWM v3: 1/3] PWM: Implement a generic PWM framework

2011-02-11 Thread Bill Gatliff
Sascha: >> I think theres no value in having the FLAG_REGISTERED flag and this >> function. > > I think it sneaked in before I was using the mutex to prevent the list > of devices from changing during a lookup.  Fixed. I take that back. What having that flag lets one do is error recovery that l

Re: [PWM v3: 1/3] PWM: Implement a generic PWM framework

2011-02-11 Thread Bill Gatliff
Sascha: Thanks so much for the great feedback! My responses are inlined below. b.g. On Thu, Feb 10, 2011 at 2:39 PM, Sascha Hauer wrote: > default n is the default and can be removed. Fixed. > I can't see anything from platform_device.h being used here. Correct. I forgot to remove that

Re: [PATCH] printk-formats.txt documentation update

2011-02-11 Thread Andrew Murray
On 7 February 2011 19:33, Joe Perches wrote: > > On Mon, 2011-02-07 at 18:12 +, Andrew Murray wrote: > > On 7 February 2011 09:29, Wolfram Sang wrote: > > > On Sun, Feb 06, 2011 at 04:23:09PM +, Andrew Murray wrote: > > >> + > Thanks for the feedback - I'll be on holiday shortly - so wil