Re: [PATCH] Tools for controling ubiblk

2011-08-22 Thread Artem Bityutskiy
I do not think LKML is interested in mtd-utils user-space project patches, please, do not add lkml to spam it less. On Wed, 2011-08-17 at 16:20 +0200, David Wagner wrote: > +#ifndef __UBIBLK_USER_H__ > +#define __UBIBLK_USER_H__ > + > +#include > + > +/* Structure to be passed to UBIBLK_IOCADD or

Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI

2011-08-22 Thread Artem Bityutskiy
On Wed, 2011-08-17 at 15:17 +0200, david.wag...@free-electrons.com wrote: > Questions: > == > I wasn't sure what magic ioctl number to use, so I settled to use the same one > as a part of UBI: 'O', which was so far only used by UBI but on a higher range > and leaving some room for UBI to ad

Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI

2011-08-22 Thread Artem Bityutskiy
Hi, thanks for the patch, it is quite good I think, but I still have few comments. I did not review very carefully because of limited amount of free time. There are few checkpatch.pl complaints, could you please take a look? Note, often I give a comment for one place, but there are many other si