Re: [PATCH 03/10] AXFS: axfs.h

2008-08-22 Thread Jared Hulbert
>> So do I understand right that 3 bytes is your minimum size, and going >> smaller than that would not be helpful? Otherwise I would assume that >> storing a '5' should only take one byte instead of three. Right. But you need 3 bytes to store the maximum value 0x0a If we had: 0x

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-22 Thread Geert Uytterhoeven
On Fri, 22 Aug 2008, Arnd Bergmann wrote: > On Friday 22 August 2008, Jared Hulbert wrote: > > If I have an array of u64 numbers tracking small numbers (a[0] = 1; > > a[1] = 2;) just throwing that onmedia is a big waste. > > (0x0001; 0x0002) Having different array types > >

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-22 Thread Arnd Bergmann
On Friday 22 August 2008, Jared Hulbert wrote: > > This bytetable stuff looks overly complicated, both the data structure and > > the access method. It seems like you are implementing your own custom > > Huffman > > compression with this. > > > > Is the reasonn for the bytetable just to pack numbe

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Jared Hulbert
> This bytetable stuff looks overly complicated, both the data structure and > the access method. It seems like you are implementing your own custom Huffman > compression with this. > > Is the reasonn for the bytetable just to pack numbers efficiently, or do you > have a different intention? It lo

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Jared Hulbert
> I think it would be much cleaner to do all these similar macro's as > static inline functions. Yeah. Been thinking about that. -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Jared Hulbert
>> +#define AXFS_PAGE_SIZE 4096 > > What happens on systems where AXFS_PAGE_SIZE != PAGE_SIZE? Right now, bad things I imagine. I meant to revisit this, there was some reason during development for this, I don't remember. No reason for AXFS_PAGE_SIZE I think. -- To unsubscribe from this list: se

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Daniel Walker
On Wed, 2008-08-20 at 22:45 -0700, Jared Hulbert wrote: > +#define AXFS_GET_BYTETABLE_VAL(desc,index) \ > + axfs_bytetable_stitch(((struct > axfs_region_desc)(desc)).table_byte_depth,\ > + (u8 *)((struct axfs_region_desc)(desc)).virt_addr, index) > + > +#define AXFS_GET_NODE_TYPE(sbi,node_index)

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Arnd Bergmann
On Thursday 21 August 2008, Jared Hulbert wrote: > +static inline u64 axfs_bytetable_stitch(u8 depth, u8 *table, u64 index) > +{ > +   u64 i; > +   u64 output = 0; > +   u64 byte = 0; > +   u64 j; > +   u64 bits; > + > +   for (i = 0; i < depth; i++) { > +   j =

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Arnd Bergmann
On Thursday 21 August 2008, Jared Hulbert wrote: > > +#ifndef __AXFS_H > +#define __AXFS_H > + > + > +#ifdef __KERNEL__ > +#include > +#endif > +#include > +#include > + > +#define AXFS_MAGIC 0x48A0E4CD /* some random number */ > +#define AXFS_SIGNATURE "Advanced XIP FS" > +#define

Re: [PATCH 03/10] AXFS: axfs.h

2008-08-21 Thread Carsten Otte
Jared Hulbert wrote: +#define AXFS_GET_BYTETABLE_VAL(desc,index) \ + axfs_bytetable_stitch(((struct axfs_region_desc)(desc)).table_byte_depth,\ + (u8 *)((struct axfs_region_desc)(desc)).virt_addr, index) + +#define AXFS_GET_NODE_TYPE(sbi,node_index) \ + AXFS_GET_BYTETABLE_VAL(((struct axfs_sup

[PATCH 03/10] AXFS: axfs.h

2008-08-20 Thread Jared Hulbert
The AXFS header. Signed-off-by: Jared Hulbert <[EMAIL PROTECTED]> --- diff --git a/include/linux/axfs.h b/include/linux/axfs.h new file mode 100644 index 000..87af84a --- /dev/null +++ b/include/linux/axfs.h @@ -0,0 +1,360 @@ +/* + * Advanced XIP File System for Linux - AXFS + * Readonly, co