Re: [PATCH 08/14] Pramfs: Makefile and Kconfig

2009-06-14 Thread Marco
Daniel Walker wrote: > On Sat, 2009-06-13 at 15:22 +0200, Marco wrote: >> From: Marco Stornelli >> >> Makefile and Kconfig. >> >> Signed-off-by: Marco Stornelli >> --- >> > > You should move this patch to 11 of 14, as I think that is the point > when the filesystem can actually be enabled and fu

Re: [PATCH 08/14] Pramfs: Makefile and Kconfig

2009-06-14 Thread Marco
Sam Ravnborg wrote: >> + >> +config PRAMFS_NOWP >> +bool "Disable PRAMFS write protection" >> +depends on PRAMFS >> +default n >> +help >> + Say Y here to disable the write protect feature of PRAMFS. > n is default so "default n" is not needed. > If you reverse the logic (and

Re: [PATCH 08/14] Pramfs: Makefile and Kconfig

2009-06-13 Thread Daniel Walker
On Sat, 2009-06-13 at 15:22 +0200, Marco wrote: > From: Marco Stornelli > > Makefile and Kconfig. > > Signed-off-by: Marco Stornelli > --- > You should move this patch to 11 of 14, as I think that is the point when the filesystem can actually be enabled and function. If this series is only ap

Re: [PATCH 08/14] Pramfs: Makefile and Kconfig

2009-06-13 Thread Sam Ravnborg
> + > +config PRAMFS_NOWP > + bool "Disable PRAMFS write protection" > + depends on PRAMFS > + default n > + help > +Say Y here to disable the write protect feature of PRAMFS. n is default so "default n" is not needed. If you reverse the logic (and add a default y) then.. >

[PATCH 08/14] Pramfs: Makefile and Kconfig

2009-06-13 Thread Marco
From: Marco Stornelli Makefile and Kconfig. Signed-off-by: Marco Stornelli --- diff -uprN linux-2.6.30-orig/fs/Kconfig linux-2.6.30/fs/Kconfig --- linux-2.6.30-orig/fs/Kconfig2009-06-10 05:05:27.0 +0200 +++ linux-2.6.30/fs/Kconfig 2009-06-13 10:01:41.0 +0200 @@ -13,