Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Gao Xiang
On Mon, Dec 28, 2020 at 07:46:56PM +0800, Yue Hu wrote: > Hi Xiang, > > Works fine to me for canned/non-canned fs_config. > > Tested-by: Yue Hu > Okay, got it. thanks you all for this :) (also another link for indirect call: https://lwn.net/Articles/774743/ , so as long as some switch

Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Yue Hu
Hi Xiang, Works fine to me for canned/non-canned fs_config. Tested-by: Yue Hu Thx. On Mon, 28 Dec 2020 18:51:46 +0800 Gao Xiang wrote: > From: Gao Xiang > > "failed to find [%s] in canned fs_config" was observed by using > "--fs-config-file" option as reported by Yue Hu [1]. > > The root

Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Yue Hu
On Mon, 28 Dec 2020 19:32:47 +0800 Gao Xiang wrote: > Hi Yue, > > On Mon, Dec 28, 2020 at 07:20:48PM +0800, Yue Hu wrote: > > On Mon, 28 Dec 2020 18:51:46 +0800 > > Gao Xiang wrote: > > ... > > > > @@ -696,32 +696,43 @@ int erofs_droid_inode_fsconfig(struct > > > erofs_inode *inode, /*

Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Gao Xiang
Hi Yue, On Mon, Dec 28, 2020 at 07:20:48PM +0800, Yue Hu wrote: > On Mon, 28 Dec 2020 18:51:46 +0800 > Gao Xiang wrote: ... > > @@ -696,32 +696,43 @@ int erofs_droid_inode_fsconfig(struct > > erofs_inode *inode, /* filesystem_config does not preserve file type > > bits */ mode_t

Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Yue Hu
On Mon, 28 Dec 2020 18:51:46 +0800 Gao Xiang wrote: > From: Gao Xiang > > "failed to find [%s] in canned fs_config" was observed by using > "--fs-config-file" option as reported by Yue Hu [1]. > > The root cause was that the mountpoint prefix to subdirectories is > also needed if

Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Huang Jianan
Hi Xiang, This patch works well with or without --fs-config-file in build. Tested-by: Huang Jianan Thanks, Jianan 在 2020/12/28 18:51, Gao Xiang 写道: From: Gao Xiang "failed to find [%s] in canned fs_config" was observed by using "--fs-config-file" option as reported by Yue Hu [1]. The

[PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Gao Xiang
From: Gao Xiang "failed to find [%s] in canned fs_config" was observed by using "--fs-config-file" option as reported by Yue Hu [1]. The root cause was that the mountpoint prefix to subdirectories is also needed if "--mount-point" presents. However, such prefix cannot be added by just using

Re: [PATCH] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Gao Xiang
On Mon, Dec 28, 2020 at 06:03:26PM +0800, Huang Jianan wrote: > > 在 2020/12/26 14:27, Gao Xiang 写道: ... > > + if (!cfg.mount_point || > > + /* have to drop the mountpoint for rootdir of canned fsconfig */ > > + (cfg.fs_config_file && IS_ROOT(inode))) { > > Hi Xiang, > > I have

Re: [PATCH] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config

2020-12-28 Thread Huang Jianan
在 2020/12/26 14:27, Gao Xiang 写道: From: Gao Xiang "failed to find [%s] in canned fs_config" was observed by using "--fs-config-file" option as reported by Yue Hu [1]. The root cause was that the mountpoint prefix to subdirectories is also needed if "--mount-point" presents. However, such