(+ Greg, Huang Jianan, Dongliang Mu)
On 2023/4/12 11:11, Yangtao Li wrote:
It is better not to directly access the internal members of the
kobject object, especially kobject_init_and_add() may failure.
BTW remove unnecessary kobject_del(), kobject_put() actually covers
kobject removal
On Tue, Apr 11, 2023 at 07:33:19PM -0700, Eric Biggers wrote:
> On Mon, Apr 10, 2023 at 10:19:46PM -0700, Christoph Hellwig wrote:
> > Dave is going to hate me for this, but..
> >
> > I've been looking over some of the interfaces here, and I'm starting
> > to very seriously questioning the design
It is better not to directly access the internal members of the
kobject object, especially kobject_init_and_add() may failure.
BTW remove unnecessary kobject_del(), kobject_put() actually covers
kobject removal automatically, which is single stage removal.
Signed-off-by: Yangtao Li
---
On Mon, Apr 10, 2023 at 10:19:46PM -0700, Christoph Hellwig wrote:
> Dave is going to hate me for this, but..
>
> I've been looking over some of the interfaces here, and I'm starting
> to very seriously questioning the design decisions of storing the
> fsverity hashes in xattrs.
>
> Yes, storing
tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head: 64be79d41fc0aefc57b4127f949e9995e739398e
commit: 64be79d41fc0aefc57b4127f949e9995e739398e [17/17] erofs: get rid of
z_erofs_fill_inode()
config: m68k-randconfig-r021-20230410
-ci/archive/20230411/202304112351.tohektrr-...@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project
2c57868e2e877f73c339796c3374ae660bb77f0d)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
-ci/archive/20230411/202304112232.ifr8fss7-...@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https
mkfs.erofs supports user specified long xattr name prefix through
"--xattr_prefix" option.
Add test case for this feature.
Signed-off-by: Jingbo Xu
---
v2: test the scenario where normal xattrs and long prefix xattrs mixed in
one file
---
tests/Makefile.am | 3 ++
tests/erofs/021 | 94
Prior to big pclusters, non-compact compression indexes could have
empty headers.
Let's just avoid the legacy path since it can be handled properly
as a specific compression header with z_erofs_fill_inode_lazy() too.
Tested with erofs-utils exist versions.
Signed-off-by: Gao Xiang
---
On 2023/4/11 17:46, Jingbo Xu wrote:
mkfs.erofs supports user specified long xattr name prefix through
"--xattr_prefixes" option.
--xattr_prefix?
Add test case for this feature.
Signed-off-by: Jingbo Xu
---
The long xattr name prefix feature is introduced to erofs-utils by
mkfs.erofs supports user specified long xattr name prefix through
"--xattr_prefixes" option.
Add test case for this feature.
Signed-off-by: Jingbo Xu
---
The long xattr name prefix feature is introduced to erofs-utils by
On 2023/4/11 17:35, Jingbo Xu wrote:
Make .{list,get}xattr routines adapted to long xattr name prefixes.
When the bit 7 of erofs_xattr_entry.e_name_index is set, it indicates
that it refers to a long xattr name prefix.
Signed-off-by: Jingbo Xu
---
v3: introduce infix_len to struct
Make .{list,get}xattr routines adapted to long xattr name prefixes.
When the bit 7 of erofs_xattr_entry.e_name_index is set, it indicates
that it refers to a long xattr name prefix.
Signed-off-by: Jingbo Xu
---
v3: introduce infix_len to struct getxattr_iter, and refactor the
implementation of
Dave is going to hate me for this, but..
I've been looking over some of the interfaces here, and I'm starting
to very seriously questioning the design decisions of storing the
fsverity hashes in xattrs.
Yes, storing them beyond i_size in the file is a bit of a hack, but
it allows to reuse a lot
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any
issue:
Reported-and-tested-by: syzbot+aafb3f37cfeb6534c...@syzkaller.appspotmail.com
Tested on:
commit: 349ea8a3 erofs: enable long extended attribute name pr..
git tree:
On 2023/4/10 17:26, syzbot wrote:
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an
issue:
BUG: unable to handle kernel paging request in z_erofs_decompress_queue
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/
dev-test
Hello,
syzbot tried to test the proposed patch but the build/boot failed:
failed to checkout kernel repo
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git//dev-next:
failed to run ["git" "fetch" "--force"
"2dd127424840ba106193cac6a90d288b6cc7557c" "dev-next"]: exit status 128
On 2023/4/10 17:26, syzbot wrote:
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an
issue:
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/
dev-next
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
dev-test
branch HEAD: 349ea8a32b55212884161ba771dfba1c2e8886f9 erofs: enable long
extended attribute name prefixes
elapsed time: 721m
configs tested: 137
configs skipped: 9
The following configs have been built
19 matches
Mail list logo
