[PATCH v2] erofs: kill hooked chains to avoid loops on deduplicated compressed images

2023-05-22 Thread Gao Xiang
After heavily stressing EROFS with several images which include a hand-crafted image of repeated patterns for more than 46 days, I found two chains could be linked with each other almost simultaneously and form a loop so that the entire loop won't be submitted. As a consequence, the corresponding

[PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Gao Xiang
As Sandeep shown [1], high priority RT per-cpu kthreads are typically helpful for Android scenarios to minimize the scheduling latencies. Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for EROFS_FS_PCPU_KTHREAD. Also clean up unnee

[PATCH v22 08/31] splice: Make splice from a DAX file use copy_splice_read()

2023-05-22 Thread David Howells
Make a read splice from a DAX file go directly to copy_splice_read() to do the reading as filemap_splice_read() is unlikely to find any pagecache to splice. I think this affects only erofs, Ext2, Ext4, fuse and XFS. Signed-off-by: David Howells Reviewed-by: Christoph Hellwig Reviewed-by: Christ

[xiang-erofs:dev-test] BUILD SUCCESS 040fe4eee2f91fdfea6306489bbbda1cf33f9151

2023-05-22 Thread kernel test robot
defconfig gcc alpharandconfig-r002-20230522 gcc alpharandconfig-r013-20230521 gcc alpharandconfig-r025-20230521 gcc alpharandconfig-r025-20230522 gcc alpharandconfig-r036-20230522 gcc arc

Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Yue Hu
On Mon, 22 May 2023 17:21:41 +0800 Gao Xiang wrote: > As Sandeep shown [1], high priority RT per-cpu kthreads are > typically helpful for Android scenarios to minimize the scheduling > latencies. > > Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if > EROFS_FS_PCPU_KTHREAD is on since it's the

Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Gao Xiang
On 2023/5/23 17:52, Yue Hu wrote: On Mon, 22 May 2023 17:21:41 +0800 Gao Xiang wrote: As Sandeep shown [1], high priority RT per-cpu kthreads are typically helpful for Android scenarios to minimize the scheduling latencies. Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if EROFS_FS_PCPU_

Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Yue Hu
On Tue, 23 May 2023 09:53:06 +0800 Gao Xiang wrote: > On 2023/5/23 17:52, Yue Hu wrote: > > On Mon, 22 May 2023 17:21:41 +0800 > > Gao Xiang wrote: > > > >> As Sandeep shown [1], high priority RT per-cpu kthreads are > >> typically helpful for Android scenarios to minimize the scheduling > >>

Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Sandeep Dhavale via Linux-erofs
On Mon, May 22, 2023 at 2:21 AM Gao Xiang wrote: > > As Sandeep shown [1], high priority RT per-cpu kthreads are > typically helpful for Android scenarios to minimize the scheduling > latencies. > > Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if > EROFS_FS_PCPU_KTHREAD is on since it's the ty

Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled

2023-05-22 Thread Chao Yu
On 2023/5/22 17:21, Gao Xiang wrote: As Sandeep shown [1], high priority RT per-cpu kthreads are typically helpful for Android scenarios to minimize the scheduling latencies. Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for EROF

Re: EROFS Receives Some Useful Improvements With Linux 6.4

2023-05-22 Thread Bagas Sanjaya
On Mon, May 01, 2023 at 05:05:06PM +0800, Turritopsis Dohrnii Teo En Ming wrote: > Article: EROFS Receives Some Useful Improvements With Linux 6.4 > Link: https://www.phoronix.com/news/Linux-6.4-EROFS Linux 6.4 is on -rc phase (currently v6.4-rc3). Can you try it with erofs enabled and report any

Re: EROFS Receives Some Useful Improvements With Linux 6.4

2023-05-22 Thread Gao Xiang
On 2023/5/23 20:47, Bagas Sanjaya wrote: On Mon, May 01, 2023 at 05:05:06PM +0800, Turritopsis Dohrnii Teo En Ming wrote: Article: EROFS Receives Some Useful Improvements With Linux 6.4 Link: https://www.phoronix.com/news/Linux-6.4-EROFS Linux 6.4 is on -rc phase (currently v6.4-rc3). Can y

Re: [PATCH] erofs: avoid pcpubuf.c inclusion if CONFIG_EROFS_FS_ZIP is off

2023-05-22 Thread Chao Yu
On 2023/5/15 17:57, Yue Hu wrote: From: Yue Hu The function of pcpubuf.c is just for low-latency decompression algorithms (e.g. lz4). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v2] erofs: fix null-ptr-deref caused by erofs_xattr_prefixes_init

2023-05-22 Thread Chao Yu
On 2023/5/15 18:39, Jingbo Xu wrote: Fragments and dedupe share one feature bit, and thus packed inode may not exist when fragment feature bit (dedupe feature bit exactly) is set, e.g. when deduplication feature is in use while fragments feature is not. In this case, sbi->packed_inode could be N