[xiang-erofs:dev-test] BUILD SUCCESS 18bddc5b67038722cb88fcf51fbf41a0277092cb

2023-07-11 Thread kernel test robot
built successfully. More configs may be tested in the coming days. tested configs: alphaallyesconfig gcc alpha defconfig gcc alpharandconfig-r002-20230712 gcc alpharandconfig-r006-20230711 gcc

[PATCH v1] rcu: Fix and improve RCU read lock checks when !CONFIG_DEBUG_LOCK_ALLOC

2023-07-11 Thread Sandeep Dhavale via Linux-erofs
Currently if CONFIG_DEBUG_LOCK_ALLOC is not set - rcu_read_lock_held() always returns 1 - rcu_read_lock_any_held() may return 0 with CONFIG_PREEMPT_RCU This is inconsistent and it was discovered when trying a fix for problem reported [1] with CONFIG_DEBUG_LOCK_ALLOC is not set and CONFIG_PREEMPT_

Re: [PATCH 2/2] erofs: simplify z_erofs_transform_plain()

2023-07-11 Thread Chao Yu
On 2023/6/28 0:12, Gao Xiang wrote: Use memcpy_to_page() instead of open-coding them. In addition, add a missing flush_dcache_page() even though almost all modern architectures clear `PG_dcache_clean` flag for new file cache pages so that it doesn't change anything in practice. Signed-off-by: G

Re: [PATCH 1/2] erofs: get rid of the remaining kmap_atomic()

2023-07-11 Thread Chao Yu
On 2023/6/28 0:12, Gao Xiang wrote: It's unnecessary to use kmap_atomic() compared with kmap_local_page(). In addition, kmap_atomic() is deprecated now. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: fix fsdax unavailability for chunk-based regular files

2023-07-11 Thread Chao Yu
On 2023/7/11 14:21, Xin Yin wrote: DAX can be used to share page cache between VMs, reducing guest memory overhead. And chunk based data format is widely used for VM and container image. So enable dax support for it, make erofs better used for VM scenarios. Fixes: c5aa903a59db ("erofs: support r

Re: [PATCH] erofs: fix to avoid infinite loop in z_erofs_do_read_page() when read page beyond EOF

2023-07-11 Thread Chao Yu
On 2023/7/10 17:34, Chunhai Guo wrote: z_erofs_do_read_page() may loop infinitely due to the inappropriate truncation in the below statement. Since the offset is 64 bits and min_t() truncates the result to 32 bits. The solution is to replace unsigned int with a 64-bit type, such as erofs_off_t.

Re: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF

2023-07-11 Thread Chao Yu
On 2023/7/10 12:25, Chunhai Guo wrote: z_erofs_pcluster_readmore() may take a long time to loop when the page offset is large enough, which is unnecessary should be prevented. For example, when the following case is encountered, it will loop 4691368 times, taking about 27 seconds. - offset =

Re: [PATCH] erofs: fix fsdax unavailability for chunk-based regular files

2023-07-11 Thread Gao Xiang
On 2023/7/11 14:21, Xin Yin wrote: DAX can be used to share page cache between VMs, reducing guest memory overhead. And chunk based data format is widely used for VM and container image. So enable dax support for it, make erofs better used for VM scenarios. Fixes: c5aa903a59db ("erofs: suppor