Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-29 Thread Al Viro
On Tue, Aug 29, 2023 at 08:43:31PM -0400, Jeff Layton wrote: > On Wed, 2023-08-30 at 01:02 +0100, Al Viro wrote: > > On Tue, Aug 29, 2023 at 06:58:47PM -0400, Jeff Layton wrote: > > > On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > > > > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wro

Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-29 Thread Jeff Layton
On Wed, 2023-08-30 at 01:02 +0100, Al Viro wrote: > On Tue, Aug 29, 2023 at 06:58:47PM -0400, Jeff Layton wrote: > > On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > > > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > > > > generic_fillattr just fills in the entire stat struct ind

Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-29 Thread Al Viro
On Tue, Aug 29, 2023 at 06:58:47PM -0400, Jeff Layton wrote: > On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > > > generic_fillattr just fills in the entire stat struct indiscriminately > > > today, copying data from the inode. Th

Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-29 Thread Jeff Layton
On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > > generic_fillattr just fills in the entire stat struct indiscriminately > > today, copying data from the inode. There is at least one attribute > > (STATX_CHANGE_COOKIE) that can have

Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-29 Thread Al Viro
On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > generic_fillattr just fills in the entire stat struct indiscriminately > today, copying data from the inode. There is at least one attribute > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > and we're looking at

Re: [PATCH v7 0/3] erofs-utils: introduce xattr name bloom filter

2023-08-29 Thread Gao Xiang
On Tue, Aug 29, 2023 at 10:55:01PM +0800, Jingbo Xu wrote: > changes since v6: > - patch 1: polish license disclaimer; tweak included headers (Gao Xiang) > - patch 2: drop unused `EROFS_XATTR_NAME_LEN_MAX`; polish commit message > (Gao Xiang) > - patch 3: add warning when failed to calculate hash

[PATCH v7 2/3] erofs-utils: update on-disk format for xattr name filter

2023-08-29 Thread Jingbo Xu
Let's keep in sync with kernel commit 3f339920175c ("erofs: update on-disk format for xattr name filter"). There are some commonly used extended attributes (n) and the total number of these is approximately 30. trusted.overlay.opaque trusted.overlay.redirect trusted.overla

[PATCH v7 3/3] erofs-utils: mkfs: enable xattr name filter

2023-08-29 Thread Jingbo Xu
Introduce "-Exattr-name-filter" option to enable the xattr name bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/config.h | 1 + include/erofs/internal.h | 1 + lib/xattr.c | 65 mkfs/main.c | 7 + 4 file

[PATCH v7 0/3] erofs-utils: introduce xattr name bloom filter

2023-08-29 Thread Jingbo Xu
changes since v6: - patch 1: polish license disclaimer; tweak included headers (Gao Xiang) - patch 2: drop unused `EROFS_XATTR_NAME_LEN_MAX`; polish commit message (Gao Xiang) - patch 3: add warning when failed to calculate hashbit; tweak code of assigning `header->h_name_filter` (Gao Xiang) c

[PATCH v7 1/3] erofs-utils: add xxh32 library

2023-08-29 Thread Jingbo Xu
Add xxh32 library which could be used by following xattr bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/xxhash.h | 27 + lib/Makefile.am| 3 +- lib/xxhash.c | 126 + 3 files changed, 155 insertions(+), 1 delet

Re: [PATCH v6 3/3] erofs-utils: mkfs: enable xattr name filter

2023-08-29 Thread Jingbo Xu
On 8/29/23 8:53 PM, Gao Xiang wrote: > > > On 2023/8/29 20:41, Jingbo Xu wrote: >> Introduce "-Exattr-name-filter" option to enable the xattr name bloom >> filter feature. >> >> Signed-off-by: Jingbo Xu >> --- >>   include/erofs/config.h   |  1 + >>   include/erofs/internal.h |  1 + >>   lib/

Re: [PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter

2023-08-29 Thread Jingbo Xu
On 8/29/23 8:49 PM, Gao Xiang wrote: > > > On 2023/8/29 20:41, Jingbo Xu wrote: >> The xattr name bloom filter feature is going to be introduced to speed >> up the negative xattr lookup, e.g. system.posix_acl_[access|default] >> lookup when running "ls -lR" workload. > > > I think you could

Re: [PATCH v7] erofs-utils: add support for fuse 2/3 lowlevel API

2023-08-29 Thread Gao Xiang
Hi Yiyan, Would you mind addressing the following comments? I think it's almost the time to formalize this: On 2023/8/26 17:25, Huang Jianan wrote: Hi Yiyan, Thanks for your work, I have some comments below, please check. On 2023/8/23 19:59, Li Yiyan wrote: Add support for the fuse low-level

Re: [PATCH v6 1/3] erofs-utils: add xxh32 library

2023-08-29 Thread Jingbo Xu
On 8/29/23 8:44 PM, Gao Xiang wrote: > > > On 2023/8/29 20:41, Jingbo Xu wrote: >> Add xxh32 library which could be used by following xattr bloom filter >> feature. >> >> Signed-off-by: Jingbo Xu >> --- >>   include/erofs/xxhash.h |  72 >>   lib/Makefile.am    |  

Re: [PATCH v6 3/3] erofs-utils: mkfs: enable xattr name filter

2023-08-29 Thread Gao Xiang
On 2023/8/29 20:41, Jingbo Xu wrote: Introduce "-Exattr-name-filter" option to enable the xattr name bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/config.h | 1 + include/erofs/internal.h | 1 + lib/xattr.c | 63

Re: [PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter

2023-08-29 Thread Gao Xiang
On 2023/8/29 20:41, Jingbo Xu wrote: The xattr name bloom filter feature is going to be introduced to speed up the negative xattr lookup, e.g. system.posix_acl_[access|default] lookup when running "ls -lR" workload. I think you could just say "Let's keep in sync with kernel commit <12-char

Re: [PATCH v6 1/3] erofs-utils: add xxh32 library

2023-08-29 Thread Gao Xiang
On 2023/8/29 20:41, Jingbo Xu wrote: Add xxh32 library which could be used by following xattr bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/xxhash.h | 72 lib/Makefile.am| 3 +- lib/xxhash.c | 125 ++

[PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter

2023-08-29 Thread Jingbo Xu
The xattr name bloom filter feature is going to be introduced to speed up the negative xattr lookup, e.g. system.posix_acl_[access|default] lookup when running "ls -lR" workload. There are some commonly used extended attributes (n) and the total number of these is approximately 30. truste

[PATCH v6 1/3] erofs-utils: add xxh32 library

2023-08-29 Thread Jingbo Xu
Add xxh32 library which could be used by following xattr bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/xxhash.h | 72 lib/Makefile.am| 3 +- lib/xxhash.c | 125 + 3 files changed, 199 inserti

[PATCH v6 0/3] erofs-utils: introduce xattr name bloom filter

2023-08-29 Thread Jingbo Xu
changes since v5: - patch 1: update distribution license - patch 3: rebase to the latest -dev branch changes since v4: - patch 3: the feature is refactored and implemented in a more cohesive way, that is, the hashbit is calculated in erofs_export_xattr_ibody(). For xattr_item in the long xattr

[PATCH v6 3/3] erofs-utils: mkfs: enable xattr name filter

2023-08-29 Thread Jingbo Xu
Introduce "-Exattr-name-filter" option to enable the xattr name bloom filter feature. Signed-off-by: Jingbo Xu --- include/erofs/config.h | 1 + include/erofs/internal.h | 1 + lib/xattr.c | 63 mkfs/main.c | 7 + 4 file

Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

2023-08-29 Thread Christian Brauner
> replacement) I think we can go ahead with the series as is. As you said > there will be some conflicts in btrfs and I've learned about f2fs conflicts > as well so I can rebase & repost the series on top of rc1 to make life > easier for you. That is be much appreciated. Thank you!