[xiang-erofs:dev] BUILD SUCCESS 227ed3562a9ab25cb526281fe99075e2d0c67143

2024-07-24 Thread kernel test robot
allnoconfig gcc-13.2.0 arc allyesconfig gcc-13.2.0 arc axs103_smp_defconfig gcc-13.2.0 arc defconfig gcc-13.2.0 arc randconfig-001-20240724 gcc-13.2.0 arc

Re: [PATCH] vfs: Fix potential circular locking through setxattr() and removexattr()

2024-07-24 Thread Jan Kara
On Tue 23-07-24 14:57:46, David Howells wrote: > Jan Kara wrote: > > > Well, it seems like you are trying to get rid of the dependency > > sb_writers->mmap_sem. But there are other places where this dependency is > > created, in particular write(2) path is a place where it would be very > >

Re: [PATCH] cachefiles: Fix non-taking of sb_writers around set/removexattr

2024-07-24 Thread David Howells
Fixes: 9ae326a69004 ("CacheFiles: A cache that backs onto a mounted filesystem")

[PATCH] cachefiles: Fix non-taking of sb_writers around set/removexattr

2024-07-24 Thread David Howells
Unlike other vfs_() calls, vfs_setxattr() and vfs_removexattr() don't take the sb_writers lock, so the caller should do it for them. Fix cachefiles to do this. Signed-off-by: David Howells cc: Christian Brauner cc: Gao Xiang cc: ne...@lists.linux.dev cc: linux-erofs@lists.ozlabs.org cc:

Re: [PATCH] vfs: Fix potential circular locking through setxattr() and removexattr()

2024-07-24 Thread David Howells
Jan Kara wrote: > > + error = strncpy_from_user(kname, name, sizeof(kname)); > > + if (error == 0 || error == sizeof(kname)) > > + error = -ERANGE; > > + if (error < 0) > > + return error; > > Missing fdput() here. Thanks. I think Christian is altering the patch to