Re: [PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-14 Thread Gao Xiang
On Fri, Oct 14, 2022 at 04:44:22PM +0800, Yue Hu wrote: > Hi Xiang, > > On Fri, 14 Oct 2022 10:15:27 +0800 > Gao Xiang wrote: > > > On Fri, Oct 14, 2022 at 09:48:46AM +0800, Yue Hu wrote: > > > On Thu, 13 Oct 2022 16:59:26 +0800 > > > Gao Xiang wrote: > > > > > > > Hi Yue, > > > > > > > > O

Re: [PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-14 Thread Yue Hu
Hi Xiang, On Fri, 14 Oct 2022 10:15:27 +0800 Gao Xiang wrote: > On Fri, Oct 14, 2022 at 09:48:46AM +0800, Yue Hu wrote: > > On Thu, 13 Oct 2022 16:59:26 +0800 > > Gao Xiang wrote: > > > > > Hi Yue, > > > > > > On Thu, Oct 13, 2022 at 12:00:11PM +0800, Yue Hu wrote: > > > > From: Yue Hu >

Re: [PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-13 Thread Gao Xiang
On Fri, Oct 14, 2022 at 09:48:46AM +0800, Yue Hu wrote: > On Thu, 13 Oct 2022 16:59:26 +0800 > Gao Xiang wrote: > > > Hi Yue, > > > > On Thu, Oct 13, 2022 at 12:00:11PM +0800, Yue Hu wrote: > > > From: Yue Hu > > > > > > We should do nothing in dedupe inserting when it's not configured. > > >

Re: [PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-13 Thread Yue Hu
On Thu, 13 Oct 2022 16:59:26 +0800 Gao Xiang wrote: > Hi Yue, > > On Thu, Oct 13, 2022 at 12:00:11PM +0800, Yue Hu wrote: > > From: Yue Hu > > > > We should do nothing in dedupe inserting when it's not configured. > > > > Signed-off-by: Yue Hu > > --- > > Thanks for the patch, do you obse

Re: [PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-13 Thread Gao Xiang
Hi Yue, On Thu, Oct 13, 2022 at 12:00:11PM +0800, Yue Hu wrote: > From: Yue Hu > > We should do nothing in dedupe inserting when it's not configured. > > Signed-off-by: Yue Hu > --- Thanks for the patch, do you observe some strange happening? IMO, If dedupe is not enabled, window_size will

[PATCH] erofs-utils: avoid unnecessary insert behavior when not deduplicating

2022-10-12 Thread Yue Hu
From: Yue Hu We should do nothing in dedupe inserting when it's not configured. Signed-off-by: Yue Hu --- lib/dedupe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dedupe.c b/lib/dedupe.c index 7962014..9cad905 100644 --- a/lib/dedupe.c +++ b/lib/dedupe.c @@ -99,7 +9