Re: [PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-10 Thread kernel test robot
://lore.kernel.org/r/20231109194821.1719430-1-wozizhi%40huawei.com patch subject: [PATCH -next V2] erofs: code clean up for function erofs_read_inode() config: i386-buildonly-randconfig-004-2023 (https://download.01.org/0day-ci/archive/2023/20231038.atx87gvv-...@intel.com/config) compiler: gcc-9

Re: [PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-09 Thread Zizhi Wo via Linux-erofs
在 2023/11/9 23:42, Gao Xiang 写道: On 2023/11/9 21:45, Zizhi Wo wrote: 在 2023/11/9 21:14, Gao Xiang 写道: Hi, On 2023/11/10 03:48, WoZ1zh1 wrote: Because variables "die" and "copied" only appear in case EROFS_INODE_LAYOUT_EXTENDED, move them from the outer space into this case. Also, call

Re: [PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-09 Thread Gao Xiang
On 2023/11/9 21:45, Zizhi Wo wrote: 在 2023/11/9 21:14, Gao Xiang 写道: Hi, On 2023/11/10 03:48, WoZ1zh1 wrote: Because variables "die" and "copied" only appear in case EROFS_INODE_LAYOUT_EXTENDED, move them from the outer space into this case. Also, call "kfree(copied)" earlier to avoid

Re: [PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-09 Thread Zizhi Wo via Linux-erofs
在 2023/11/9 21:14, Gao Xiang 写道: Hi, On 2023/11/10 03:48, WoZ1zh1 wrote: Because variables "die" and "copied" only appear in case EROFS_INODE_LAYOUT_EXTENDED, move them from the outer space into this case. Also, call "kfree(copied)" earlier to avoid double free in the "error_out" branch.

Re: [PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-09 Thread Gao Xiang
Hi, On 2023/11/10 03:48, WoZ1zh1 wrote: Because variables "die" and "copied" only appear in case EROFS_INODE_LAYOUT_EXTENDED, move them from the outer space into this case. Also, call "kfree(copied)" earlier to avoid double free in the "error_out" branch. Some cleanups, no logic changes.

[PATCH -next V2] erofs: code clean up for function erofs_read_inode()

2023-11-09 Thread WoZ1zh1 via Linux-erofs
Because variables "die" and "copied" only appear in case EROFS_INODE_LAYOUT_EXTENDED, move them from the outer space into this case. Also, call "kfree(copied)" earlier to avoid double free in the "error_out" branch. Some cleanups, no logic changes. Signed-off-by: WoZ1zh1 --- fs/erofs/inode.c |