Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Andrew Morton
On Wed, 06 Sep 2006 20:04:27 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > I've been unable to reproduce this crash, btw. Is there some magic > > incantation apat from running `fsx-linux'? > > > All I do is on a single 1k filesystem, run 4 copies of fsx (on 4 > different files, ofcour

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Badari Pulavarty
Andrew Morton wrote: On Wed, 6 Sep 2006 19:27:33 +0200 Jan Kara <[EMAIL PROTECTED]> wrote: Ugh! Are you sure? For this path the buffer must be attached (only) to the running transaction. But then how the commit code comes to it? Somebody would have to even manage to refile the buffer from

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Andrew Morton
On Wed, 6 Sep 2006 19:27:33 +0200 Jan Kara <[EMAIL PROTECTED]> wrote: > Ugh! Are you sure? For this path the buffer must be attached (only) to > the running transaction. But then how the commit code comes to it? > Somebody would have to even manage to refile the buffer from the > committing tran

ext4 devel interlock meeting minutes (Sept. 6, 2006)

2006-09-06 Thread Dave Kleikamp
Disclaimer: I didn't take notes during the call and every time I get back to these minutes, I get interrupted by something else, so forgive me if I leave anything important out. - Mingming is working on rebasing the ext4 patches on the -mm tree, which should closely resemble the ext3 code that wi

Re: [PATCH] ext3_getblk should handle HOLE correctly

2006-09-06 Thread Dave Kleikamp
On Wed, 2006-09-06 at 10:39 -0700, Badari Pulavarty wrote: > Index: linux-2.6.18-rc5/fs/ext3/inode.c > === > --- linux-2.6.18-rc5.orig/fs/ext3/inode.c 2006-08-27 20:41:48.0 > -0700 > +++ linux-2.6.18-rc5/fs/ext3/inode.c

[PATCH] ext3_getblk should handle HOLE correctly

2006-09-06 Thread Badari Pulavarty
Hi Andrew, Its been reported that ext3_getblk() is not doing the right thing and triggering following WARN(): BUG: warning at fs/ext3/inode.c:1016/ext3_getblk() ext3_getblk+0x98/0x2a6 md_wakeup_thread +0x26/0x2a ext3_bread+0x1f/0x88 ext3_quota_read+0x136/0x1ae v1_read_dqblk+0x61/0xac

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Jan Kara
> On Wed, 2006-09-06 at 18:27 +0200, Jan Kara wrote: > > > But my debug clearly shows that we are clearing the buffer, while > > > we haven't actually submitted to ll_rw_block() code. (I added "track" > > > flag to bh and set it in journal_commit_transaction() when we add > > > them to wbuf[] and c

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Badari Pulavarty
On Wed, 2006-09-06 at 18:27 +0200, Jan Kara wrote: > > On Wed, 2006-09-06 at 17:34 +0200, Jan Kara wrote: > > > > On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > > > > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > > > > itself (like this patch) ? > > > > >

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Jan Kara
> On Wed, 2006-09-06 at 18:27 +0200, Jan Kara wrote: > > > > > > But my debug clearly shows that we are clearing the buffer, while > > > we haven't actually submitted to ll_rw_block() code. (I added "track" > > > flag to bh and set it in journal_commit_transaction() when we add > > > them to wbuf[

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Badari Pulavarty
On Wed, 2006-09-06 at 18:27 +0200, Jan Kara wrote: > > On Wed, 2006-09-06 at 17:34 +0200, Jan Kara wrote: > > > > On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > > > > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > > > > itself (like this patch) ? > > > > >

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Jan Kara
> On Wed, 2006-09-06 at 17:34 +0200, Jan Kara wrote: > > > On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > > > itself (like this patch) ? > > > > Actually that part of commit code needs rewrite anyway (and a

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Badari Pulavarty
On Wed, 2006-09-06 at 17:34 +0200, Jan Kara wrote: > > On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > > itself (like this patch) ? > > > Actually that part of commit code needs rewrite anyway (and after that >

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Jan Kara
> On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > itself (like this patch) ? > > Actually that part of commit code needs rewrite anyway (and after that > > rewrite you get rid of ll_rw_block()) because of other prob

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Badari Pulavarty
On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > Hi, > > > On Fri, 2006-09-01 at 10:18 -0700, Andrew Morton wrote: > > > > > > Kernel BUG at fs/buffer.c:2791 > > > > > > invalid opcode: [1] SMP > > > > > > > > > > > > Its complaining about BUG_ON(!buffer_mapped(bh)). > > > > Here is t

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-06 Thread Jan Kara
Hi, > On Fri, 2006-09-01 at 10:18 -0700, Andrew Morton wrote: > > > > > Kernel BUG at fs/buffer.c:2791 > > > > > invalid opcode: [1] SMP > > > > > > > > > > Its complaining about BUG_ON(!buffer_mapped(bh)). > > Here is the change that seems to cause the problem. Jana Kara > introduced a n

Re: [Ext2-devel] rfc: [patch 3/6] more e2fsprogs fixes

2006-09-06 Thread Andreas Dilger
On Sep 04, 2006 16:59 +0200, Alexandre Ratchov wrote: > in order tu use 48bit adressing, we have to use larger block groups (because > all group descriptors must fit in one block group). So we'll need 16bit > "_hi" bits for blocks_count, inodes_count and perhaps used_dirs_count. And > this leaves