Re: [PATCH] ext3_getblk should handle HOLE correctly

2006-09-07 Thread Andrew Morton
On Wed, 06 Sep 2006 10:39:06 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: Hi Andrew, Its been reported that ext3_getblk() is not doing the right thing and triggering following WARN(): BUG: warning at fs/ext3/inode.c:1016/ext3_getblk() c01c5140 ext3_getblk+0x98/0x2a6 c03b2806

[RFC][1/4] ext2/3/4: enlarge blocksize

2006-09-07 Thread sho
Hi all, On July 7, 2006, sho wrote: On Jun 29, 2006, Andreas wrote: On Jun 28, 2006 17:50 +0200, Johann Lombardi wrote: ext2/ext3_dir_entry_2 has a 16-bit entry(rec_len) and it would overflow with 64KB blocksize. This patch prevent from overflow by limiting rec_len to 65532.

[RFC][2/4] ext2: fix rec_len overflow

2006-09-07 Thread sho
[2/4] ext2: fix rec_len overflow - prevent rec_len from overflow with 64KB blocksize Signed-off-by: Takashi Sato [EMAIL PROTECTED] --- diff -upNr -X linux-2.6.18-rc4-mingming/Documentation/dontdiff linux-2.6.18-rc4-mingming/fs/ext2/dir.c

[RFC][3/4] ext3: fix rec_len overflow

2006-09-07 Thread sho
[3/4] ext3: fix rec_len overflow - prevent rec_len from overflow with 64KB blocksize Signed-off-by: Takashi Sato [EMAIL PROTECTED] --- diff -upNr -X linux-2.6.18-rc4-mingming/Documentation/dontdiff linux-2.6.18-rc4-mingming/fs/ext3/dir.c

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-07 Thread Badari Pulavarty
Jan Kara wrote: Ugh! Are you sure? For this path the buffer must be attached (only) to the running transaction. But then how the commit code comes to it? Somebody would have to even manage to refile the buffer from the committing transaction to the running one while the buffer is in wbuf[].