Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > +void __trigger_all_cpu_backtrace(void) > +{ > + backtrace_mask = CPU_MASK_ALL; > +} i'd suggest cpu_online_map, i also added a busy-loop to wait for the backtrace_mask to go back to 0. That way we get a consistent dump all across. (as the NMI w

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > + if (cpu_isset(cpu, backtrace_mask)) { > + cpu_clear(cpu, backtrace_mask); > + printk("NMI backtrace for cpu %d\n", cpu); > + dump_stack(); > + } yeah. There's just one issue: this will mix all the printks

Re: Bug#389772: e2fsprogs: e2fsck produces broken htree on ppc

2006-09-29 Thread Theodore Tso
On Fri, Sep 29, 2006 at 11:15:47AM -0600, Andreas Dilger wrote: > Hmm, except isn't the problem ALREADY that PPC is broken with 8-bit > chars and htree? That's what started this problem in the first place. > Running e2fsck allowed the kernel htree code to find the file, when > it could not otherwi

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Andrew Morton
On Fri, 29 Sep 2006 21:54:30 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Friday 29 September 2006 21:18, Ingo Molnar wrote: > > > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > gad, there have been so many all-CPU-backtrace patches over the years. > > > > > > > > > > > > Ingo, do

Re: ext4 kernel patches against linux-2.6.18-mm1

2006-09-29 Thread Dave Kleikamp
On Tue, 2006-09-26 at 18:43 +0200, Alexandre Ratchov wrote: > hi, > > i've updated the ext4 kernel patches to 2.6.18-mm1. I've just done some > reordering/simplifications and fixed some minor bugs: > > - merge all 64bit "metadata" patches together > > - fix false-positive format warnings in ba

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Andi Kleen
On Friday 29 September 2006 21:18, Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > gad, there have been so many all-CPU-backtrace patches over the years. > > > > > > > > Ingo, do you think that's something which we shuld have in the > > spinlock debugging code? A trac

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > gad, there have been so many all-CPU-backtrace patches over the years. > > > > Ingo, do you think that's something which we shuld have in the > spinlock debugging code? A trace to let us see which CPU is holding > that lock, and where from? I gu

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Andrew Morton
On Fri, 29 Sep 2006 09:11:46 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > On Fri, 2006-09-29 at 11:02 +0200, Jan Kara wrote: > ... > > > >+} > > > >+/* Someone already cleaned up the buffer? */ > > > >+if (!buffer_jbd(bh) > > > >+

Re: Newbie ext2 forensics question...

2006-09-29 Thread Andreas Dilger
On Sep 29, 2006 04:47 +, Dave Edwards wrote: > I'm trying to tune a linux system to spin down its (ext2-formatted) disk when > the system is idle. I've worked down to two problematic applications that > periodically spin up the disk, even though the (tiny) file they're writing is > (allegedly)

Re: Bug#389772: e2fsprogs: e2fsck produces broken htree on ppc

2006-09-29 Thread Andreas Dilger
On Sep 28, 2006 21:08 -0400, Theodore Tso wrote: > On Wed, Sep 27, 2006 at 02:22:51PM +0200, Jörg Sommer wrote: > > Package: e2fsprogs > > Version: 1.39-1 > > Severity: important > > > > you set the compiler option -fsigned-char, but on PowerPC the default is > > unsigned char. This makes the ker

Re: [patch 003/152] jbd: fix commit of ordered data buffers

2006-09-29 Thread Badari Pulavarty
On Fri, 2006-09-29 at 11:02 +0200, Jan Kara wrote: ... > > >+ } > > >+ /* Someone already cleaned up the buffer? */ > > >+ if (!buffer_jbd(bh) > > >+ || jh->b_transaction != commit_transaction > > >+ || jh->b_jlist != BJ_SyncData) { > > >

Re: Newbie ext2 forensics question...

2006-09-29 Thread Theodore Tso
On Fri, Sep 29, 2006 at 04:47:38AM +, Dave Edwards wrote: > I'm trying to tune a linux system to spin down its (ext2-formatted) disk when > the system is idle. I've worked down to two problematic applications that > periodically spin up the disk, even though the (tiny) file they're writing is >

Re: Newbie ext2 forensics question...

2006-09-29 Thread Peter Kjellström
On Friday 29 September 2006 06:47, Dave Edwards wrote: > ... > Is there any way to work back from block to inode to (hopefully) location > in the directory structure this is happening? For some reason, I don't get from man debugfs: icheck block ... Print a listing of the inodes which