i_version_2_ext4_specific_code

2007-02-15 Thread Andrew Morton
This: ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/2.6.20-ext4-1/broken-out/i_version_2_ext4_specific_code has 100% broken whitespace: it uses spaces where there should be hard tabs. Please let's not merge anything which does that. - To unsubscribe from this list: send the

booked-page-flag.patch

2007-02-15 Thread Andrew Morton
Sorry, we're seriously, seriously, seriously short on flags in the page struct and this patch is going to need one heck of a good case for it to be acceptable. Even then, we should put a lot of effort into finding some way of avoiding adding that page flag. One option might be to add a new

i_version_3_ext4_user_interface.patch

2007-02-15 Thread Andrew Morton
ia64 allmodconfig gives: fs/stat.c: In function `cp_new_stat': fs/stat.c:234: error: structure has no member named `st_i_version' I'll drop the ext4 tree. - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: booked-page-flag.patch

2007-02-15 Thread Eric Sandeen
Andrew Morton wrote: Sorry, we're seriously, seriously, seriously short on flags in the page struct and this patch is going to need one heck of a good case for it to be acceptable. This was for the delayed allocation patchset, right; and by managing this at the page level that means we can't

Re: [RFC] [PATCH 1/1] nanosecond timestamps

2007-02-15 Thread Theodore Tso
On Mon, Feb 05, 2007 at 11:09:16PM -0500, Theodore Tso wrote: yet, but one quick comment; the patch looks like it got line-wrapped by your mail agent (looks like you're using Evolution 2.0). Could you send it as a text/plain attachment, or otherwise fix your mailer to not wrap your patches?

Re: booked-page-flag.patch

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 20:30:43 +0300 Alex Tomas [EMAIL PROTECTED] wrote: Eric Sandeen (ES) writes: ES Andrew Morton wrote: Sorry, we're seriously, seriously, seriously short on flags in the page struct and this patch is going to need one heck of a good case for it to be acceptable.

Re: booked-page-flag.patch

2007-02-15 Thread Alex Tomas
Eric Sandeen (ES) writes: ES Andrew Morton wrote: Sorry, we're seriously, seriously, seriously short on flags in the page struct and this patch is going to need one heck of a good case for it to be acceptable. ES This was for the delayed allocation patchset, right; and by managing ES

Re: booked-page-flag.patch

2007-02-15 Thread Andrew Morton
On Fri, 16 Feb 2007 00:07:55 +0300 Alex Tomas [EMAIL PROTECTED] wrote: Andrew Morton (AM) writes: AM If the page doesn't have buffer-heads, set PG_private and clear page-private AM If the page does have buffer_heads, use BH_Delay. I did exactly this way in the first version, but

data=journal busted

2007-02-15 Thread Andrew Morton
I have a report from a google person who just did some basic power-it-off-during-a-write testing on 2.6.20's ext3. ordered-data is OK, but data=journal came back with crap in the file data. Is anyone doing any formal recovery stress-testing? I suspect we should resurrect and formalise my old

Re: booked-page-flag.patch

2007-02-15 Thread Andrew Morton
On Fri, 16 Feb 2007 10:30:39 +0300 Alex Tomas [EMAIL PROTECTED] wrote: Andrew Morton (AM) writes: - get_block(with BH_Delay) can be used to signal filesystem that no actual allocation is required. so, aware filesystem can just reserve space. then - writepages() should walk through

Re: booked-page-flag.patch

2007-02-15 Thread Alex Tomas
Andrew Morton (AM) writes: AM Well, one could just assume that the page has no disk mapping and go and AM make the space reservation. Things will work out OK when we come to do AM writepage(). AM Or one could do both: call get_block() only if the page was inside i_size. well, even so we