[PATCH] Correction to check_filetype()

2007-02-21 Thread Kalpak Shah
Hi, If the mode of a directory gets corrupted, check_filetype() makes wrong decisions for all its sub-directories. For example, using debugfs we can corrupt the mode of a directory to 0140755 (i.e. a socket). e2fsck will set the filetype of all its subdirectories as 6 (filetype for socket).

ext3 not writing inode flags

2007-02-21 Thread Jan Kara
Hello, I've noticed that if e. g. S_IMMUTABLE flag is set on an inode, ext3 does not propagate it to its inode flags on write. This also leads to the situation that lsattr reports no flag set but the file is in fact immutable. Would a fix be accepted? Actually, the quota code is the only

Re: [PATCH] Correction to check_filetype()

2007-02-21 Thread Kalpak Shah
Hi, The other issue this brings up is maybe pass1 should be checking whether it is the inode mode that is corrupted (by trying to verify block[0] has . and ..in it) instead of truncating off those blocks. This would actually be a redundant check as pass2 would also make the same check. We

+ ext-ea-block-reference-count-racing-fix.patch added to -mm tree

2007-02-21 Thread akpm
The patch titled ext[34] EA block reference count racing fix has been added to the -mm tree. Its filename is ext-ea-block-reference-count-racing-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See

+ ext-ea-block-reference-count-racing-fix-fix.patch added to -mm tree

2007-02-21 Thread akpm
The patch titled ext-ea-block-reference-count-racing-fix-fix has been added to the -mm tree. Its filename is ext-ea-block-reference-count-racing-fix-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See