Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Vasily Averin
Eric Sandeen wrote: > Vasily Averin wrote: >> Bad inode can live some time, ext3_unlink can add it to orphan list, but >> ext3_delete_inode() do not deleted this inode from orphan list. As result >> we can have orphan list corruption detected in ext3_destroy_inode(). > > Ah, I see - so you have c

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-04 Thread Vasily Averin
Eric Sandeen wrote: > Vasily Averin wrote: >> Customers claims to ext3-related errors, investigation showed that ext3 >> orphan list has been corrupted and have the reference to non-ext3 inode. >> The following debug helps to understand the reasons of this issue. > > Vasily, does your customer hav

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Christoph Hellwig
On Tue, Jun 05, 2007 at 10:11:12AM +0400, Vasily Averin wrote: > >>return d_splice_alias(inode, dentry); > >> } > > Seems reasonable. So this prevents the bad inodes from getting onto the > > orphan list in the first place? > > make_bad_inode() is called from ext3_read_inode() that is called

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Vasily Averin
Andrew Morton wrote: > On Mon, 04 Jun 2007 09:19:10 +0400 Vasily Averin <[EMAIL PROTECTED]> wrote: >> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c >> index 9bb046d..e3ac8c3 100644 >> --- a/fs/ext3/namei.c >> +++ b/fs/ext3/namei.c >> @@ -1019,6 +1019,11 @@ static struct dentry *ext3_lookup(struct

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 19:03 -0700, Andrew Morton wrote: > What caused those inodes to be bad, anyway? Memory allocation failures? This can happen if e.g. NFS has a stale file handle - it will look up the inode by inum, but ext3_read_inode() will create a bad inode due to i_nlink = 0. Cheers, Andreas

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Eric Sandeen
Vasily Averin wrote: After ext3 orphan list check has been added into ext3_destroy_inode() (please see my previous patch) the following situation has been detected: EXT3-fs warning (device sda6): ext3_unlink: Deleting nonexistent file (37901290), 0 Inode 0101a15b7840: orphan list check fa

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-04 Thread Eric Sandeen
Vasily Averin wrote: Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue. Vasily, does your customer have this patch in place? http:/

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 09:19:10 +0400 Vasily Averin <[EMAIL PROTECTED]> wrote: > After ext3 orphan list check has been added into ext3_destroy_inode() (please > see my previous patch) the following situation has been detected: > EXT3-fs warning (device sda6): ext3_unlink: Deleting nonexistent file

Re: [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 09:18:55 +0400 Vasily Averin <[EMAIL PROTECTED]> wrote: > Customers claims to ext3-related errors, investigation showed that ext3 > orphan list has been corrupted and have the reference to non-ext3 inode. The > following debug helps to understand the reasons of this issue. >

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 16:01 -0700, Mingming Cao wrote: > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more > than 32bit block sizes during mount time. This ensure proper record > lenth when writing to the journal. > > Signed-off-by: Mingming Cao <[EMAIL PROTECTED]> > Signed-off-by: Jos

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Mingming Cao
On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote: > On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: > > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more > > than 32bit block sizes during mount time. This ensure proper record > > lenth when writing to the journal. > > >

Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Andreas Dilger
On Jun 04, 2007 11:32 -0500, Jose R. Santos wrote: > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more > than 32bit block sizes during mount time. This ensure proper record > lenth when writing to the journal. > > Signed-off-by: Jose R. Santos <[EMAIL PROTECTED]> > --- > fs/ext4

[RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

2007-06-04 Thread Jose R. Santos
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos <[EMAIL PROTECTED]> --- fs/ext4/super.c | 11 +++ 1 file changed, 11 insertions(+) In

Re: Failures in e2fsprogs-1.39-tyt3 'make check'

2007-06-04 Thread Kirk True
Hi Theodore, > > Sorry if this is a documented, known issue. I'm just being paranoid > and > > don't want to do a 'make install' if it will hose up the box. > > Yes, it's known. Note that e2fsprogs 1.39-tyt3 is really only meant > for ext4 developers. If you're not trying to use ext4 (and it's

Re: Failures in e2fsprogs-1.39-tyt3 'make check'

2007-06-04 Thread Theodore Tso
On Mon, Jun 04, 2007 at 01:18:23AM -0700, Kirk True wrote: > Hi all, > > I'm getting some errors in the 'make check' step when building > e2fsprogs-1.39-tyt3. Many of the errors look to be as a result of > missing image files, for example: > > f_orphan_dotdot_ft: filetype of .. in orphaned d

Failures in e2fsprogs-1.39-tyt3 'make check'

2007-06-04 Thread Kirk True
Hi all, I'm getting some errors in the 'make check' step when building e2fsprogs-1.39-tyt3. Many of the errors look to be as a result of missing image files, for example: f_orphan_dotdot_ft: filetype of .. in orphaned directories: ../../tests/run_e2fsck: line 43: ../../tests/f_orph