Hi,
The present e2fsck code checks the inode, per field basis. It
doesn't take into consideration to total sanity of the inode. This may
cause e2fsck turning a garbage inode into a sane inode.
The following patch adds a heuristics to detect the degree of badness
of an inode. icount
Oops
On Thu, 2007-06-07 at 15:12 +0530, Girish Shilamkar wrote:
Hi,
The present e2fsck code checks the inode, per field basis. It
doesn't take into consideration to total sanity of the inode. This may
cause e2fsck turning a garbage inode into a sane inode.
The following patch
Theodore Tso wrote:
On Wed, Jun 06, 2007 at 03:32:27PM +0530, Aneesh Kumar K.V wrote:
If we allow to change the block size in between that would mean the
records that we store in the tdb database will be of variable size (
different block sizes). That would also add all the code/complexity
On Jun 06, 2007 14:18 +0100, Mark Knibbs wrote:
This is a follow-up to my previous message. The bug is also present in
ext3, and applies to partitions with 2K blocks and (at least in part) to
those with 4K blocks. There is also another issue, which may well be a bug
in e2fsck.
Could you
ext[234]_get_group_desc only sets the bh argument if it is non-null,
and several callers pass in a bh which is not subsequently used -
it may as well be NULL.
Compiled booted lightly tested.
Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
Index: linux-2.6.22-rc3/fs/ext3/ialloc.c
ext2's find_group_dir tests whether best_desc is not set and if
so returns -1. But if it was not set, best_group was not set either,
and it was initialized to -1. So may as well just return best_group.
This matches ext3/4 too.
In find_group_orlov, best_desc is updated in a loop and eventually
Hi,
[Apologies if this reply doesn't thread correctly.]
Andreas Dilger wrote:
Could you please clarify what the particular defect is that you are
looking at? Presumably it is not just that there is an upper limit on the
size of a file?
No. It seems there are some deficiencies in ext2/3's
The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but
create_proc_entry() does not do lookups on file names with more that one
directory deep. This causes the entry creation to fail and hence, no proc
file is created. This patch moves the file to /proc/jbd2-degug.
The file