Re: [BUG] fs/buffer.c:1821 in 2.6.22-rc4-mm2

2007-06-11 Thread Andrew Morton
On Sun, 10 Jun 2007 17:57:14 +0200 Eric Sesterhenn / Snakebyte [EMAIL PROTECTED] wrote: hi, i got the following BUG while running the syscalls.sh from ltp-full-20070531 on an ext3 partition, it is easily reproducible for me [ 476.338068] [ cut here ] [

Re: Patch to support LUKS UUIDs in libblkid

2007-06-11 Thread Karsten Hopp
Theodore Tso schrieb: In addition to the comments already posted: +/* check it manually as using LUKS_read_phdr from libcryptsetup + * prints too many warnings if it isn't a luks partition and would add a + * dependency on the lib */ +static int probe_luks(struct blkid_probe *probe, +

[RFC][PATCH 0/12] e2fsprogs: add 64-bit support

2007-06-11 Thread Valerie Clement
Hi Ted, Here is the new version of our e2fsprogs patches to add the 64-bit support in the e2fsprogs tools. First, I introduced a new compilation option to build e2fsprogs utilities for ext4 filesytems and not break backwards compatiblity with ext2/3 filesystems. So most of the new code

[RFC][PATCH 1/12] new ext4 group desc struct in e2fsprogs

2007-06-11 Thread Valerie Clement
A different groups descriptor structure was introduced for ext4 filesystems. This patch handles that. debugfs/debugfs.c|9 + debugfs/set_fields.c |4 e2fsck/super.c |4 lib/ext2fs/closefs.c |5 + lib/ext2fs/ext2fs.h |8

[RFC][PATCH 2/12] add new macro EXT2_DESC_PER_BLOCK in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch introduces a new macro EXT2_DESC_PER_BLOCK to calculate the number of group descriptors per block as two different structures are defined. lib/ext2fs/closefs.c|2 +- lib/ext2fs/ext2_fs.h|4 +++- lib/ext2fs/initialize.c |2 +- lib/ext2fs/openfs.c |4 ++--

[RFC][PATCH 3/12] new badblocks interface in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch introduces new badblocks list functions for ext4 filesystems which use the new type blk64_t. badblocks.c | 471 +--- ext2fs.h| 28 ++- ext2fsP.h | 13 + freefs.c| 19 -- 4 files changed, 423 insertions(+), 108

[RFC][PATCH 4/12] convert some block types in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch converts some int or unsigned int block number definitions to blk_t type. Most conversions are necessary for 64-bit porting. debugfs/debugfs.c | 12 +--- debugfs/logdump.c | 10 +- e2fsck/super.c |3 ++- lib/e2p/e2p.h |2 +-

[RFC][PATCH 5/12] new bitmaps interface in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch introduces new bitmap interface for ext4 filesystems which uses the new type blk64_t. bitmaps.c | 152 +- bitops.c | 36 ++ bitops.h | 29 +++ ext2fs.h | 25 ++ 4 files changed, 229

[RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch contains the changes to handle 64-bit block numbers stored in group descriptor structure. debugfs/debugfs.c |9 +++ debugfs/logdump.c |4 +-- e2fsck/pass1.c| 50 ++- e2fsck/pass1b.c | 10

[RFC][PATCH 8/12] 48-bit extents in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch contains the changes to support 48-bit block numbers in extents. This patch is not complete, the new function block_iterate_extents() was not updated. e2fsck/pass1.c| 15 +-- lib/ext2fs/bmap.c |6 +++--- lib/ext2fs/ext3_extents.h | 30

[RFC][PATCH 9/12] indirect block type conversion in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch converts the indirect block definitions from blkt_t type to __u32. e2fsck/pass1.c |2 - lib/ext2fs/block.c | 71 ++--- lib/ext2fs/ext2fs.h|4 +- lib/ext2fs/ind_block.c |4 +- lib/ext2fs/inode.c |4 +-

[RFC][PATCH 10/12] add new mkfs option to create ext4 filesystems

2007-06-11 Thread Valerie Clement
This patch adds a new option to mkfs to allow creating ext4 filesystem. lib/ext2fs/ext2_fs.h|6 ++ lib/ext2fs/initialize.c |1 + misc/mke2fs.c | 18 -- 3 files changed, 23 insertions(+), 2 deletions(-) Index: e2fsprogs-1.39-tyt3-v6/misc/mke2fs.c

[RFC][PATCH 11/12] convert blk_t to 64-bit for ext4 FS in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch converts blk_t type to __u64 when compiling code with _EXT4FS_ option. Force the 64-bit feature when the filesystem is greater than 2**32 blocks. lib/ext2fs/ext2_fs.h |3 ++- lib/ext2fs/ext2fs.h | 15 +++ misc/mke2fs.c| 12 +++- 3 files changed,

[RFC][PATCH 12/12] 48-bit block number for ACL in e2fsprogs

2007-06-11 Thread Valerie Clement
This patch is intended to contain the changes to support 48-bit block numbers for ACL. For now, it only contains modifications in the inode structure. It has to be completed. ext2_fs.h | 10 ++ swapfs.c |6 -- 2 files changed, 10 insertions(+), 6 deletions(-) Index:

Re: [RFC][PATCH 4/12] convert some block types in e2fsprogs

2007-06-11 Thread Jose R. Santos
On Mon, 11 Jun 2007 18:42:28 +0200 Valerie Clement [EMAIL PROTECTED] wrote: This patch converts some int or unsigned int block number definitions to blk_t type. Most conversions are necessary for 64-bit porting. What about unsigned long? There are various places where block is represented by

Re: [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option.

2007-06-11 Thread Mingming Cao
On Fri, 2007-06-08 at 22:57 -0500, Jose R. Santos wrote: On Fri, 8 Jun 2007 01:08:12 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do

Re: [RFC][PATCH 0/12] e2fsprogs: add 64-bit support

2007-06-11 Thread Andreas Dilger
On Jun 11, 2007 18:41 +0200, Valerie Clement wrote: This patchset is also not complete: TODO: - update code under ext2ed/, This code should just be removed entirely. It is dangerous to use, and by including it in e2fsprogs it lends a false sense of credibility to the code. Hopefully most

Re: [RFC][PATCH 2/12] add new macro EXT2_DESC_PER_BLOCK in e2fsprogs

2007-06-11 Thread Andreas Dilger
On Jun 11, 2007 18:42 +0200, Valerie Clement wrote: +#define EXT2_DESC_PER_BLOCK(s) (EXT2_BLOCK_SIZE(s) / \ + ((EXT2_SB(s)-s_feature_incompat EXT4_FEATURE_INCOMPAT_64BIT) ? \ + sizeof(struct ext4_group_desc) : sizeof(struct ext2_group_desc))) This should actually use

Re: [BUG] fs/buffer.c:1821 in 2.6.22-rc4-mm2

2007-06-11 Thread Nick Piggin
Andrew Morton wrote: On Sun, 10 Jun 2007 17:57:14 +0200 Eric Sesterhenn / Snakebyte [EMAIL PROTECTED] wrote: hi, i got the following BUG while running the syscalls.sh from ltp-full-20070531 on an ext3 partition, it is easily reproducible for me [ 476.338068] [ cut here