random ext3 image bugs

2007-07-10 Thread Michal Piotrowski
Hi all, My insane file system test triggered a few bugs in ext3 image. Anyone interested? [40859.103232] SELinux: initialized (dev loop7, type ext3), uses xattr [40859.119575] EXT3-fs error (device loop7): ext3_xattr_block_get: inode 757: bad block 4829 [40859.129837] inode_doinit_with_dentry:

Random corruption test for e2fsck

2007-07-10 Thread Kalpak Shah
Hi, This is a random corruption test which can be included in the e2fsprogs regression tests. It does the following: 1) Create an test fs and format it with ext2/3/4 and random selection of features. 2) Mount it and copy data into it. 3) Move around the blocks of the filesystem randomly causing co

Re: ext4-patch-queue rebased to 2.6.22

2007-07-10 Thread Amit K. Arora
On Mon, Jul 09, 2007 at 01:37:56PM -0400, Theodore Ts'o wrote: > So we're just waiting for Amit to make the minor on-disk format change > Andreas suggested before we push to Linus. I have commited following changes to the ext4 patch queue: 1. Updated ext4-fallocate-1-syscall_i386_amd64_ppc to add

Re: Random corruption test for e2fsck

2007-07-10 Thread Theodore Tso
On Tue, Jul 10, 2007 at 06:37:40PM +0530, Kalpak Shah wrote: > Hi, > > This is a random corruption test which can be included in the e2fsprogs > regression tests. > 1) Create an test fs and format it with ext2/3/4 and random selection of > features. > 2) Mount it and copy data into it. This requ

Re: Random corruption test for e2fsck

2007-07-10 Thread Eric Sandeen
Theodore Tso wrote: >> 5) If the test went by without any errors the test image is deleted and >> in case of any errors the user is notified that the log of this test run >> should be mailed to linux-ext4@ and the image should be preserved. > > I certainly like the general concept!! > > I wonder

Re: random ext3 image bugs

2007-07-10 Thread Eric Sandeen
Michal Piotrowski wrote: > Hi all, > > My insane file system test triggered a few bugs in ext3 image. Anyone > interested? Not yet; all the errors below are ext3 properly coping with the corrupted image, no? But if you can make it oops, that's more interesting. :) -Eric > [40859.103232] SELi

Re: Random corruption test for e2fsck

2007-07-10 Thread Eric Sandeen
Kalpak Shah wrote: > Hi, > > This is a random corruption test which can be included in the e2fsprogs > regression tests. It does the following: > 1) Create an test fs and format it with ext2/3/4 and random selection of > features. > 2) Mount it and copy data into it. > 3) Move around the blocks of

Initial results of FLEX_BG feature.

2007-07-10 Thread Jose R. Santos
Hi folks, I've started playing with the FLEX_BG feature (for now packing of block group metadata closer together) and started doing some preliminary benchmarking to see if the feature is worth pursuing. I chose an FFSB profile that does single threaded small creates and writes and then does an fsy

Re: ext4-patch-queue rebased to 2.6.22

2007-07-10 Thread Andreas Dilger
On Jul 10, 2007 20:24 +0530, Amit K. Arora wrote: > On Mon, Jul 09, 2007 at 01:37:56PM -0400, Theodore Ts'o wrote: > > So we're just waiting for Amit to make the minor on-disk format change > > Andreas suggested before we push to Linus. > > 2. Added a new patch ext4-fallocate-8-new-ondisk-format

block groups with no inode tables

2007-07-10 Thread Jose R. Santos
Hi folks, As I play with the allocation of the metadata for the FLEX_BG feature, it seems that we could benefit from having block groups with no inode tables. Right now we allocate one inode table per bg base on the inode_blocks_per_group. For FLEX_BG though, it would make more sense to have a l

Re: block groups with no inode tables

2007-07-10 Thread coly li
Hi, once we decide to do this, how about storing inode inside the directory ? IMHO, the latter one is more attractive :-) Coly 在 2007-07-10二的 12:12 -0500,Jose R. Santos写道: > Hi folks, > > As I play with the allocation of the metadata for the FLEX_BG feature, > it seems that we could benefit fro

Re: block groups with no inode tables

2007-07-10 Thread Dave Kleikamp
On Wed, 2007-07-11 at 01:30 +0800, coly li wrote: > Hi, once we decide to do this, how about storing inode inside the > directory ? Which directory? > IMHO, the latter one is more attractive :-) Sounds like a mess to me. Consider ln and mv. > Coly -- David Kleikamp IBM Linux Technology Cente

ext2 reservations (Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Alexey Dobriyan
> ext2-reservations.patch > > Still needs decent testing. Was this oops silently fixed? http://lkml.org/lkml/2007/3/2/138 2.6.21-rc2-mm1: EIP is at ext2_discard_reservation+0x1c/0x52 I still have that ext2 partition backed up. - To unsubscribe from this list: send the line "unsubscribe linux-e

Re: ext4-patch-queue rebased to 2.6.22

2007-07-10 Thread Amit K. Arora
On Tue, Jul 10, 2007 at 11:09:39AM -0600, Andreas Dilger wrote: > On Jul 10, 2007 20:24 +0530, Amit K. Arora wrote: > > On Mon, Jul 09, 2007 at 01:37:56PM -0400, Theodore Ts'o wrote: > > > So we're just waiting for Amit to make the minor on-disk format change > > > Andreas suggested before we push

Re: block groups with no inode tables

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 12:40 -0500, Dave Kleikamp wrote: > On Wed, 2007-07-11 at 01:30 +0800, coly li wrote: > > Hi, once we decide to do this, how about storing inode inside the > > directory ? > > Which directory? I think Coly is refering to the idea of store-inode-inside-in-directory-file. It's

Re: block groups with no inode tables

2007-07-10 Thread Dave Kleikamp
On Tue, 2007-07-10 at 11:59 -0400, Mingming Cao wrote: > On Tue, 2007-07-10 at 12:40 -0500, Dave Kleikamp wrote: > > On Wed, 2007-07-11 at 01:30 +0800, coly li wrote: > > > Hi, once we decide to do this, how about storing inode inside the > > > directory ? > > > > Which directory? > I think Coly i

[PATCH 0/7][TAKE6] fallocate system call

2007-07-10 Thread Amit K. Arora
This is the latest fallocate patchset and is rebased to 2.6.22. Following are the changes from TAKE5: 1) Rebased to 2.6.22 2) Added compat wrapper for x86_64 3) Dropped s390 and ia64 patches, since the platform maintaners can add the support for fallocate once it is in mainline. 4) Added a chan

[PATCH 1/7] manpage for fallocate

2007-07-10 Thread Amit K. Arora
Following is the modified version of the manpage originally submitted by David Chinner. Please use `nroff -man fallocate.2 | less` to view. .TH fallocate 2 .SH NAME fallocate \- allocate or remove file space .SH SYNOPSIS .nf .B #include .PP .BI "int syscall(int, int fd, int mode, loff_t offset,

[PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> sys_fallocate() implementation on i386, x86_64 and powerpc fallocate() is a new system call being proposed here which will allow applications to preallocate space to any file(s) in a file system. Each file system implementation that wants to use this feature w

[PATCH 3/7] support new modes in fallocate

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> Implement new flags and values for mode argument. This patch implements the new flags and values for the "mode" argument of the fallocate system call. It is based on the discussion between Andreas Dilger and David Chinner on the man page proposed (by the later

[PATCH 4/7] ext4: fallocate support in ext4

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> fallocate support in ext4 This patch implements ->fallocate() inode operation in ext4. With this patch users of ext4 file systems will be able to use fallocate() system call for persistent preallocation. Current implementation only supports preallocation for r

[PATCH 5/7] ext4: write support for preallocated blocks

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> write support for preallocated blocks This patch adds write support to the uninitialized extents that get created when a preallocation is done using fallocate(). It takes care of splitting the extents into multiple (upto three) extents and merging the new spl

[PATCH 6/7] ext4: support new modes in ext4

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> Support new values of mode in ext4. This patch supports new mode values/flags in ext4. With this patch ext4 will be able to support FALLOC_ALLOCATE and FALLOC_RESV_SPACE modes. Supporting FALLOC_DEALLOCATE and FALLOC_UNRESV_SPACE fallocate modes in ext4 is a wo

[PATCH 7/7] ext4: change for better extent-to-group alignment

2007-07-10 Thread Amit K. Arora
From: Amit Arora <[EMAIL PROTECTED]> Change on-disk format for extent to represent uninitialized/initialized extents This change was suggested by Andreas Dilger as part of the following post: http://www.mail-archive.com/linux-ext4@vger.kernel.org/msg02445.html This patch changes the EXT_MAX_LEN v

Re: ext4-patch-queue rebased to 2.6.22

2007-07-10 Thread Andreas Dilger
On Jul 10, 2007 23:25 +0530, Amit K. Arora wrote: > On Tue, Jul 10, 2007 at 11:09:39AM -0600, Andreas Dilger wrote: > > It might even make sense to change the other #define to be called > > EXT_INIT_MAX_LEN so people have to think about this when using the #define. > > Done. Changes are in ext4 p

Re: block groups with no inode tables

2007-07-10 Thread Theodore Tso
On Tue, Jul 10, 2007 at 12:12:21PM -0500, Jose R. Santos wrote: > Hi folks, > > As I play with the allocation of the metadata for the FLEX_BG feature, > it seems that we could benefit from having block groups with no inode > tables. Right now we allocate one inode table per bg base on the > inode

Re: [PATCH 1/7] manpage for fallocate

2007-07-10 Thread Heikki Orsila
On Wed, Jul 11, 2007 at 01:48:20AM +0530, Amit K. Arora wrote: > .BI "int syscall(int, int fd, int mode, loff_t offset, loff_t len); Correction: "int syscall(int fd, int mode, ...)", > .SH "ERRORS" > .TP > .B EBADF > .I fd > is not a valid file descriptor, or is not opened for writing. > .TP > .B

[PATHC] Fix for ext2 reservation (Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Badari Pulavarty
On Tue, 2007-07-10 at 12:39 -0700, Martin Bligh wrote: > Andrew Morton wrote: > > > > Begin forwarded message: > > > > Date: Tue, 10 Jul 2007 21:49:23 +0400 > > From: Alexey Dobriyan <[EMAIL PROTECTED]> > > To: Andrew Morton <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED], linux-ext4@vger.kernel.or

Re: [EXT4 set 1][PATCH 1/2] Add noextents mount option

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:35:48 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Add a mount option to turn off extents. Please update the changelog to describe the reason for making this change. > Signed-off-by: Mingming Cao <[EMAIL PROTECTED]> > --- > Index: linux-2.6.22-rc4/fs/ext4/super.c > ===

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:01 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Turn on extents feature by default in ext4 filesystem. User could use > -o noextents to turn it off. > Oh, there you go. > > Index: linux-2.6.22-rc4/fs/ext4/super.c > ==

Re: [EXT4 set 2][PATCH 1/5] cleanups: Propagate some i_flags to disk

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:12 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Propagate flags such as S_APPEND, S_IMMUTABLE, etc. from i_flags into > ext4-specific i_flags. Hence, when someone sets these flags via a different > interface than ioctl, they are stored correctly. > This changelog is

Re: [EXT4 set 2][PATCH 3/5] cleanups: set_jbd2_64bit_feature for >16TB ext4 fs

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:32 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more > than 32bit block sizes during mount time. This ensure proper record > lenth when writing to the journal. This patch isn't in Ted's kernel.org directory

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but > > > create_proc_entry() does not do lookups on file names with more that one > > > direc

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:56 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch is a spinoff of the old nanosecond patches. I don't know what the "old nanosecond patches" are. A link to a suitable changlog for those patches would do in a pinch. Preferable would be to write a proper chan

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:04 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch converts the 32-bit i_version in the generic inode to a 64-bit > i_version field. > That's obvious from the patch. But what was the reason for making this (unrelated to ext4) change? Please update the chang

Re: [EXT4 set 4][PATCH 2/5] i_version: Add hi 32 bit inode version on ext4 on-disk inode

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:16 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used > for 64-bit inode versions. This field will store the higher 32 bits of the > version, while Jean Noel's patch has added support to store the

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > with the patch all headers are checked. the code should become > more resistant to on-disk corruptions. needless BUG_ON() have > been removed. please, review for inclusion. > > ... > @@ -269,6 +239,70 @@ > return

Re: [EXT4 set 4][PATCH 3/5] i_version:ext4 inode version read/store

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:36 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch adds 64-bit inode version support to ext4. The lower 32 bits > are stored in the osd1.linux1.l_i_version field while the high 32 bits > are stored in the i_version_hi field newly created in the ext4_inode. So

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:45 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch is on top of i_version_update_vfs. > The i_version field of the inode is set on inode creation and incremented when > the inode is being modified. > Again, I don't think I've ever seen this patch before. It

Re: [EXT4 set 4][PATCH 5/5] i_version: noversion mount option to disable inode version updates

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:53 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Add a "noversion" mount option to disable inode version updates. Why is this option being offered to our users? To reduce disk traffic, like noatime? If so, what are the implications of this? What would the user lose?

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:01 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > This patch is on top of the nanosecond timestamp and i_version_hi > patches. This sort of information isn't needed (or desired) when this patch hits the git tree. Please ensure that things like this are cleaned up befo

Re: [EXT4 set 1][PATCH 1/2] Add noextents mount option

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:35:48 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Add a mount option to turn off extents. > > Please update the changelog to describe the reason for making this change. > > Sure, I will update the change

Re: [EXT4 set 2][PATCH 3/5] cleanups: set_jbd2_64bit_feature for >16TB ext4 fs

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:36:32 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more > > than 32bit block sizes during mount time. This ensure proper record > > lenth when wri

Re: [PATHC] Fix for ext2 reservation (Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 15:15:57 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > Well, I looked at the problem now and here is the fix :) whee, thanks. > Greg, Please consider this for stable release also. No, it is only relevant to -mm's ext2-reservations.patch. - To unsubscribe from this lis

Re: [PATHC] Fix for ext2 reservation (Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Badari Pulavarty
On Tue, 2007-07-10 at 16:55 -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 15:15:57 -0700 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > Well, I looked at the problem now and here is the fix :) > > whee, thanks. > > > Greg, Please consider this for stable release also. > > No, it is onl

Re: [PATHC] Fix for ext2 reservation (Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Greg KH
On Tue, Jul 10, 2007 at 05:04:17PM -0700, Badari Pulavarty wrote: > On Tue, 2007-07-10 at 16:55 -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 15:15:57 -0700 > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > Well, I looked at the problem now and here is the fix :) > > > > whee, thank

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:36:01 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Turn on extents feature by default in ext4 filesystem. User could use > > -o noextents to turn it off. > > > > Oh, there you go. > > > > > Index: linux-2

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:37:04 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > This patch converts the 32-bit i_version in the generic inode to a 64-bit > > i_version field. > > > > That's obvious from the patch. But what was the rea

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 18:09:40 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > > On Sun, 01 Jul 2007 03:37:04 -0400 > > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > This patch converts the 32-bit i_version in the generic inode to a 64-b

Re: [PATCH 1/7] manpage for fallocate

2007-07-10 Thread Barry Naujok
On Wed, 11 Jul 2007 06:18:20 +1000, Amit K. Arora <[EMAIL PROTECTED]> wrote: Following is the modified version of the manpage originally submitted by David Chinner. Please use `nroff -man fallocate.2 | less` to view. A few more touch-ups attached. Regards, Barry. fallocate.2 Description: B

Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

2007-07-10 Thread Stephen Rothwell
On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > --- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c > +++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c > @@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64(int fd, > return sys_fadvise64_64(fd, ((u64)offset_hi << 3

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:10 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > [PATCH] jbd2 stats through procfs > > The patch below updates the jbd stats patch to 2.6.20/jbd2. > The initial patch was posted by Alex Tomas in December 2005 > (http://marc.info/?l=linux-ext4&m=113538565128617&w=2). >

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 18:22 -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 18:09:40 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > > > On Sun, 01 Jul 2007 03:37:04 -0400 > > > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > > > T

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Cédric Augonnet
2007/7/10, Andrew Morton <[EMAIL PROTECTED]>: Hi all, > + size = sizeof(struct transaction_stats_s); > + s->stats = kmalloc(size, GFP_KERNEL); > + if (s == NULL) { > + kfree(s); > + return -EIO; ENOMEM I'm sorry if i missed some point, but i just don't see

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Neil Brown
On Tuesday July 10, [EMAIL PROTECTED] wrote: > > Yes, thanks. It doesn't actually tell us why we want to implement > this attribute and it doesn't tell us what the implications of failing > to do so are, but I guess we can take that on trust from the NFS guys. You would like to think so, but rem

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Trond Myklebust
On Wed, 2007-07-11 at 13:21 +1000, Neil Brown wrote: > On Tuesday July 10, [EMAIL PROTECTED] wrote: > > > > Yes, thanks. It doesn't actually tell us why we want to implement > > this attribute and it doesn't tell us what the implications of failing > > to do so are, but I guess we can take that o

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-10 Thread Dave Jones
On Tue, Jul 10, 2007 at 05:35:13PM -0400, Mingming Cao wrote: > > Sorry about this. I was using version 0.04. The latest one I can find > for now is 0.05(searching lkml), but it didn't catch this codling style > bug either. I appreciate if anyone can point me the version 0.07, thanks It's now

Re: Initial results of FLEX_BG feature.

2007-07-10 Thread Andreas Dilger
On Jul 10, 2007 11:23 -0500, Jose R. Santos wrote: > I've started playing with the FLEX_BG feature (for now packing of > block group metadata closer together) and started doing some > preliminary benchmarking to see if the feature is worth pursuing. > I chose an FFSB profile that does single threa

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 20:19:16 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-10 at 18:22 -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 18:09:40 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > > > > On Sun, 01

Re: block groups with no inode tables

2007-07-10 Thread Andreas Dilger
On Jul 10, 2007 16:30 -0400, Theodore Tso wrote: > On Tue, Jul 10, 2007 at 12:12:21PM -0500, Jose R. Santos wrote: > > As I play with the allocation of the metadata for the FLEX_BG feature, > > it seems that we could benefit from having block groups with no inode > > tables. Right now we allocate

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Alexey Dobriyan
On Tue, Jul 10, 2007 at 11:21:49PM -0400, Cédric Augonnet wrote: > 2007/7/10, Andrew Morton <[EMAIL PROTECTED]>: > > Hi all, > > >> + size = sizeof(struct transaction_stats_s); > >> + s->stats = kmalloc(size, GFP_KERNEL); > >> + if (s == NULL) { ^ > >> + kfr

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 23:21:49 -0400 "Cédric Augonnet" <[EMAIL PROTECTED]> wrote: > 2007/7/10, Andrew Morton <[EMAIL PROTECTED]>: > > Hi all, > > > > + size = sizeof(struct transaction_stats_s); > > > + s->stats = kmalloc(size, GFP_KERNEL); > > > + if (s == NULL) { > > > +

Re: block groups with no inode tables

2007-07-10 Thread Andreas Dilger
On Jul 10, 2007 14:09 -0500, Dave Kleikamp wrote: > Assuming you mean the parent directory? An inode isn't tied to a > specific parent. > > ln dir1/file1 dir2/ > mv dir1/file1 dir3/ > rmdir dir1 > > What is happens to the inode? The inode stays in the same place, and the bloc

Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

2007-07-10 Thread Heiko Carstens
On Wed, Jul 11, 2007 at 12:10:34PM +1000, Stephen Rothwell wrote: > On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > > > --- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c > > +++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c > > @@ -879,3 +879,11 @@ asmlinkage long sys32

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > On Sun, 01 Jul 2007 03:36:56 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > This patch is a spinoff of the old nanosecond patches. > > I don't know what the "old nanosecond patches" are. A link to a suitable > changlog for those pa

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Neil Brown
It just occurred to me: If i_version is 64bit, then knfsd would need to be careful when reading it on a 32bit host. What are the locking rules? Presumably it is only updated under i_mutex protection, but having to get i_mutex to read it would seem a little heavy handed. Should it use a se

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Wed, 2007-07-11 at 13:21 +1000, Neil Brown wrote: > On Tuesday July 10, [EMAIL PROTECTED] wrote: > > > > Yes, thanks. It doesn't actually tell us why we want to implement > > this attribute and it doesn't tell us what the implications of failing > > to do so are, but I guess we can take that o

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 22:09:08 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > David Chinneer pointed that we need to journal the version number > updates together with the operations that causes the change of the inode > version number, in order to survive server crashes so clients won't see > the

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 21:42 -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 23:21:49 -0400 "Cédric Augonnet" <[EMAIL PROTECTED]> > wrote: > > > 2007/7/10, Andrew Morton <[EMAIL PROTECTED]>: > > > > Hi all, > > > > > > + size = sizeof(struct transaction_stats_s); > > > > + s->stats = k

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 15:05:27 +1000 Neil Brown <[EMAIL PROTECTED]> wrote: > > It just occurred to me: > > If i_version is 64bit, then knfsd would need to be careful when > reading it on a 32bit host. What are the locking rules? > > Presumably it is only updated under i_mutex protection, but

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 21:22 -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 20:19:16 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-10 at 18:22 -0700, Andrew Morton wrote: > > > On Tue, 10 Jul 2007 18:09:40 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > > > On Tue,

Re: Initial results of FLEX_BG feature.

2007-07-10 Thread Jose R. Santos
On Tue, 10 Jul 2007 22:12:14 -0600 Andreas Dilger <[EMAIL PROTECTED]> wrote: > On Jul 10, 2007 11:23 -0500, Jose R. Santos wrote: > > I've started playing with the FLEX_BG feature (for now packing of > > block group metadata closer together) and started doing some > > preliminary benchmarking to

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Jose R. Santos
On Tue, 10 Jul 2007 16:30:25 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 01 Jul 2007 03:36:48 -0400 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > > The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but > >

Re: Initial results of FLEX_BG feature.

2007-07-10 Thread Eric Sandeen
Jose R. Santos wrote: > On Tue, 10 Jul 2007 22:12:14 -0600 > Andreas Dilger <[EMAIL PROTECTED]> wrote: ... > >> You might also want to test out placement of the journal in the middle >> of the filesystem, the U. Wisconsin folks tested this in one of their >> papers and showed some noticable imp

Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:18 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > >From [EMAIL PROTECTED] Thu May 17 17:21:08 2007 > Hi, > > I have rebased this patch to 2.6.22-rc1 so that it can be added to the > ext4 patch queue. It has been tested by creating more than 65000 subdirs > and then dele

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Mingming Cao
On Wed, 2007-07-11 at 00:38 -0500, Jose R. Santos wrote: > On Tue, 10 Jul 2007 16:30:25 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Sun, 01 Jul 2007 03:36:48 -0400 > > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > > On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: > > > > > T

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 23:35 -0400, Dave Jones wrote: > On Tue, Jul 10, 2007 at 05:35:13PM -0400, Mingming Cao wrote: > > > > Sorry about this. I was using version 0.04. The latest one I can find > > for now is 0.05(searching lkml), but it didn't catch this codling style > > bug either. I appre

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:25 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Journal checksum feature has been added to detect corruption of journal. That was brief. No description of what it does, how it does it, why it does it, how one operates it, why (or why not) one would choose to enable i

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 22:17 -0700, Andrew Morton wrote: > On Tue, 10 Jul 2007 22:09:08 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > David Chinneer pointed that we need to journal the version number > > updates together with the operations that causes the change of the inode > > version numb

Re: [EXT4 set 9][PATCH 4/5]Morecleanups:ext4_extent_compilation_fixes

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:51 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > Subject: [EXT4 set 9][PATCH 4/5]Morecleanups:ext4_extent_compilation_fixes > Date: Sun, 01 Jul 2007 03:38:51 -0400 > Sender: [EMAIL PROTECTED] > Organization: IBM Linux Technology Center > X-Mailer: Evolution 2.8.

Re: [EXT4 set 9][PATCH 5/5]Extent micro cleanups

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:38:59 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > From: Dmitry Monakhov <[EMAIL PROTECTED]> > Subject: ext4: extent macros cleanup > > - Replace math equation to it's macro equivalent s/it's/its/;) > - make ext4_ext_grow_indepth() indexes/leaf correct hm, what was wr

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 00:38:09 -0500 "Jose R. Santos" <[EMAIL PROTECTED]> wrote: > > > Alternatively (and preferably) do this via an update to > > Documentation/filesystems/ext4.txt. > > Seems like I also need to update the doc on Kconfig as well. Do you > prefer this in separate patches? (curren

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 23:18:50 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-10 at 22:17 -0700, Andrew Morton wrote: > > On Tue, 10 Jul 2007 22:09:08 -0400 Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > > David Chinneer pointed that we need to journal the version number > > > upd