Re: [PATCH] Introduce ext4_find_next_bit

2007-09-20 Thread Balbir Singh
Aneesh Kumar K.V wrote: > Also add generic_find_next_le_bit > > This gets used by the ext4 multi block allocator patches. > Looks like it's a straight forward on Little Endian Architectures. I see something for powerpc, what about other architectures? > > +unsigned long generic_find_next_le_bi

Re: [PATCH] ext4: Fix spare warnings

2007-09-20 Thread Balbir Singh
Aneesh, The subject is a bit confusing, I presume you mean sparse warnings Balbir - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: + ext4-uninitialized-block-groups-fix.patch added to -mm tree

2007-09-20 Thread Aneesh Kumar K.V
[EMAIL PROTECTED] wrote: The patch titled Ext4: Uninitialized Block Groups (fix) has been added to the -mm tree. Its filename is ext4-uninitialized-block-groups-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/li

[PATCH] ext4: Fix spare warnings

2007-09-20 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/inode.c |6 -- include/linux/ext4_fs.h | 16 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index a4848e0..307e240 100644 --- a/fs/ext4/inode.c +++

[PATCH] Introduce ext4_find_next_bit

2007-09-20 Thread Aneesh Kumar K.V
Also add generic_find_next_le_bit This gets used by the ext4 multi block allocator patches. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- include/asm-generic/bitops/ext2-non-atomic.h |2 + include/asm-generic/bitops/le.h |4 ++ include/asm-powerpc/bitops.h

+ ext4-uninitialized-block-groups-fix.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled Ext4: Uninitialized Block Groups (fix) has been added to the -mm tree. Its filename is ext4-uninitialized-block-groups-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-m

Ext4 patch queue updated(2.6.23-rc6)

2007-09-20 Thread Mingming Cao
http://repo.or.cz/w/ext4-patch-queue.git Changes since last time Updated uninit block group patch Updated mballoc core patch Update jbd cleanup patch Removed large block support patch (as the 64k blk size rec_len overflow patch might be updated later) reordered serise file Appreciate any testi

+ exportfs-make-struct-export_operations-const.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled exportfs: make struct export_operations const has been added to the -mm tree. Its filename is exportfs-make-struct-export_operations-const.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/

+ exportfs-remove-old-methods.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled exportfs: remove old methods has been added to the -mm tree. Its filename is exportfs-remove-old-methods.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out

+ exportfs-add-fid-type.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled exportfs: add fid type has been added to the -mm tree. Its filename is exportfs-add-fid-type.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do a

+ exportfs-update-documentation.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled exportfs: update documentation has been added to the -mm tree. Its filename is exportfs-update-documentation.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find

+ exportfs-add-new-methods.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled exportfs: add new methods has been added to the -mm tree. Its filename is exportfs-add-new-methods.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what t

+ ext4-new-export-ops.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled ext4: new export ops has been added to the -mm tree. Its filename is ext4-new-export-ops.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about

+ ext3-new-export-ops.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled ext3: new export ops has been added to the -mm tree. Its filename is ext3-new-export-ops.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about

+ ext4-uninitialized-block-groups.patch added to -mm tree

2007-09-20 Thread akpm
The patch titled Ext4: Uninitialized Block Groups has been added to the -mm tree. Its filename is ext4-uninitialized-block-groups.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to f

Re: [PATCH] Ext4: Uninitialized Block Groups

2007-09-20 Thread Andrew Morton
On Tue, 18 Sep 2007 17:25:31 -0700 Avantika Mathur <[EMAIL PROTECTED]> wrote: > In pass1 of e2fsck, every inode table in the fileystem is scanned and > checked, > regardless of whether it is in use. This is this the most time consuming > part > of the filesystem check. The unintialized block

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

2007-09-20 Thread Theodore Tso
On Thu, Sep 20, 2007 at 03:22:16PM -0500, Eric Sandeen wrote: > I'd do this, my rpm-fu is still reasonably strong, though - I'm curious, > is there a compelling reason to split out just libcom-err? what about > libuuid? libblkid? e2fsprogs is a bit of a grab bag of things. What's > the rational

- ext34-ensure-do_split-leaves-enough-free-space-in-both-blocks.patch removed from -mm tree

2007-09-20 Thread akpm
The patch titled ext34: ensure do_split leaves enough free space in both blocks has been removed from the -mm tree. Its filename was ext34-ensure-do_split-leaves-enough-free-space-in-both-blocks.patch This patch was dropped because it was merged into mainline or a subsystem tree -

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

2007-09-20 Thread Andreas Dilger
On Sep 20, 2007 15:22 -0500, Eric Sandeen wrote: > I'd do this, my rpm-fu is still reasonably strong, though - I'm curious, > is there a compelling reason to split out just libcom-err? what about > libuuid? libblkid? e2fsprogs is a bit of a grab bag of things. What's > the rationale for the sp

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

2007-09-20 Thread Eric Sandeen
Andreas Dilger wrote: > On Sep 19, 2007 20:41 -0500, Eric Sandeen wrote: >> Andreas Dilger wrote: >>> It isn't possible to build an e2fsprogs via "make rpm" on SuSE and have it >>> install cleanly, because they split out some of the libraries into separate >>> packages. >>> >>> We've got the curre

Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

2007-09-20 Thread Theodore Tso
This is what I actually committed into e2fsprogs git, in the maint branch. Note the one-line summary at the beginning of the patch description, and the Addresses-Red-Hat-Bugzilla line before the Signed-off-by lines. - Ted commit ed773a263829493e4e4

Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

2007-09-20 Thread Theodore Tso
It might also be worthwhile to file a documentation bug against the mount and fstab man pages, since it doesn't currently seem to specify (at least on my Ubuntu system; maybe it's been fixed in newer upstream packages) that you can specify the bind option in the fstab file. /src/dest ext3

Re: Avoid rec_len overflow with 64KB block size

2007-09-20 Thread Andreas Dilger
On Sep 20, 2007 18:17 +0200, Jan Kara wrote: > > when converting ext4 directories to pagecache I just came over > > Takashi's patch preventing overflowing of rec_len. Looking over the > > patch - can't we do it more elegantly by using say 0x instead of 64K > > and perform conversion (using s

[PATCH e2fsprogs] return status from chattr

2007-09-20 Thread Eric Sandeen
This is for RH bug #180596, Chattr command doesn't provide expected exit code in case of failure. (trying to clear out an e2fsprogs bug backlog, can you tell?) :) This is a little funky as a result of the man page saying that links encountered on recursive traversal are (silently?) ignored. I

Re: Enabling h-trees too early?

2007-09-20 Thread Theodore Tso
On Thu, Sep 20, 2007 at 06:19:04PM +0200, Jan Kara wrote: > if (EXT4_HAS_COMPAT_FEATURE(inode->i_sb, EXT4_FEATURE_COMPAT_DIR_INDEX) && > ((EXT4_I(inode)->i_flags & EXT4_INDEX_FL) || > ((inode->i_size >> sb->s_blocksize_bits) == 1))) { > error = ext4_dx_readdir(filp, dirent, filldir

Re: Avoid rec_len overflow with 64KB block size

2007-09-20 Thread Jan Kara
> when converting ext4 directories to pagecache I just came over > Takashi's patch preventing overflowing of rec_len. Looking over the > patch - can't we do it more elegantly by using say 0x instead of 64K > and perform conversion (using some helper) at the moment we read / store > rec_len? T

Re: Enabling h-trees too early?

2007-09-20 Thread Jan Kara
On Thu 20-09-07 11:14:40, Theodore Tso wrote: > On Thu, Sep 20, 2007 at 04:58:39PM +0200, Jan Kara wrote: > > Hmm, strange - I've just looked at my computer and dir_index is set > > just for 5 directories in my tree. > > I looked at a tree that had object files, which is probably why I had > 8 d

Re: Enabling h-trees too early?

2007-09-20 Thread Theodore Tso
On Thu, Sep 20, 2007 at 04:58:39PM +0200, Jan Kara wrote: > Hmm, strange - I've just looked at my computer and dir_index is set > just for 5 directories in my tree. I looked at a tree that had object files, which is probably why I had 8 directories; I'm guessing you probably just had kernel sour

Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

2007-09-20 Thread Eric Sandeen
Theodore Tso wrote: > On Thu, Sep 20, 2007 at 09:31:56AM -0500, Eric Sandeen wrote: > >> Agreed. If you think fsck shouldn't silently cope with this mistake, >> and instead punish the user for it (it is what they asked for, after >> all), I'm ok with that too. I'm willing to close my end as NO

Re: Enabling h-trees too early?

2007-09-20 Thread Jan Kara
> On Thu, Sep 20, 2007 at 03:33:50PM +0200, Jan Kara wrote: > > So for example deleting kernel tree on my computer takes ~14 seconds with > > h-trees and less than 9 without them. Also doing 'cp -lr' of the kernel > > tree takes 8 seconds with h-trees and 6.3s without them... So I think the > > p

Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

2007-09-20 Thread Theodore Tso
On Thu, Sep 20, 2007 at 09:31:56AM -0500, Eric Sandeen wrote: > Agreed. If you think fsck shouldn't silently cope with this mistake, > and instead punish the user for it (it is what they asked for, after > all), I'm ok with that too. I'm willing to close my end as NOTABUG if > you don't want to t

Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

2007-09-20 Thread Eric Sandeen
Theodore Tso wrote: > On Wed, Sep 19, 2007 at 03:20:14PM -0500, Eric Sandeen wrote: >> An entry like this in /etc/fstab: >> >> /foo /barext3bind,defaults 1 3 >> >> will stop boot, as fsck.ext3 tries to check it and fails: >> >> e2fsck 1.40.2 (12-Jul-2007) >> fsck.ext3: Is a directory whil

Avoid rec_len overflow with 64KB block size

2007-09-20 Thread Jan Kara
Hello, when converting ext4 directories to pagecache I just came over Takashi's patch preventing overflowing of rec_len. Looking over the patch - can't we do it more elegantly by using say 0x instead of 64K and perform conversion (using some helper) at the moment we read / store rec_len?

Re: Enabling h-trees too early?

2007-09-20 Thread Theodore Tso
On Thu, Sep 20, 2007 at 03:33:50PM +0200, Jan Kara wrote: > So for example deleting kernel tree on my computer takes ~14 seconds with > h-trees and less than 9 without them. Also doing 'cp -lr' of the kernel > tree takes 8 seconds with h-trees and 6.3s without them... So I think the > performance

Re: Enabling h-trees too early?

2007-09-20 Thread Jan Kara
On Wed 19-09-07 14:24:50, Theodore Tso wrote: > On Wed, Sep 19, 2007 at 05:07:15PM +0200, Jan Kara wrote: > > > > I was just wondering: Currently we start to build h-tree in a directory > > already when the size of directory exceeds one block. But honestly, it does > > not seem to make much senc

Ext3 not marking filesystems as with errors

2007-09-20 Thread Jan Kara
Hi, one friend has just pointed me to a following misbehaviour of ext3. If we stumble on some error in JBD (e.g. in commit code), we call __journal_abort_hard(). It just marks the journal as aborted but does nothing else. Later ext3 comes, finds journal aborted, calls ext3_abort() which remoun