[PATCH 3/7] ext4: Convert s_blocks_count_hi and s_blocks_count to le32_t

Convert s_blocks_count_hi and s_blocks_count to le32_t This helps in finding BUGs due to direct partial access of these split 64 bit values Also fix direct partial access in ext4 code Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/mballoc.c |4 ++-- fs/ext4/super.c

[PATCH 7/7] ext4: sparse fixes

Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/fsync.c |2 +- fs/ext4/xattr.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 2a167d7..8d50879 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -47,7 +47,7

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

Andreas, The patches are on top of patch queue. I haven't touched the uid and gid of ext4_inode. Do you think i should change that too ? 7/7 is not the part of the series. But it is important. Should i send it as a separate patch for the 2.6.24 ? -aneesh - To unsubscribe from this list: send

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

On Mon, Sep 24, 2007 at 08:40:36AM -0400, Theodore Tso wrote: On Mon, Sep 24, 2007 at 11:25:39AM +0200, Karel Zak wrote: Nope, there isn't much rationale unless we also split out fsck, so util-linux-ng is open for fsck :-) It's something I'm considering, but at the moment I've got

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

On Sep 25, 2007 14:41 +0530, Aneesh Kumar K.V wrote: The patches are on top of patch queue. I haven't touched the uid and gid of ext4_inode. Do you think i should change that too ? You can add a Signed-off-by: Andreas Dilger [EMAIL PROTECTED] to those patches. As I suspected there were a

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

On Tue, Sep 25, 2007 at 12:11:23PM +0200, Kay Sievers wrote: On Tue, 2007-09-25 at 11:14 +0200, Karel Zak wrote: Now we duplicate a lot of FS probe code in libblkid, libvolume_id and libdisk. Yes, it's long-term task, but it's good direction (IMHO). It is, and we are not providing

Re: jbd : config_jbd_debug cannot create /proc entry

On Tue, 25 Sep 2007 07:49:38 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 13:50:46 +0200 Jan Kara [EMAIL PROTECTED] wrote: Jan Kara wrote: -#define create_jbd_proc_entry() do {} while (0) -#define remove_jbd_proc_entry() do {} while (0) +static ctl_table

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote: ext4 file system layout contain different split members like bg_block_bitmap and bg_block_bitmap_hi. Introduce data type le32_t and le16_t to be used as the type of these split members. This prevents these members frome being

Re: [PATCH] Fix commit code to properly abort journal

And a similar patch for JBD2... Honza - We should really call journal_abort() and not __journal_abort_hard() in case of errors. The latter call does not record the error in the journal superblock and thus filesystem

Re: jbd : config_jbd_debug cannot create /proc entry

On Tue, 25 Sep 2007 07:49:38 -0500 Jose R. Santos [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007 13:50:46 +0200 Jan Kara [EMAIL PROTECTED] wrote: Jan Kara wrote: -#define create_jbd_proc_entry() do {} while (0) -#define remove_jbd_proc_entry() do {} while (0) +static

Re: [PATCH 1/7] ext4: Introduce le32_t and le16_t

Dave Kleikamp wrote: On Tue, 2007-09-25 at 14:33 +0530, Aneesh Kumar K.V wrote: ext4 file system layout contain different split members like bg_block_bitmap and bg_block_bitmap_hi. Introduce data type le32_t and le16_t to be used as the type of these split members. This prevents these

[PATCH] Support for 64KB blocksize in e2fsprogs

Hi, attached patch implements support for 64KB blocksize in directories in e2fsprogs. This patch complements the kernel patches for ext2-4 I've sent yesterday. Ted, does the patch look fine? Honza -- Jan Kara [EMAIL PROTECTED]

[PATCH] JBD: Export jbd-debug via debugfs

From: Jose R. Santos [EMAIL PROTECTED] JBD: Export jbd-debug via debugfs The jbd-debug file used to be located in /proc/sys/fs/jbd-debug, but create_proc_entry() does not do lookups on file names that are more that one directory deep. This causes the entry creation to fail and hence, no proc

[PATCH 1/7] ext4: Convert bg_block_bitmap to bg_block_bitmap_lo

Convert bg_block_bitmap to bg_block_bitmap_lo This helps in catching some BUGS due to direct partial access of these split fields. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/super.c |6 +++--- include/linux/ext4_fs.h |2 +- 2 files changed, 4 insertions(+), 4

[PATCH 5/7] ext4: Convert ext4_extent.ee_start to ext4_extent.ee_start_lo

Convert ext4_extent.ee_start to ext4_extent.ee_start_lo This helps in finding BUGs due to direct partial access of these split 48 bit values Also fix direct partial access in ext4 code Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/extents.c |8 +++-

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

On Tue, 2007-09-25 at 14:34 +0200, Karel Zak wrote: On Tue, Sep 25, 2007 at 12:11:23PM +0200, Kay Sievers wrote: On Tue, 2007-09-25 at 11:14 +0200, Karel Zak wrote: Now we duplicate a lot of FS probe code in libblkid, libvolume_id and libdisk. Yes, it's long-term task, but it's

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

On Tue, Sep 25, 2007 at 10:25:50PM +0200, Kay Sievers wrote: On Tue, 2007-09-25 at 14:34 +0200, Karel Zak wrote: On Tue, Sep 25, 2007 at 12:11:23PM +0200, Kay Sievers wrote: On Tue, 2007-09-25 at 11:14 +0200, Karel Zak wrote: Now we duplicate a lot of FS probe code in libblkid,

Re: [PATCH] obsolete libcom-err for SuSE e2fsprogs

On Tue, Sep 25, 2007 at 10:25:50PM +0200, Kay Sievers wrote: Technical details :-) What do you miss, these are all technical details. :) In simple words, we need a completely policy-free, not try-to-be-smart in any sense set of functions to identify a bytestream by magic bytes. Which is