[PATCH] ext2: Return after ext2_error in case of failures

2007-10-24 Thread Aneesh Kumar K.V
This fix some instances where we were continuing after calling ext2_error. ext2_error call panic only if errors=panic mount option is set. So we need to make sure we return correctly after ext2_error call Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext2/balloc.c | 12 +---

[PATCH] ext2: Change the default behaviour on error

2007-10-24 Thread Aneesh Kumar K.V
ext2 file system was by default ignoring errors and continuing. This is not a good default as continuing on error could lead to file system corruption. Change the default to mark the file system readonly. Debian and ubuntu already does this as the default in their fstab. Signed-off-by: Aneesh Kuma

[PATCH] ext3: Change the default behaviour on error

2007-10-24 Thread Aneesh Kumar K.V
ext3 file system was by default ignoring errors and continuing. This is not a good default as continuing on error could lead to file system corruption. Change the default to mark the file system readonly. Debian and ubuntu already does this as the default in their fstab. Signed-off-by: Aneesh Kuma

[PATCH] ext3: Return after ext3_error in case of failures

2007-10-24 Thread Aneesh Kumar K.V
This fix some instances where we were continuing after calling ext3_error. ext3_error calls panic only if errors=panic mount option is set. So we need to make sure we return correctly after ext3_error call Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext3/balloc.c | 12 +--

Re: User permissions or UID/GIDs for portable disks?

2007-10-24 Thread Eric
On Wed, 2007-10-24 at 20:10 +0200, Bram Neijt wrote: > One of the best solutions I can come up with is if the filesystem > would allow for a switch that would help ignore these permissions as > part of the filesystem. Ignoring file permissions on removable, user-supplied media sounds like somethin

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Andreas Dilger
On Oct 24, 2007 16:15 -0500, Eric Sandeen wrote: > Andreas Dilger wrote: > > It is useful to be able to mount w/o extents/delalloc/mballoc for perf > > testing and functional testing of the block-mapped file path in ext4. > > Also, some users might want the ability to use features of ext4 w/o > >

+ ext2-fix-the-max-file-size-for-ext2-file-system.patch added to -mm tree

2007-10-24 Thread akpm
The patch titled ext2: fix the max file size for ext2 file system has been added to the -mm tree. Its filename is ext2-fix-the-max-file-size-for-ext2-file-system.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/pa

+ ext4-return-after-ext4_error-in-case-of-failures.patch added to -mm tree

2007-10-24 Thread akpm
The patch titled ext4: return after ext4_error in case of failures has been added to the -mm tree. Its filename is ext4-return-after-ext4_error-in-case-of-failures.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/

+ ext3-fix-the-max-file-size-for-ext3-file-system.patch added to -mm tree

2007-10-24 Thread akpm
The patch titled ext3: fix the max file size for ext3 file system has been added to the -mm tree. Its filename is ext3-fix-the-max-file-size-for-ext3-file-system.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://www.zip.com.au/~akpm/linux/pa

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Eric Sandeen
Andreas Dilger wrote: > On Oct 24, 2007 12:22 -0500, Eric Sandeen wrote: >> Aneesh Kumar K.V wrote: >>> @@ -1279,6 +1280,9 @@ clear_qf_name: >>> case Opt_delalloc: >>> set_opt (sbi->s_mount_opt, DELALLOC); >>> break; >> If delalloc, mballoc, exte

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Andreas Dilger
On Oct 24, 2007 12:22 -0500, Eric Sandeen wrote: > Aneesh Kumar K.V wrote: > > @@ -1279,6 +1280,9 @@ clear_qf_name: > > case Opt_delalloc: > > set_opt (sbi->s_mount_opt, DELALLOC); > > break; > > If delalloc, mballoc, extents are the new default

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Mingming Cao
On Wed, 2007-10-24 at 12:22 -0500, Eric Sandeen wrote: > Aneesh Kumar K.V wrote: > > > @@ -1279,6 +1280,9 @@ clear_qf_name: > > case Opt_delalloc: > > set_opt (sbi->s_mount_opt, DELALLOC); > > break; > > If delalloc, mballoc, extents are the new

Re: [PATCH] ext4: Fix ext4_show_options to show the correct mount options.

2007-10-24 Thread Eric Sandeen
Aneesh Kumar K.V wrote: > So my understanding was that we are supposed to make /proc/mounts show the > same output as > /etc/mtab did. In that case should we be showing the the default set in super > block ? > > -aneesh Hm, well, it's true that they would not show up in mtab... but to me it's

Re: [PATCH] ext4: Fix ext4_show_options to show the correct mount options.

2007-10-24 Thread Aneesh Kumar K.V
Eric Sandeen wrote: Aneesh Kumar K.V wrote: We need to look at the default value and make sure the mount options are not set via default value before showing them via ext4_show_options Hm, does this jive with the comment about what's intended? /* * Show an option if * - it's set to a non

User permissions or UID/GIDs for portable disks?

2007-10-24 Thread Bram Neijt
Dear ext4 developers, Currently using ext3 on an usbstick seems to have a few drawbacks. Consider the following situations: 1. Lend my usbstick to a college at work, but I don't want them to be able to place files on it which I can't delete at work (where I don't have root access). 2. Lend my usbs

Re: Ext4 devel interlock meeting minutes (October 22, 2007)

2007-10-24 Thread Jan Kara
Hello, Sorry for not taking part in the call but I was just on my way from NY to Prague... > Ext4 Developer Interlock Call > October 22, 2007: Meeting Minutes > > Attendees: Mingming Cao, Andreas Dilger, Eric Sandeen, Dave Kleikamp, > Jose Santos, Aneesh Veetil, Valerie Clement, Avantika Ma

Re: [PATCH] ext4: Fix ext4_show_options to show the correct mount options.

2007-10-24 Thread Eric Sandeen
Aneesh Kumar K.V wrote: > We need to look at the default value and make sure > the mount options are not set via default value > before showing them via ext4_show_options Hm, does this jive with the comment about what's intended? /* * Show an option if * - it's set to a non-default value OR *

Re: [PATCH] ext4: Show mballoc and delalloc options

2007-10-24 Thread Eric Sandeen
Aneesh Kumar K.V wrote: > Both these options are enabled by default. > So if they are are not set in mount options > that means the user explicity disabled them > using nomablloc and nodelalloc option. Show > the same in ext4_show_options Looks good, Acked-By: Eric Sandeen <[EMAIL PROTECTED]> >

Patches for review

2007-10-24 Thread Aneesh Kumar K.V
Send some patches which are in my local repo for review. The compile bench fix patch is already in patch queue. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Aneesh Kumar K.V
Eric Sandeen wrote: Aneesh Kumar K.V wrote: @@ -1279,6 +1280,9 @@ clear_qf_name: case Opt_delalloc: set_opt (sbi->s_mount_opt, DELALLOC); break; If delalloc, mballoc, extents are the new defaults, is there a reason to keep them

Re: [PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Eric Sandeen
Aneesh Kumar K.V wrote: > @@ -1279,6 +1280,9 @@ clear_qf_name: > case Opt_delalloc: > set_opt (sbi->s_mount_opt, DELALLOC); > break; If delalloc, mballoc, extents are the new defaults, is there a reason to keep them as options? When would

[PATCH] ext4: Enable delalloc and mballoc by default.

2007-10-24 Thread Aneesh Kumar K.V
This ensure we test the latest features more easily. We need an option to clear delayed alloc feature. Add nodealloc option. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/super.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fs/ext4/super.c b/fs

[PATCH] ext4: Fix mballoc BUG when running compilebench

2007-10-24 Thread Aneesh Kumar K.V
This fix the mballoc bug when running compile bench. Instead of using direct division even though the arguments are 32 bits we retain do_div. This would be needed if we move to 64 bit logical block number. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/mballoc.c |7 --- 1

Patches for review

2007-10-24 Thread Aneesh Kumar K.V
Send some patches which are in my local repo for review. The compile bench fix patch is already in patch queue. GIT: Please enter your email below. GIT: Lines beginning in "GIT: " will be removed. GIT: Consider including an overall diffstat or table of contents GIT: for the patch you are writing.

[PATCH] ext4: Fix ext4_show_options to show the correct mount options.

2007-10-24 Thread Aneesh Kumar K.V
We need to look at the default value and make sure the mount options are not set via default value before showing them via ext4_show_options Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/super.c | 28 1 files changed, 16 insertions(+), 12 deletions

[PATCH] ext4: Change the default behaviour on error

2007-10-24 Thread Aneesh Kumar K.V
ext4 file system was by default ignoring errors and continuing. This is not a good default as continuing on error could lead to file system corruption. Change the default to mark the file system readonly. Debian and ubuntu already does this as the default in their fstab. Signed-off-by: Aneesh Kuma

[PATCH] ext4: Show mballoc and delalloc options

2007-10-24 Thread Aneesh Kumar K.V
Both these options are enabled by default. So if they are are not set in mount options that means the user explicity disabled them using nomablloc and nodelalloc option. Show the same in ext4_show_options Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/super.c |6 ++ 1 fil

Patches for review

2007-10-24 Thread Aneesh Kumar K.V
Send some patches which are in my local repo for review. The compile bench fix patch is already in patch queue. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[2.6 patch] make jbd/journal.c:__journal_abort_hard() static

2007-10-24 Thread Adrian Bunk
__journal_abort_hard() can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fs/jbd/journal.c|2 +- include/linux/jbd.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) ce452fbc5ebf8a4751183cfb731496c595b4ef6f diff --git a/fs/jbd/journal.c b/fs/jbd/journal