+ ext4-check-for-the-correct-error-return-from-ext4_ext_get_blocks-fix.patch added to -mm tree

The patch titled ext4-check-for-the-correct-error-return-from-ext4_ext_get_blocks-fix has been added to the -mm tree. Its filename is ext4-check-for-the-correct-error-return-from-ext4_ext_get_blocks-fix.patch *** Remember to use Documentation/SubmitChecklist when testing your code ***

+ ext4-check-for-the-correct-error-return-from-ext4_ext_get_blocks.patch added to -mm tree

The patch titled ext4: check for the correct error return from ext4_ext_get_blocks has been added to the -mm tree. Its filename is ext4-check-for-the-correct-error-return-from-ext4_ext_get_blocks.patch *** Remember to use Documentation/SubmitChecklist when testing your code *** See ht

Re: [PATCH 1/4] ext4: minor fix in jbd2 stats kmalloc failure case

On Mon, 2007-12-03 at 17:29 -0600, Eric Sandeen wrote: > (Mingming: these 4 patches can apply after > jbd-stats-through-procfs-with-external-journal-oops-fix.patch) > Thanks Eric, looks all good to me. Updated the patch queue with the four jbd2 stats fixes from you. Mingming - To unsubscribe fr

[PATCH 4/4] ext4: open-code jbd2 stats union references

open-code references to stats unions for clarity, as suggested by akpm on his review. Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> --- Index: linux-2.6.24-rc3/fs/jbd2/commit.c === --- linux-2.6.24-rc3.orig/fs/jbd2/commit.c +++ li

[PATCH 3/4] ext4: accumulate jbd2 stats in jiffies

Accumulate jbd2 stats in jiffies not msecs, per akpm's suggestion. Convert to msecs on when displayed. jbd2_time_diff() should still be moved to a common header file. Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> --- Index: linux-2.6.24-rc3/fs/jbd2/checkpoint.c ==

[PATCH 2/4] ext4: Address various akpm jbd2 stats comments

(Andrew, cc'ing you since these address your original review comments; feel free to just pick the patch up via Ted/Mingming if you prefer) Address several of akpm's comments on the jbd2 stats patch: o return -ENOMEM not -EIO on memory failure o avoid unneeded casts of void pointers o minor format

[PATCH 1/4] ext4: minor fix in jbd2 stats kmalloc failure case

(Mingming: these 4 patches can apply after jbd-stats-through-procfs-with-external-journal-oops-fix.patch) - The other instance of this problem was caught, but this one got missed: Free the correct pointer on s->stats allocation

Re: [RFC] Flex_BG ialloc awareness.

On Dec 03, 2007 13:05 -0600, Jose R. Santos wrote: > @@ -600,6 +600,7 @@ void ext4_free_blocks_sb(handle_t *handle, struct > super_block *sb, > ext4_grpblk_t group_freed; > + ext4_group_t meta_group; Please do not call these meta_groups. This already means something very specific (i.e

[PATCH] e2fsprogs: make the undo io manager an option

Hello, This applies to the -pu branch of the e2fsprogs git tree. Went to reformat my ext3 fs and found it was taking way too long, turns out its because the undo io manager was doing its thing. This patch makes this an option, and turns it off by default. I opted for off by default so users don

Re: Understanding mballoc

On Dec 03, 2007 23:42 +0530, Aneesh Kumar K.V wrote: > This is my attempt at understanding multi block allocator. I have > few questions marked as FIXME below. Can you help answering them. > Most of this data is already in the patch queue as commit message. > I have updated some details regarding

[RFC] Flex_BG ialloc awareness.

Hi folk, Im preparing to clean up the FLEX_BG ialloc patch for inclusion into the patch queue and decided that might as well send the current version of the patch to the mailing list to get any early feedback from folks. This patch mostly controls the way inode are allocated in order to make iall

Understanding mballoc

Alex, This is my attempt at understanding multi block allocator. I have few questions marked as FIXME below. Can you help answering them. Most of this data is already in the patch queue as commit message. I have updated some details regarding preallocation. Once we understand the details i will up

Re: [PATCH] fix up vfs inode version patch for modules

On Wed, 2007-11-28 at 14:33 -0600, Eric Sandeen wrote: > ext4 calls inode_inc_iversion(), but it's not exported, so modular ext4 > has trouble. Any reason not to just make it an inline, as below? > I agree. Mingming > Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> > > --- > > Index: linux-2.

[patch] ext4 i_version: make the flag visible on /proc/mounts

Hi, This patch adds the i_version flag in ext4_show_options(). Index: linux-2.6.24-rc3-ext4-1/fs/ext4/super.c === --- linux-2.6.24-rc3-ext4-1.orig/fs/ext4/super.c2007-12-03 16:14:55.0 +0100 +++ linux-2.6.24-rc3-ext

Re: [PATCH] ext4: Check for the correct error return from ext4_ext_get_blocks

Aneesh Kumar K.V wrote: > ext4_ext_get_blocks returns negative values on error. We should > check for <= 0 > > Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> > --- > fs/ext4/extents.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ex

[PATCH] ext4: Check for the correct error return from ext4_ext_get_blocks

ext4_ext_get_blocks returns negative values on error. We should check for <= 0 Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/extents.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index a2475d4..ce57245 100644

[RFC][PATCH 2/3] ext4: Convert truncate_mutex to read write semaphore.

We are currently taking the truncate_mutex for every read. This would have performance impact on large CPU configuration. Convert the lock to read write semaphore and take read lock when we are trying to read the file. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/balloc.c

[RFC][PATCH 3/3] ext4: Take read lock during overwrite case.

When we are overwriting a file and not actually allocating new file system blocks we need to take only the read lock on i_data_sem. Signed-off-by: Aneesh Kumar K.V <[EMAIL PROTECTED]> --- fs/ext4/inode.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) d

[RFC][PATCH 1/3] ext4: Make ext4_get_blocks_wrap take the truncate_mutex early.

When doing a migrate from ext3 to ext4 inode we need to make sure the test for inode type and walking inode data happens inside lock. To make this happen move truncate_mutex early before checking the i_flags. This actually should enable us to remove the verify_chain(). Signed-off-by: Aneesh Kum

[RFC] truncate_mutex read write semaphore conversion

The below patchset is NOT for patch queue. I am posting it here to get feedback regarding the approach and what test I need to run to make sure we are not breaking any locking rules. I have run dbench, ffsb, fsstress, fs_di, fs_inode, fsx_linux . Bonnie didn't run completely. In the automated setu